| Message ID | 20210617162754.2028048-10-kumar.amber@intel.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | MFEX Infrastructure + Optimizations | expand |
On Thu, Jun 17, 2021 at 09:57:51PM +0530, Kumar Amber wrote: > From: Harry van Haaren <harry.van.haaren@intel.com> > > This commit enables OVS to at runtime check for more detailed > AVX512 capabilities, specifically Byte and Word (BW) extensions, > and Vector Bit Manipulation Instructions (VBMI). > > These instructions will be used in the CPU ISA optimized > implementations of traffic profile aware miniflow extract. > > Signed-off-by: Harry van Haaren <harry.van.haaren@intel.com> > --- Acked-by: Flavio Leitner <fbl@sysclose.org> fbl
Thanks Flavio. > -----Original Message----- > From: Flavio Leitner <fbl@sysclose.org> > Sent: Monday, June 28, 2021 8:29 AM > To: Amber, Kumar <kumar.amber@intel.com> > Cc: dev@openvswitch.org; i.maximets@ovn.org > Subject: Re: [ovs-dev] [v4 09/12] dpdk: add additional CPU ISA detection > strings > > On Thu, Jun 17, 2021 at 09:57:51PM +0530, Kumar Amber wrote: > > From: Harry van Haaren <harry.van.haaren@intel.com> > > > > This commit enables OVS to at runtime check for more detailed > > AVX512 capabilities, specifically Byte and Word (BW) extensions, and > > Vector Bit Manipulation Instructions (VBMI). > > > > These instructions will be used in the CPU ISA optimized > > implementations of traffic profile aware miniflow extract. > > > > Signed-off-by: Harry van Haaren <harry.van.haaren@intel.com> > > --- > > Acked-by: Flavio Leitner <fbl@sysclose.org> > > fbl
On 17 Jun 2021, at 18:27, Kumar Amber wrote: > From: Harry van Haaren <harry.van.haaren@intel.com> > > This commit enables OVS to at runtime check for more detailed > AVX512 capabilities, specifically Byte and Word (BW) extensions, > and Vector Bit Manipulation Instructions (VBMI). > > These instructions will be used in the CPU ISA optimized > implementations of traffic profile aware miniflow extract. > > Signed-off-by: Harry van Haaren <harry.van.haaren@intel.com> Acked-by: Eelco Chaudron <echaudro@redhat.com> //Eelco
> From: Harry van Haaren <harry.van.haaren@intel.com> > > This commit enables OVS to at runtime check for more detailed > AVX512 capabilities, specifically Byte and Word (BW) extensions, > and Vector Bit Manipulation Instructions (VBMI). > > These instructions will be used in the CPU ISA optimized > implementations of traffic profile aware miniflow extract. > > Signed-off-by: Harry van Haaren <harry.van.haaren@intel.com> LGTM. Ian > --- > lib/dpdk.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/lib/dpdk.c b/lib/dpdk.c > index a9494a40f..9d13e4ab7 100644 > --- a/lib/dpdk.c > +++ b/lib/dpdk.c > @@ -655,6 +655,8 @@ dpdk_get_cpu_has_isa(const char *arch, const char > *feature) > #if __x86_64__ > /* CPU flags only defined for the architecture that support it. */ > CHECK_CPU_FEATURE(feature, "avx512f", RTE_CPUFLAG_AVX512F); > + CHECK_CPU_FEATURE(feature, "avx512bw", RTE_CPUFLAG_AVX512BW); > + CHECK_CPU_FEATURE(feature, "avx512vbmi", RTE_CPUFLAG_AVX512VBMI); > CHECK_CPU_FEATURE(feature, "avx512vpopcntdq", > RTE_CPUFLAG_AVX512VPOPCNTDQ); > CHECK_CPU_FEATURE(feature, "bmi2", RTE_CPUFLAG_BMI2); > #endif > -- > 2.25.1 > > _______________________________________________ > dev mailing list > dev@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev
diff --git a/lib/dpdk.c b/lib/dpdk.c index a9494a40f..9d13e4ab7 100644 --- a/lib/dpdk.c +++ b/lib/dpdk.c @@ -655,6 +655,8 @@ dpdk_get_cpu_has_isa(const char *arch, const char *feature) #if __x86_64__ /* CPU flags only defined for the architecture that support it. */ CHECK_CPU_FEATURE(feature, "avx512f", RTE_CPUFLAG_AVX512F); + CHECK_CPU_FEATURE(feature, "avx512bw", RTE_CPUFLAG_AVX512BW); + CHECK_CPU_FEATURE(feature, "avx512vbmi", RTE_CPUFLAG_AVX512VBMI); CHECK_CPU_FEATURE(feature, "avx512vpopcntdq", RTE_CPUFLAG_AVX512VPOPCNTDQ); CHECK_CPU_FEATURE(feature, "bmi2", RTE_CPUFLAG_BMI2); #endif