diff mbox series

[ovs-dev] doc: Add 'faq' about datapath-id

Message ID 20210201121532.2684-1-taoyunxiang@cmss.chinamobile.com
State Accepted
Headers show
Series [ovs-dev] doc: Add 'faq' about datapath-id | expand

Commit Message

Tao YunXiang Feb. 1, 2021, 12:15 p.m. UTC
This patch populate faq about datapath-id.

Author: Tao YunXiang <taoyunxiang@cmss.chinamobile.com>
Signed-off-by: Tao YunXiang <taoyunxiang@cmss.chinamobile.com>
---
 Documentation/faq/configuration.rst | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)

Comments

0-day Robot Feb. 1, 2021, 1:29 p.m. UTC | #1
Bleep bloop.  Greetings Tao YunXiang, I am a robot and I have tried out your patch.
Thanks for your contribution.

I encountered some error that I wasn't expecting.  See the details below.


checkpatch:
WARNING: Line has trailing whitespace
#23 FILE: Documentation/faq/configuration.rst:285:
Q: Why the datapath-id choose the minimum non-local MAC address among all of 

WARNING: Line has trailing whitespace
#29 FILE: Documentation/faq/configuration.rst:291:
    Here's the use case it was designed to address. It started with 

WARNING: Line has non-spaces leading whitespace
WARNING: Line has trailing whitespace
#36 FILE: Documentation/faq/configuration.rst:298:
    

WARNING: Line has trailing whitespace
#37 FILE: Documentation/faq/configuration.rst:299:
    If you want a stable MAC and datapath-id, you could set your own MAC 

WARNING: Line has non-spaces leading whitespace
WARNING: Line has trailing whitespace
#39 FILE: Documentation/faq/configuration.rst:301:
     

Lines checked: 45, Warnings: 7, Errors: 0


build:
reading sources... [ 87%] topics/language-bindings
reading sources... [ 88%] topics/networking-namespaces
reading sources... [ 89%] topics/openflow
reading sources... [ 90%] topics/ovs-extensions
reading sources... [ 91%] topics/ovsdb-replication
reading sources... [ 92%] topics/porting
reading sources... [ 93%] topics/testing
reading sources... [ 93%] topics/tracing
reading sources... [ 94%] topics/userspace-tso
reading sources... [ 95%] topics/windows
reading sources... [ 96%] tutorials/faucet
reading sources... [ 97%] tutorials/index
reading sources... [ 98%] tutorials/ipsec
reading sources... [ 99%] tutorials/ovs-advanced
reading sources... [100%] tutorials/ovs-conntrack

deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument 
 `handle_
 io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (
 2012-12-
 16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation wa
 rning: i
 o.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is
  ignored
  since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will
  soon be
  removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput()
  argumen
 t `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docut
 ils 0.10
  (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.
Warning, treated as error:
/var/lib/jenkins/jobs/0day_robot_upstream_build_from_pw/workspace/Documentation/faq/configuration.rst:304: WARNING: Literal block expected; none found.

make[2]: *** [docs-check] Error 1
make[2]: Leaving directory `/var/lib/jenkins/jobs/0day_robot_upstream_build_from_pw/workspace'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/var/lib/jenkins/jobs/0day_robot_upstream_build_from_pw/workspace'
make: *** [all] Error 2


Please check this out.  If you feel there has been an error, please email aconole@redhat.com

Thanks,
0-day Robot
Ben Pfaff Feb. 1, 2021, 9:37 p.m. UTC | #2
On Mon, Feb 01, 2021 at 08:15:32PM +0800, Tao YunXiang wrote:
> This patch populate faq about datapath-id.
> 
> Author: Tao YunXiang <taoyunxiang@cmss.chinamobile.com>

There's no "Author:" tag.  We use Git to track commit authorship.  I
deleted this.

> Signed-off-by: Tao YunXiang <taoyunxiang@cmss.chinamobile.com>

I edited the answer to be better suited for the FAQ and applied this to
master.  Thank you!
diff mbox series

Patch

diff --git a/Documentation/faq/configuration.rst b/Documentation/faq/configuration.rst
index 4a98740c5..fd5d2e005 100644
--- a/Documentation/faq/configuration.rst
+++ b/Documentation/faq/configuration.rst
@@ -281,3 +281,24 @@  the sense of OFPP_LOCAL)
 
     A: Open vSwitch does not support such a configuration.  Bridges always have
     their local ports.
+
+Q: Why the datapath-id choose the minimum non-local MAC address among all of 
+the ports in bridge?
+
+    A: The reason that this happens is to keep the MAC address of the bridge
+    steady.
+
+    Here's the use case it was designed to address. It started with 
+    XenServer, but other hypervisors work similarly. Each physical NIC that
+    might have VMs on it gets put into a bridge, and then the IP address for
+    that NIC (if any) gets migrated from the pnic to the bridge device. You
+    want the bridge device to have the same MAC address as the physical NIC,
+    so taking the minimum MAC address does that. Adding virtual NICs doesn't
+    change it because OVS ignores random MACs.
+    
+    If you want a stable MAC and datapath-id, you could set your own MAC 
+    by ``hwaddr`` in ``other_config`` of bridge.
+     
+    ::
+
+    ovs-vsctl set bridge br-int other_config:hwaddr=3a:4d:a7:05:2a:45