| Message ID | 20201218053144.2637583-6-blp@ovn.org |
|---|---|
| State | Accepted |
| Headers | show |
| Series | Refactor OVSDB IDL into two layers | expand |
On 12/18/20 6:31 AM, Ben Pfaff wrote: > Adding parameter names makes these prototypes clearer. > > Signed-off-by: Ben Pfaff <blp@ovn.org> > --- > lib/ovsdb-idl.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/lib/ovsdb-idl.h b/lib/ovsdb-idl.h > index 789337df9f33..05bb48d66c3f 100644 > --- a/lib/ovsdb-idl.h > +++ b/lib/ovsdb-idl.h > @@ -62,8 +62,8 @@ struct ovsdb_idl *ovsdb_idl_create(const char *remote, > bool retry); > struct ovsdb_idl *ovsdb_idl_create_unconnected( > const struct ovsdb_idl_class *, bool monitor_everything_by_default); > -void ovsdb_idl_set_remote(struct ovsdb_idl *, const char *, bool); > -void ovsdb_idl_set_shuffle_remotes(struct ovsdb_idl *, bool); > +void ovsdb_idl_set_remote(struct ovsdb_idl *, const char *remote, bool retry); > +void ovsdb_idl_set_shuffle_remotes(struct ovsdb_idl *, bool shuffle); > void ovsdb_idl_reset_min_index(struct ovsdb_idl *); > void ovsdb_idl_destroy(struct ovsdb_idl *); > > LGTM, Acked-by: Ilya Maximets <i.maximets@ovn.org>
diff --git a/lib/ovsdb-idl.h b/lib/ovsdb-idl.h index 789337df9f33..05bb48d66c3f 100644 --- a/lib/ovsdb-idl.h +++ b/lib/ovsdb-idl.h @@ -62,8 +62,8 @@ struct ovsdb_idl *ovsdb_idl_create(const char *remote, bool retry); struct ovsdb_idl *ovsdb_idl_create_unconnected( const struct ovsdb_idl_class *, bool monitor_everything_by_default); -void ovsdb_idl_set_remote(struct ovsdb_idl *, const char *, bool); -void ovsdb_idl_set_shuffle_remotes(struct ovsdb_idl *, bool); +void ovsdb_idl_set_remote(struct ovsdb_idl *, const char *remote, bool retry); +void ovsdb_idl_set_shuffle_remotes(struct ovsdb_idl *, bool shuffle); void ovsdb_idl_reset_min_index(struct ovsdb_idl *); void ovsdb_idl_destroy(struct ovsdb_idl *);
Adding parameter names makes these prototypes clearer. Signed-off-by: Ben Pfaff <blp@ovn.org> --- lib/ovsdb-idl.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)