Message ID | 20201027223003.166768-6-fdangelo@redhat.com |
---|---|
State | Changes Requested |
Headers | show |
Series | Incorporate fixes from lldpd upstream | expand |
Bleep bloop. Greetings Fabrizio D'Angelo, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Author Vincent Bernat <vincent@bernat.im> needs to sign off. Lines checked: 45, Warnings: 0, Errors: 1 Please check this out. If you feel there has been an error, please email aconole@redhat.com Thanks, 0-day Robot
Fabrizio D'Angelo <fdangelo@redhat.com> writes: > From: Vincent Bernat <vincent@bernat.im> > > Upstream commit: > commit 32f0deeebc9172c3f5f4a4d02aab32e6904947f6 > Date: Sat, 18 Feb 2017 20:11:47 +0100 > > lldpd: correctly increase discarded count > > When a frame cannot be decoded but has been guessed, increase the > discarded count. > > Fix https://github.com/vincentbernat/lldpd/issues/223 > > Co-authored-by: Fabrizio D'Angelo <fdangelo@redhat.com> > Signed-off-by: Fabrizio D'Angelo <fdangelo@redhat.com> > --- Acked-by: Aaron Conole <aconole@redhat.com>
diff --git a/lib/lldp/lldpd.c b/lib/lldp/lldpd.c index 19e9305266..34738535db 100644 --- a/lib/lldp/lldpd.c +++ b/lib/lldp/lldpd.c @@ -244,6 +244,7 @@ lldpd_decode(struct lldpd *cfg, char *frame, int s, if (s < sizeof(struct eth_header) + 4) { /* Too short, just discard it */ + hw->h_rx_discarded_cnt++; return; } @@ -284,6 +285,7 @@ lldpd_decode(struct lldpd *cfg, char *frame, int s, VLOG_DBG("function for %s protocol did not " "decode this frame", cfg->g_protocols[i].name); + hw->h_rx_discarded_cnt++; return; } chassis->c_protocol = port->p_protocol = cfg->g_protocols[i].mode;