diff mbox series

[ovs-dev,v2,4/6] lldp: increase statsTLVsUnrecognizedTotal on unknown TLV

Message ID 20201027223003.166768-5-fdangelo@redhat.com
State Changes Requested
Headers show
Series Incorporate fixes from lldpd upstream | expand

Commit Message

Fabrizio D'Angelo Oct. 27, 2020, 10:30 p.m. UTC 
From: Vincent Bernat <vincent@bernat.ch>

Upstream commit:
	commit 109bcd423cd560545ec7940d73a50c5584aebb0c
	Author: Vincent Bernat <vincent@bernat.ch>
	Date: Sat, 6 Apr 2019 21:17:25 +0200

	This was done for organization TLVs, but not for other TLVs.

	Fix https://github.com/vincentbernat/lldpd/issues/323

Signed-off-by: Fabrizio D'Angelo <fdangelo@redhat.com>
---
 lib/lldp/lldp.c | 1 +
 1 file changed, 1 insertion(+)

Comments

0-day Robot Oct. 27, 2020, 11:09 p.m. UTC | #1 
Bleep bloop.  Greetings Fabrizio D'Angelo, I am a robot and I have tried out your patch.
Thanks for your contribution.

I encountered some error that I wasn't expecting.  See the details below.


checkpatch:
ERROR: Author Vincent Bernat <vincent@bernat.ch> needs to sign off.
WARNING: Unexpected sign-offs from developers who are not authors or co-authors or committers: Fabrizio D'Angelo <fdangelo@redhat.com>
Lines checked: 34, Warnings: 1, Errors: 1


Please check this out.  If you feel there has been an error, please email aconole@redhat.com

Thanks,
0-day Robot
Aaron Conole Nov. 9, 2020, 4:46 p.m. UTC | #2 
Fabrizio D'Angelo <fdangelo@redhat.com> writes:

> From: Vincent Bernat <vincent@bernat.ch>
>
> Upstream commit:
> 	commit 109bcd423cd560545ec7940d73a50c5584aebb0c
> 	Author: Vincent Bernat <vincent@bernat.ch>
> 	Date: Sat, 6 Apr 2019 21:17:25 +0200
>
> 	This was done for organization TLVs, but not for other TLVs.
>
> 	Fix https://github.com/vincentbernat/lldpd/issues/323
>
> Signed-off-by: Fabrizio D'Angelo <fdangelo@redhat.com>
> ---

Acked-by: Aaron Conole <aconole@redhat.com>
diff mbox series

Patch

diff --git a/lib/lldp/lldp.c b/lib/lldp/lldp.c
index 172bccdc71..3314f18189 100644
--- a/lib/lldp/lldp.c
+++ b/lib/lldp/lldp.c
@@ -679,6 +679,7 @@  lldp_decode(struct lldpd *cfg OVS_UNUSED, char *frame, int s,
             VLOG_WARN("unknown tlv (%d) received on %s",
                       tlv_type,
                       hardware->h_ifname);
+            hardware->h_rx_unrecognized_cnt++;
             goto malformed;
         }
         if (pos > tlv + tlv_size) {