| Message ID | 20200930064400.142340-1-dingxiaoxiong@huawei.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [ovs-dev] ofproto-dpif-xlate: Stop forwarding MLD reports to group ports. | expand |
On Wed, Sep 30, 2020 at 02:44:00PM +0800, XiaoXiong Ding wrote: > According with rfc4541 section 2.1.1, a snooping switch > should forward membership reports only to ports with > routers attached.The current code violates the RFC > forwarding membership reports to group ports as well. > The same issue doesn't exist with IPv4. > > Fixes: 06994f879c ("mcast-snooping: Add Multicast Listener Discovery support") > Signed-off-by: XiaoXiong Ding <dingxiaoxiong@huawei.com> > --- Acked-by: Flavio Leitner <fbl@sysclose.org>
On 12/16/20 7:47 PM, Flavio Leitner wrote: > On Wed, Sep 30, 2020 at 02:44:00PM +0800, XiaoXiong Ding wrote: >> According with rfc4541 section 2.1.1, a snooping switch >> should forward membership reports only to ports with >> routers attached.The current code violates the RFC >> forwarding membership reports to group ports as well. >> The same issue doesn't exist with IPv4. >> >> Fixes: 06994f879c ("mcast-snooping: Add Multicast Listener Discovery support") >> Signed-off-by: XiaoXiong Ding <dingxiaoxiong@huawei.com> >> --- > > Acked-by: Flavio Leitner <fbl@sysclose.org> Thanks! Applied to master and backported down to 2.5. Best regards, Ilya Maximets.
diff --git a/ofproto/ofproto-dpif-xlate.c b/ofproto/ofproto-dpif-xlate.c index e0ede2cab..47571e790 100644 --- a/ofproto/ofproto-dpif-xlate.c +++ b/ofproto/ofproto-dpif-xlate.c @@ -3100,6 +3100,7 @@ xlate_normal(struct xlate_ctx *ctx) xlate_report(ctx, OFT_DETAIL, "MLD query, flooding"); xlate_normal_flood(ctx, in_xbundle, &xvlan); } + return; } else { if (is_ip_local_multicast(flow, wc)) { /* RFC4541: section 2.1.2, item 2: Packets with a dst IP
According with rfc4541 section 2.1.1, a snooping switch should forward membership reports only to ports with routers attached.The current code violates the RFC forwarding membership reports to group ports as well. The same issue doesn't exist with IPv4. Fixes: 06994f879c ("mcast-snooping: Add Multicast Listener Discovery support") Signed-off-by: XiaoXiong Ding <dingxiaoxiong@huawei.com> --- ofproto/ofproto-dpif-xlate.c | 1 + 1 file changed, 1 insertion(+)