From patchwork Tue Sep 29 20:07:31 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Flavio Leitner X-Patchwork-Id: 1373652 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org (client-ip=140.211.166.138; helo=whitealder.osuosl.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=AxWLqbMg; dkim-atps=neutral Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4C19RZ37psz9sPB for ; Wed, 30 Sep 2020 06:07:53 +1000 (AEST) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 1A6578685D; Tue, 29 Sep 2020 20:07:50 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id bi7kYZVW0mUM; Tue, 29 Sep 2020 20:07:47 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by whitealder.osuosl.org (Postfix) with ESMTP id A2D0785B71; Tue, 29 Sep 2020 20:07:47 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 3D2B8C0890; Tue, 29 Sep 2020 20:07:47 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@lists.linuxfoundation.org Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by lists.linuxfoundation.org (Postfix) with ESMTP id CEE92C016F for ; Tue, 29 Sep 2020 20:07:45 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id B7BC785E03 for ; Tue, 29 Sep 2020 20:07:45 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id q4DMsFnVvvZp for ; Tue, 29 Sep 2020 20:07:45 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by fraxinus.osuosl.org (Postfix) with ESMTPS id 28F9485CAA for ; Tue, 29 Sep 2020 20:07:45 +0000 (UTC) Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1601410063; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=L2abwzWIKmYG5THgJttVpqJQcMB64ZovE3xAanppSfw=; b=AxWLqbMgDfU0Wt3aKYLe9Kza1pO8OBnhPVT4aeSPikojImktKEtn3f6KapM18NIaEhFlqp T+q344JCx4VX8V9dfxKe22dlRVtiU/1aQDQgQ6d7RlaP03t/2X8ZRy7uZG5uQqiPwKxmts FrDuL9iZouKcMBjUHBrdq9UqlA+L4NU= Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-348-QbaRdreuO9SFUgCGQL50Nw-1; Tue, 29 Sep 2020 16:07:41 -0400 X-MC-Unique: QbaRdreuO9SFUgCGQL50Nw-1 Received: by mail-qk1-f197.google.com with SMTP id r184so3485652qka.21 for ; Tue, 29 Sep 2020 13:07:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=L2abwzWIKmYG5THgJttVpqJQcMB64ZovE3xAanppSfw=; b=DmJlLQN7yuPf0R8fMvrUQ5wLkCjEGbmFuJml/xey4gT5Vurc0iriTTUjBRErA9p1qq M5yqj6vGPL0fcwuWjZe4BwcvvFJrBhYnJG06z00bYrgQzMbZ3eavS/oQEB6qozb5edxF vxp5vGCaCxWZBTHV+V7l11B8SwHyHmPGKz1B8V8ll6VNywANo6Y9udwGxfRbAJwJ9yDv /VhVcJYTrd4vSoMPeRJdoo84r784jzF4Q3TcqmWpUQUvAE5hoWNgLJB+u2F2E1cyK7Dx QbzzECqNGgxi4l6KHq3myX+Bl7Qw29tEE/3Nrmi/xuKLS5mtmCEUv7dNaRO/AuW8eKDD pMZQ== X-Gm-Message-State: AOAM531JF8Fzk4+9hzpHhmenoibQDGwH5C2/l6An2SiHrqCOZ5L2sUgz KD34hOflIOdC0Q5zpt4YD+FyXtmGa9Dwfd6DLYK2jqI0UJN2T+zTCCKo0asQPKBDJC0fMj1ijfK C+ME2hTEm8c0W X-Received: by 2002:aed:3591:: with SMTP id c17mr4964806qte.96.1601410061031; Tue, 29 Sep 2020 13:07:41 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx1roM4mBaNPK5Hi3S1HOnG59fw7UQ1UA3A2K0OOJYg50PTP9cJk/9ulT+Tz6AvNVy7bSN+cA== X-Received: by 2002:aed:3591:: with SMTP id c17mr4964794qte.96.1601410060828; Tue, 29 Sep 2020 13:07:40 -0700 (PDT) Received: from localhost ([2804:146c:418:b100::ee1]) by smtp.gmail.com with ESMTPSA id q8sm6170696qkq.57.2020.09.29.13.07.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 29 Sep 2020 13:07:40 -0700 (PDT) From: Flavio Leitner To: dev@openvswitch.org Date: Tue, 29 Sep 2020 17:07:31 -0300 Message-Id: <20200929200731.541730-1-fbl@redhat.com> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=fbl@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Cc: Flavio Leitner Subject: [ovs-dev] [PATCH v2] ofproto-dpif-upcall: Log the value of flow limit. X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: ovs-dev-bounces@openvswitch.org Sender: "dev" The datapath flow limit is calculated by revalidators so log the value as well. Signed-off-by: Flavio Leitner Acked-by: Eelco Chaudron --- ofproto/ofproto-dpif-upcall.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) v2: Updated the log message. diff --git a/ofproto/ofproto-dpif-upcall.c b/ofproto/ofproto-dpif-upcall.c index 72a5b4d73..195b01c13 100644 --- a/ofproto/ofproto-dpif-upcall.c +++ b/ofproto/ofproto-dpif-upcall.c @@ -1283,7 +1283,9 @@ should_install_flow(struct udpif *udpif, struct upcall *upcall) atomic_read_relaxed(&udpif->flow_limit, &flow_limit); if (udpif_get_n_flows(udpif) >= flow_limit) { COVERAGE_INC(upcall_flow_limit_hit); - VLOG_WARN_RL(&rl, "upcall: datapath flow limit reached"); + VLOG_WARN_RL(&rl, + "upcall: datapath reached the dynamic limit of %u flows.", + flow_limit); return false; }