| Message ID | 20200929200731.541730-1-fbl@redhat.com |
|---|---|
| State | Accepted |
| Commit | cade1c4642064f472b9c9796fc4194fbe13a3789 |
| Headers | show |
| Series | [ovs-dev,v2] ofproto-dpif-upcall: Log the value of flow limit. | expand |
On 29 Sep 2020, at 22:07, Flavio Leitner wrote: > The datapath flow limit is calculated by revalidators so > log the value as well. > > Signed-off-by: Flavio Leitner <fbl@redhat.com> Acked-by: Eelco Chaudron <echaudro@redhat.com>
On 9/30/20 8:46 AM, Eelco Chaudron wrote: > > > On 29 Sep 2020, at 22:07, Flavio Leitner wrote: > >> The datapath flow limit is calculated by revalidators so >> log the value as well. >> >> Signed-off-by: Flavio Leitner <fbl@redhat.com> > > Acked-by: Eelco Chaudron <echaudro@redhat.com> Thanks, Flavio and Eelco! Applied to master. Best regards, Ilya Maximets.
diff --git a/ofproto/ofproto-dpif-upcall.c b/ofproto/ofproto-dpif-upcall.c index 72a5b4d73..195b01c13 100644 --- a/ofproto/ofproto-dpif-upcall.c +++ b/ofproto/ofproto-dpif-upcall.c @@ -1283,7 +1283,9 @@ should_install_flow(struct udpif *udpif, struct upcall *upcall) atomic_read_relaxed(&udpif->flow_limit, &flow_limit); if (udpif_get_n_flows(udpif) >= flow_limit) { COVERAGE_INC(upcall_flow_limit_hit); - VLOG_WARN_RL(&rl, "upcall: datapath flow limit reached"); + VLOG_WARN_RL(&rl, + "upcall: datapath reached the dynamic limit of %u flows.", + flow_limit); return false; }
The datapath flow limit is calculated by revalidators so log the value as well. Signed-off-by: Flavio Leitner <fbl@redhat.com> --- ofproto/ofproto-dpif-upcall.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) v2: Updated the log message.