From patchwork Sun Sep 6 07:45:50 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kaixi Fan X-Patchwork-Id: 1358257 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org (client-ip=140.211.166.137; helo=fraxinus.osuosl.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=bytedance.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=bytedance-com.20150623.gappssmtp.com header.i=@bytedance-com.20150623.gappssmtp.com header.a=rsa-sha256 header.s=20150623 header.b=JC5S4sIZ; dkim-atps=neutral Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4Bkk4H6J6Vz9sTX for ; Sun, 6 Sep 2020 17:46:07 +1000 (AEST) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id 272C585F66; Sun, 6 Sep 2020 07:46:05 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 2TRtBUfVlfzR; Sun, 6 Sep 2020 07:46:03 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by fraxinus.osuosl.org (Postfix) with ESMTP id 5302785F3A; Sun, 6 Sep 2020 07:46:03 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 3941EC0859; Sun, 6 Sep 2020 07:46:03 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@lists.linuxfoundation.org Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by lists.linuxfoundation.org (Postfix) with ESMTP id 4FDF7C0051 for ; Sun, 6 Sep 2020 07:46:01 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 4173987370 for ; Sun, 6 Sep 2020 07:46:01 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 6+ABpxGM-J0s for ; Sun, 6 Sep 2020 07:45:59 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from mail-pj1-f66.google.com (mail-pj1-f66.google.com [209.85.216.66]) by hemlock.osuosl.org (Postfix) with ESMTPS id 530EE8736E for ; Sun, 6 Sep 2020 07:45:59 +0000 (UTC) Received: by mail-pj1-f66.google.com with SMTP id gf14so4965784pjb.5 for ; Sun, 06 Sep 2020 00:45:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=snUIgDNmT92uqdlRJvReVTz2vOm2sMCJ1XvZo2LpD4k=; b=JC5S4sIZUogw/v+ORC65CGBWOmZ7XBvIZ5/14vVpajexfXIHXK/XYeQwMajwaX5FRJ A31g5Mw8TAJFrCUb8jbhJewMwfQXNMK5OJZrTGXz6lUbF8A9XaZmsGjn89irZrs3f+tM wt0cIPWsDGGFd40LxrTk7kzQBRaaDF1f8id6X0O0K1fUL6pkUlunU5pWgpBpRIFsNTTd snAuE7mDQ5yZYPjzkI/plm/yMsn9onikzo3UnNbgO8P8MJ/GqqG6R2TDoCFgNWBgf9lA v3hmiS8DNGSAgmhLQYcgqc9MCyGoDI3rZNpykyqxxL/7zdFc2mG256FtxRsN5eHrM/by oH2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=snUIgDNmT92uqdlRJvReVTz2vOm2sMCJ1XvZo2LpD4k=; b=WKdguwqABw0yUg+QDFvtj+hzUgDKA0vOOqxWsFs9RRUgB3nmkkzmcryPLhlrjt8soe xKoUp/4jIzmE0bKp+q9sbZ+VR3QGaS9FggyvfMMSav0337wI58jyEQiNTsDKWM8VmQ9z vIOyH+uGDTSAaz2z12Yr+1YTefU2MxsXqphF6m7Pc8Zir5FSQSAsNVHsyDS97Kcr5KlW q05cDHN7zVKo27/DnwOa8BasjJtIJAmfod+s8NCU0HGi1Ozkn+e0hosUVY0glz7s3YF2 6Yg6CVcjmSssgp0xazpnmaiKtvZ5Q7x3565jDAA64EIWpAp2+Rclg1435scNpFzBY6am aELw== X-Gm-Message-State: AOAM531YkrhtkFPb9UkJDcCbTBEDi+vtF5SNBxcJd28NFSqOEM7/KqnB SfKiXWtmBL3KWL2JIzIe3Xu8KhDrDprgwVBs X-Google-Smtp-Source: ABdhPJyJtYdwMOCVoToMxjX5v0iiFxCcINksiZ4XgtWwhjWrkF5ZpzkS5RLXI95wYyJLM0aiKfJqQg== X-Received: by 2002:a17:90b:245:: with SMTP id fz5mr14935162pjb.131.1599378358510; Sun, 06 Sep 2020 00:45:58 -0700 (PDT) Received: from MacBook-Pro-3.local.net ([103.136.220.68]) by smtp.gmail.com with ESMTPSA id 19sm9299987pjk.28.2020.09.06.00.45.56 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 06 Sep 2020 00:45:58 -0700 (PDT) From: fankaixi.li@bytedance.com To: dev@openvswitch.org Date: Sun, 6 Sep 2020 15:45:50 +0800 Message-Id: <20200906074550.52743-1-fankaixi.li@bytedance.com> X-Mailer: git-send-email 2.24.3 (Apple Git-128) MIME-Version: 1.0 Subject: [ovs-dev] [PATCH] ofproto-dpif: remove checking setting nd_ext field X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: ovs-dev-bounces@openvswitch.org Sender: "dev" From: "fankaixi.li" In order to support openflow rule which setting nd_ext fields in openflow tables, we should remove setting nd_ext fields when constructing rule. The ofproto would translate it into userspace actions when handling upcalls. Signed-off-by: fankaixi.li --- ofproto/ofproto-dpif.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c index 4f0638f23..f4c37f43d 100644 --- a/ofproto/ofproto-dpif.c +++ b/ofproto/ofproto-dpif.c @@ -4637,14 +4637,6 @@ check_actions(const struct ofproto_dpif *ofproto, "ct original direction tuple"); return OFPERR_NXBAC_CT_DATAPATH_SUPPORT; } - } else if (!support->nd_ext && ofpact->type == OFPACT_SET_FIELD) { - const struct mf_field *dst = ofpact_get_mf_dst(ofpact); - - if (dst->id == MFF_ND_RESERVED || dst->id == MFF_ND_OPTIONS_TYPE) { - report_unsupported_act("set field", - "setting IPv6 ND Extensions fields"); - return OFPERR_OFPBAC_BAD_SET_ARGUMENT; - } } }