| Message ID | 20200527110402.40192-1-lmartins@redhat.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [ovs-dev,ovn] northd: Add the new chassis's "other_config" column to RBAC | expand |
On 5/27/20 1:04 PM, lmartins@redhat.com wrote: > From: Lucas Alvares Gomes <lucasagomes@gmail.com> > > This patch is fixing a left-over from commit > 74d90c2223d0a8c123823fb849b4c2de58c296e4, we need to add the new > "other_config" column from the Chassis table to the rbac_chassis_update > list for northd. > > Co-Authored-by: Numan Siddique <numans@ovn.org> > Signed-off-by: Numan Siddique <numans@ovn.org> > Signed-off-by: Lucas Alvares Gomes <lucasagomes@gmail.com> > --- > northd/ovn-northd.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/northd/ovn-northd.c b/northd/ovn-northd.c > index 8e58e5ba2..f445ab869 100644 > --- a/northd/ovn-northd.c > +++ b/northd/ovn-northd.c > @@ -11405,7 +11405,8 @@ check_and_add_supported_dhcpv6_opts_to_sb_db(struct northd_context *ctx) > static const char *rbac_chassis_auth[] = > {"name"}; > static const char *rbac_chassis_update[] = > - {"nb_cfg", "external_ids", "encaps", "vtep_logical_switches"}; > + {"nb_cfg", "external_ids", "encaps", "vtep_logical_switches", > + "other_config"}; > > static const char *rbac_encap_auth[] = > {"chassis_name"}; > Looks good to me, thanks! Acked-by: Dumitru Ceara <dceara@redhat.com>
On Wed, May 27, 2020 at 4:59 PM Dumitru Ceara <dceara@redhat.com> wrote: > On 5/27/20 1:04 PM, lmartins@redhat.com wrote: > > From: Lucas Alvares Gomes <lucasagomes@gmail.com> > > > > This patch is fixing a left-over from commit > > 74d90c2223d0a8c123823fb849b4c2de58c296e4, we need to add the new > > "other_config" column from the Chassis table to the rbac_chassis_update > > list for northd. > > > > Co-Authored-by: Numan Siddique <numans@ovn.org> > > Signed-off-by: Numan Siddique <numans@ovn.org> > > Signed-off-by: Lucas Alvares Gomes <lucasagomes@gmail.com> > > --- > > northd/ovn-northd.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/northd/ovn-northd.c b/northd/ovn-northd.c > > index 8e58e5ba2..f445ab869 100644 > > --- a/northd/ovn-northd.c > > +++ b/northd/ovn-northd.c > > @@ -11405,7 +11405,8 @@ > check_and_add_supported_dhcpv6_opts_to_sb_db(struct northd_context *ctx) > > static const char *rbac_chassis_auth[] = > > {"name"}; > > static const char *rbac_chassis_update[] = > > - {"nb_cfg", "external_ids", "encaps", "vtep_logical_switches"}; > > + {"nb_cfg", "external_ids", "encaps", "vtep_logical_switches", > > + "other_config"}; > > > > static const char *rbac_encap_auth[] = > > {"chassis_name"}; > > > > Looks good to me, thanks! > > Acked-by: Dumitru Ceara <dceara@redhat.com> > Thanks Lucas and Dumitru. I applied this patch to master. I just added the below Fixes tag in the commit message Fixes: 74d90c2223d0("ovn-controller to no longer monitor Chassis' external_ids") Thanks Numan > > _______________________________________________ > dev mailing list > dev@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev > >
diff --git a/northd/ovn-northd.c b/northd/ovn-northd.c index 8e58e5ba2..f445ab869 100644 --- a/northd/ovn-northd.c +++ b/northd/ovn-northd.c @@ -11405,7 +11405,8 @@ check_and_add_supported_dhcpv6_opts_to_sb_db(struct northd_context *ctx) static const char *rbac_chassis_auth[] = {"name"}; static const char *rbac_chassis_update[] = - {"nb_cfg", "external_ids", "encaps", "vtep_logical_switches"}; + {"nb_cfg", "external_ids", "encaps", "vtep_logical_switches", + "other_config"}; static const char *rbac_encap_auth[] = {"chassis_name"};