| Message ID | 20200428120836.15354-4-david.marchand@redhat.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [ovs-dev,dpdk-latest,v2,1/4] travis: Remove explicit DPDK kmods configuration. | expand |
On 4/28/2020 1:08 PM, David Marchand wrote: > Add Travis jobs to check compilation with DPDK experimental API enabled. > This will help us catch issues for the day we need one of them. > Am I right in thinking this is specific to dpdk-latest and wont be applied to master? If that's the case then I can add that as a note in the commit message (similar to what we had for making travis track DPDK master). Regards Ian > Signed-off-by: David Marchand <david.marchand@redhat.com> > --- > .travis.yml | 4 ++++ > .travis/linux-build.sh | 3 +++ > 2 files changed, 7 insertions(+) > > diff --git a/.travis.yml b/.travis.yml > index 9c5c9c5c02..97249c1ce8 100644 > --- a/.travis.yml > +++ b/.travis.yml > @@ -44,6 +44,7 @@ env: > - KERNEL_LIST="4.15 4.14 4.9 4.4 3.19 3.16" > - AFXDP=1 KERNEL=5.3 > - M32=1 OPTS="--disable-ssl" > + - DPDK=1 DPDK_EXPERIMENTAL=1 > - DPDK=1 OPTS="--enable-shared" > - DPDK_SHARED=1 > - DPDK_SHARED=1 OPTS="--enable-shared" > @@ -56,6 +57,9 @@ matrix: > - arch: arm64 > compiler: gcc > env: TESTSUITE=1 DPDK=1 > + - arch: arm64 > + compiler: gcc > + env: DPDK=1 DPDK_EXPERIMENTAL=1 > - arch: arm64 > compiler: gcc > env: KERNEL_LIST="5.5 4.19" > diff --git a/.travis/linux-build.sh b/.travis/linux-build.sh > index 0628db6872..33b359a61f 100755 > --- a/.travis/linux-build.sh > +++ b/.travis/linux-build.sh > @@ -173,6 +173,9 @@ if [ "$DPDK" ] || [ "$DPDK_SHARED" ]; then > # Disregard cast alignment errors until DPDK is fixed > CFLAGS_FOR_OVS="${CFLAGS_FOR_OVS} -Wno-cast-align" > fi > + if [ -n "$DPDK_EXPERIMENTAL" ]; then > + CFLAGS_FOR_OVS="${CFLAGS_FOR_OVS} -DALLOW_EXPERIMENTAL_API" > + fi > fi > > if [ "$CC" = "clang" ]; then >
On 5/5/20 3:12 PM, Stokes, Ian wrote: > > > On 4/28/2020 1:08 PM, David Marchand wrote: >> Add Travis jobs to check compilation with DPDK experimental API enabled. >> This will help us catch issues for the day we need one of them. >> > > Am I right in thinking this is specific to dpdk-latest and wont be applied to master? Yes. > > If that's the case then I can add that as a note in the commit message (similar to what we had for making travis track DPDK master). > Note would be nice to have. > Regards > Ian >> Signed-off-by: David Marchand <david.marchand@redhat.com> >> --- >> .travis.yml | 4 ++++ >> .travis/linux-build.sh | 3 +++ >> 2 files changed, 7 insertions(+) >> >> diff --git a/.travis.yml b/.travis.yml >> index 9c5c9c5c02..97249c1ce8 100644 >> --- a/.travis.yml >> +++ b/.travis.yml >> @@ -44,6 +44,7 @@ env: >> - KERNEL_LIST="4.15 4.14 4.9 4.4 3.19 3.16" >> - AFXDP=1 KERNEL=5.3 >> - M32=1 OPTS="--disable-ssl" >> + - DPDK=1 DPDK_EXPERIMENTAL=1 >> - DPDK=1 OPTS="--enable-shared" >> - DPDK_SHARED=1 >> - DPDK_SHARED=1 OPTS="--enable-shared" >> @@ -56,6 +57,9 @@ matrix: >> - arch: arm64 >> compiler: gcc >> env: TESTSUITE=1 DPDK=1 >> + - arch: arm64 >> + compiler: gcc >> + env: DPDK=1 DPDK_EXPERIMENTAL=1 >> - arch: arm64 >> compiler: gcc >> env: KERNEL_LIST="5.5 4.19" >> diff --git a/.travis/linux-build.sh b/.travis/linux-build.sh >> index 0628db6872..33b359a61f 100755 >> --- a/.travis/linux-build.sh >> +++ b/.travis/linux-build.sh >> @@ -173,6 +173,9 @@ if [ "$DPDK" ] || [ "$DPDK_SHARED" ]; then >> # Disregard cast alignment errors until DPDK is fixed >> CFLAGS_FOR_OVS="${CFLAGS_FOR_OVS} -Wno-cast-align" >> fi >> + if [ -n "$DPDK_EXPERIMENTAL" ]; then >> + CFLAGS_FOR_OVS="${CFLAGS_FOR_OVS} -DALLOW_EXPERIMENTAL_API" >> + fi >> fi >> if [ "$CC" = "clang" ]; then >>
On Tue, May 5, 2020 at 3:26 PM Ilya Maximets <i.maximets@ovn.org> wrote: > > On 5/5/20 3:12 PM, Stokes, Ian wrote: > > > > > > On 4/28/2020 1:08 PM, David Marchand wrote: > >> Add Travis jobs to check compilation with DPDK experimental API enabled. > >> This will help us catch issues for the day we need one of them. > >> > > > > Am I right in thinking this is specific to dpdk-latest and wont be applied to master? > > Yes. > > > > > If that's the case then I can add that as a note in the commit message (similar to what we had for making travis track DPDK master). > > > > Note would be nice to have. Ah yes, I need to put a reminder to always flag such changes in the commitlog.
diff --git a/.travis.yml b/.travis.yml index 9c5c9c5c02..97249c1ce8 100644 --- a/.travis.yml +++ b/.travis.yml @@ -44,6 +44,7 @@ env: - KERNEL_LIST="4.15 4.14 4.9 4.4 3.19 3.16" - AFXDP=1 KERNEL=5.3 - M32=1 OPTS="--disable-ssl" + - DPDK=1 DPDK_EXPERIMENTAL=1 - DPDK=1 OPTS="--enable-shared" - DPDK_SHARED=1 - DPDK_SHARED=1 OPTS="--enable-shared" @@ -56,6 +57,9 @@ matrix: - arch: arm64 compiler: gcc env: TESTSUITE=1 DPDK=1 + - arch: arm64 + compiler: gcc + env: DPDK=1 DPDK_EXPERIMENTAL=1 - arch: arm64 compiler: gcc env: KERNEL_LIST="5.5 4.19" diff --git a/.travis/linux-build.sh b/.travis/linux-build.sh index 0628db6872..33b359a61f 100755 --- a/.travis/linux-build.sh +++ b/.travis/linux-build.sh @@ -173,6 +173,9 @@ if [ "$DPDK" ] || [ "$DPDK_SHARED" ]; then # Disregard cast alignment errors until DPDK is fixed CFLAGS_FOR_OVS="${CFLAGS_FOR_OVS} -Wno-cast-align" fi + if [ -n "$DPDK_EXPERIMENTAL" ]; then + CFLAGS_FOR_OVS="${CFLAGS_FOR_OVS} -DALLOW_EXPERIMENTAL_API" + fi fi if [ "$CC" = "clang" ]; then
Add Travis jobs to check compilation with DPDK experimental API enabled. This will help us catch issues for the day we need one of them. Signed-off-by: David Marchand <david.marchand@redhat.com> --- .travis.yml | 4 ++++ .travis/linux-build.sh | 3 +++ 2 files changed, 7 insertions(+)