diff mbox series

[ovs-dev,ovn] system tests: Fix occasional failure of the test - "Load balancer health checks".

Message ID 20200228163943.838867-1-numans@ovn.org
State Accepted
Headers show
Series [ovs-dev,ovn] system tests: Fix occasional failure of the test - "Load balancer health checks". | expand

Commit Message

Numan Siddique Feb. 28, 2020, 4:39 p.m. UTC 
From: Numan Siddique <numans@ovn.org>

Due to some timing issues, ovn-controller logs the warning message -
"handle service check: Service monitor not found". This can happen
if the service monitor is created in SB DB before the port for
the service is bound. This patch adds this warning message to the
WHITELIST of OVS_TRAFFIC_VSWITCHD_STOP.

Signed-off-by: Numan Siddique <numans@ovn.org>
---
 tests/system-ovn.at | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Dumitru Ceara March 4, 2020, 1:04 p.m. UTC | #1 
On 2/28/20 5:39 PM, numans@ovn.org wrote:
> From: Numan Siddique <numans@ovn.org>
> 
> Due to some timing issues, ovn-controller logs the warning message -
> "handle service check: Service monitor not found". This can happen
> if the service monitor is created in SB DB before the port for
> the service is bound. This patch adds this warning message to the
> WHITELIST of OVS_TRAFFIC_VSWITCHD_STOP.
> 
> Signed-off-by: Numan Siddique <numans@ovn.org>

Hi Numan,

Looks good to me.

Acked-by: Dumitru Ceara <dceara@redhat.com>

Thanks,
Dumitru

> ---
>  tests/system-ovn.at | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/system-ovn.at b/tests/system-ovn.at
> index 53da910cb..9ed3df754 100644
> --- a/tests/system-ovn.at
> +++ b/tests/system-ovn.at
> @@ -3462,7 +3462,8 @@ OVS_APP_EXIT_AND_WAIT([ovn-northd])
>  
>  as
>  OVS_TRAFFIC_VSWITCHD_STOP(["/failed to query port patch-.*/d
> -/connection dropped.*/d"])
> +/connection dropped.*/d
> +/Service monitor not found.*/d"])
>  
>  AT_CLEANUP
>  
>
Numan Siddique March 5, 2020, 6 a.m. UTC | #2 
On Wed, Mar 4, 2020 at 6:35 PM Dumitru Ceara <dceara@redhat.com> wrote:
>
> On 2/28/20 5:39 PM, numans@ovn.org wrote:
> > From: Numan Siddique <numans@ovn.org>
> >
> > Due to some timing issues, ovn-controller logs the warning message -
> > "handle service check: Service monitor not found". This can happen
> > if the service monitor is created in SB DB before the port for
> > the service is bound. This patch adds this warning message to the
> > WHITELIST of OVS_TRAFFIC_VSWITCHD_STOP.
> >
> > Signed-off-by: Numan Siddique <numans@ovn.org>
>
> Hi Numan,
>
> Looks good to me.
>
> Acked-by: Dumitru Ceara <dceara@redhat.com>

Thanks for the review.
I applied this patch to master and branch-20.03.

Thanks
Numan

>
> Thanks,
> Dumitru
>
> > ---
> >  tests/system-ovn.at | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/tests/system-ovn.at b/tests/system-ovn.at
> > index 53da910cb..9ed3df754 100644
> > --- a/tests/system-ovn.at
> > +++ b/tests/system-ovn.at
> > @@ -3462,7 +3462,8 @@ OVS_APP_EXIT_AND_WAIT([ovn-northd])
> >
> >  as
> >  OVS_TRAFFIC_VSWITCHD_STOP(["/failed to query port patch-.*/d
> > -/connection dropped.*/d"])
> > +/connection dropped.*/d
> > +/Service monitor not found.*/d"])
> >
> >  AT_CLEANUP
> >
> >
>
> _______________________________________________
> dev mailing list
> dev@openvswitch.org
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
>
diff mbox series

Patch

diff --git a/tests/system-ovn.at b/tests/system-ovn.at
index 53da910cb..9ed3df754 100644
--- a/tests/system-ovn.at
+++ b/tests/system-ovn.at
@@ -3462,7 +3462,8 @@  OVS_APP_EXIT_AND_WAIT([ovn-northd])
 
 as
 OVS_TRAFFIC_VSWITCHD_STOP(["/failed to query port patch-.*/d
-/connection dropped.*/d"])
+/connection dropped.*/d
+/Service monitor not found.*/d"])
 
 AT_CLEANUP