Message ID | 2019112615572930099726@cmss.chinamobile.com |
---|---|
State | Superseded |
Headers | show |
Series | Add a way to delete QoS directly | expand |
Hi, Could you review this patch。It is an important QoS feature for plugin of OVN. Thanks, Yun From: taoyunxiang@cmss.chinamobile.com Date: 2019-11-26 15:57 To: ovs-dev Subject: [ovs-dev,ovn,1/2] ovn-nbctl.c: Add "name" column of QoS table. Add "name" column of QoS table Add "name" column of QoS table and make qos could be list by command "ovn-nbctl list qos "name"". Signed-off-by: Yunxiang Tao <taoyunxiang@cmss.chinamobile.com> diff --git a/ovn-nb.ovsschema b/ovn-nb.ovsschema index 12999a466..02ae48e73 100644 --- a/ovn-nb.ovsschema +++ b/ovn-nb.ovsschema @@ -1,7 +1,7 @@ { "name": "OVN_Northbound", "version": "5.18.0", - "cksum": "2806349485 24196", + "cksum": "80177565 24240", "tables": { "NB_Global": { "columns": { @@ -204,6 +204,7 @@ "isRoot": false}, "QoS": { "columns": { + "name": {"type": "string"}, "priority": {"type": {"key": {"type": "integer", "minInteger": 0, "maxInteger": 32767}}}, diff --git a/ovn-nb.xml b/ovn-nb.xml index 4a93d2f4a..61e77397e 100644 --- a/ovn-nb.xml +++ b/ovn-nb.xml @@ -1662,6 +1662,12 @@ </p> </column> + <column name="name"> + <p> + A name for the logical router. + </p> + </column> + <column name="direction"> <p> The value of this field is similar to <ref colun="direction" diff --git a/utilities/ovn-nbctl.c b/utilities/ovn-nbctl.c index 8188948fa..93e37d169 100644 --- a/utilities/ovn-nbctl.c +++ b/utilities/ovn-nbctl.c @@ -5346,6 +5346,8 @@ static const struct ctl_table_class tables[NBREC_N_TABLES] = { [NBREC_TABLE_HA_CHASSIS_GROUP].row_ids[0] = {&nbrec_ha_chassis_group_col_name, NULL, NULL}, + + [NBREC_TABLE_QOS].row_ids[0] = {&nbrec_qos_col_name, NULL, NULL}, }; static char * taoyunxiang@cmss.chinamobile.com
On Fri, Dec 20, 2019 at 1:39 PM taoyunxiang@cmss.chinamobile.com <taoyunxiang@cmss.chinamobile.com> wrote: > > Hi, Could you review this patch。It is an important QoS feature for plugin of OVN. Hi Taoyunxiang, I am sorry for the delay. Looks like I missed these patches. The patch doesn't apply to the present master. Can you please rebase the series and submit v2 ? Thanks Numan > > Thanks, > Yun > > > > > From: taoyunxiang@cmss.chinamobile.com > Date: 2019-11-26 15:57 > To: ovs-dev > Subject: [ovs-dev,ovn,1/2] ovn-nbctl.c: Add "name" column of QoS table. > Add "name" column of QoS table > > Add "name" column of QoS table and make qos could be list > by command "ovn-nbctl list qos "name"". > > Signed-off-by: Yunxiang Tao <taoyunxiang@cmss.chinamobile.com> > > diff --git a/ovn-nb.ovsschema b/ovn-nb.ovsschema > index 12999a466..02ae48e73 100644 > --- a/ovn-nb.ovsschema > +++ b/ovn-nb.ovsschema > @@ -1,7 +1,7 @@ > { > "name": "OVN_Northbound", > "version": "5.18.0", > - "cksum": "2806349485 24196", > + "cksum": "80177565 24240", > "tables": { > "NB_Global": { > "columns": { > @@ -204,6 +204,7 @@ > "isRoot": false}, > "QoS": { > "columns": { > + "name": {"type": "string"}, > "priority": {"type": {"key": {"type": "integer", > "minInteger": 0, > "maxInteger": 32767}}}, > diff --git a/ovn-nb.xml b/ovn-nb.xml > index 4a93d2f4a..61e77397e 100644 > --- a/ovn-nb.xml > +++ b/ovn-nb.xml > @@ -1662,6 +1662,12 @@ > </p> > </column> > > + <column name="name"> > + <p> > + A name for the logical router. > + </p> > + </column> > + > <column name="direction"> > <p> > The value of this field is similar to <ref colun="direction" > diff --git a/utilities/ovn-nbctl.c b/utilities/ovn-nbctl.c > index 8188948fa..93e37d169 100644 > --- a/utilities/ovn-nbctl.c > +++ b/utilities/ovn-nbctl.c > @@ -5346,6 +5346,8 @@ static const struct ctl_table_class tables[NBREC_N_TABLES] = { > > [NBREC_TABLE_HA_CHASSIS_GROUP].row_ids[0] > = {&nbrec_ha_chassis_group_col_name, NULL, NULL}, > + > + [NBREC_TABLE_QOS].row_ids[0] = {&nbrec_qos_col_name, NULL, NULL}, > }; > > static char * > > > > taoyunxiang@cmss.chinamobile.com > _______________________________________________ > dev mailing list > dev@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Hi,Numan, I have submit v2 patchs. Please check it. Thanks, Yun taoyunxiang@cmss.chinamobile.com From: Numan Siddique Date: 2019-12-20 21:53 To: taoyunxiang@cmss.chinamobile.com CC: ovs-dev Subject: Re: [ovs-dev] [ovs-dev, ovn, 1/2] ovn-nbctl.c: Add "name" column of QoS table. On Fri, Dec 20, 2019 at 1:39 PM taoyunxiang@cmss.chinamobile.com <taoyunxiang@cmss.chinamobile.com> wrote: > > Hi, Could you review this patch。It is an important QoS feature for plugin of OVN. Hi Taoyunxiang, I am sorry for the delay. Looks like I missed these patches. The patch doesn't apply to the present master. Can you please rebase the series and submit v2 ? Thanks Numan > > Thanks, > Yun > > > > > From: taoyunxiang@cmss.chinamobile.com > Date: 2019-11-26 15:57 > To: ovs-dev > Subject: [ovs-dev,ovn,1/2] ovn-nbctl.c: Add "name" column of QoS table. > Add "name" column of QoS table > > Add "name" column of QoS table and make qos could be list > by command "ovn-nbctl list qos "name"". > > Signed-off-by: Yunxiang Tao <taoyunxiang@cmss.chinamobile.com> > > diff --git a/ovn-nb.ovsschema b/ovn-nb.ovsschema > index 12999a466..02ae48e73 100644 > --- a/ovn-nb.ovsschema > +++ b/ovn-nb.ovsschema > @@ -1,7 +1,7 @@ > { > "name": "OVN_Northbound", > "version": "5.18.0", > - "cksum": "2806349485 24196", > + "cksum": "80177565 24240", > "tables": { > "NB_Global": { > "columns": { > @@ -204,6 +204,7 @@ > "isRoot": false}, > "QoS": { > "columns": { > + "name": {"type": "string"}, > "priority": {"type": {"key": {"type": "integer", > "minInteger": 0, > "maxInteger": 32767}}}, > diff --git a/ovn-nb.xml b/ovn-nb.xml > index 4a93d2f4a..61e77397e 100644 > --- a/ovn-nb.xml > +++ b/ovn-nb.xml > @@ -1662,6 +1662,12 @@ > </p> > </column> > > + <column name="name"> > + <p> > + A name for the logical router. > + </p> > + </column> > + > <column name="direction"> > <p> > The value of this field is similar to <ref colun="direction" > diff --git a/utilities/ovn-nbctl.c b/utilities/ovn-nbctl.c > index 8188948fa..93e37d169 100644 > --- a/utilities/ovn-nbctl.c > +++ b/utilities/ovn-nbctl.c > @@ -5346,6 +5346,8 @@ static const struct ctl_table_class tables[NBREC_N_TABLES] = { > > [NBREC_TABLE_HA_CHASSIS_GROUP].row_ids[0] > = {&nbrec_ha_chassis_group_col_name, NULL, NULL}, > + > + [NBREC_TABLE_QOS].row_ids[0] = {&nbrec_qos_col_name, NULL, NULL}, > }; > > static char * > > > > taoyunxiang@cmss.chinamobile.com > _______________________________________________ > dev mailing list > dev@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Hi,Numan, I am sorry that I missed to fix checksum of ovsschema. I have summit v3 instead of v2 to correct it . Thanks, Yun ****************************************************** 陶云祥 中移(苏州)软件技术有限公司 中国移动苏州研发中心 苏州市高新区科技城昆仑山路58号中移软件园 手机:18896725011 邮编:215153 From: taoyunxiang@cmss.chinamobile.com Date: 2019-12-23 09:38 To: numans CC: ovs-dev Subject: Re: Re: [ovs-dev] [ovs-dev, ovn, 1/2] ovn-nbctl.c: Add "name" column of QoS table. Hi,Numan, I have submit v2 patchs. Please check it. Thanks, Yun taoyunxiang@cmss.chinamobile.com From: Numan Siddique Date: 2019-12-20 21:53 To: taoyunxiang@cmss.chinamobile.com CC: ovs-dev Subject: Re: [ovs-dev] [ovs-dev, ovn, 1/2] ovn-nbctl.c: Add "name" column of QoS table. On Fri, Dec 20, 2019 at 1:39 PM taoyunxiang@cmss.chinamobile.com <taoyunxiang@cmss.chinamobile.com> wrote: > > Hi, Could you review this patch。It is an important QoS feature for plugin of OVN. Hi Taoyunxiang, I am sorry for the delay. Looks like I missed these patches. The patch doesn't apply to the present master. Can you please rebase the series and submit v2 ? Thanks Numan > > Thanks, > Yun > > > > > From: taoyunxiang@cmss.chinamobile.com > Date: 2019-11-26 15:57 > To: ovs-dev > Subject: [ovs-dev,ovn,1/2] ovn-nbctl.c: Add "name" column of QoS table. > Add "name" column of QoS table > > Add "name" column of QoS table and make qos could be list > by command "ovn-nbctl list qos "name"". > > Signed-off-by: Yunxiang Tao <taoyunxiang@cmss.chinamobile.com> > > diff --git a/ovn-nb.ovsschema b/ovn-nb.ovsschema > index 12999a466..02ae48e73 100644 > --- a/ovn-nb.ovsschema > +++ b/ovn-nb.ovsschema > @@ -1,7 +1,7 @@ > { > "name": "OVN_Northbound", > "version": "5.18.0", > - "cksum": "2806349485 24196", > + "cksum": "80177565 24240", > "tables": { > "NB_Global": { > "columns": { > @@ -204,6 +204,7 @@ > "isRoot": false}, > "QoS": { > "columns": { > + "name": {"type": "string"}, > "priority": {"type": {"key": {"type": "integer", > "minInteger": 0, > "maxInteger": 32767}}}, > diff --git a/ovn-nb.xml b/ovn-nb.xml > index 4a93d2f4a..61e77397e 100644 > --- a/ovn-nb.xml > +++ b/ovn-nb.xml > @@ -1662,6 +1662,12 @@ > </p> > </column> > > + <column name="name"> > + <p> > + A name for the logical router. > + </p> > + </column> > + > <column name="direction"> > <p> > The value of this field is similar to <ref colun="direction" > diff --git a/utilities/ovn-nbctl.c b/utilities/ovn-nbctl.c > index 8188948fa..93e37d169 100644 > --- a/utilities/ovn-nbctl.c > +++ b/utilities/ovn-nbctl.c > @@ -5346,6 +5346,8 @@ static const struct ctl_table_class tables[NBREC_N_TABLES] = { > > [NBREC_TABLE_HA_CHASSIS_GROUP].row_ids[0] > = {&nbrec_ha_chassis_group_col_name, NULL, NULL}, > + > + [NBREC_TABLE_QOS].row_ids[0] = {&nbrec_qos_col_name, NULL, NULL}, > }; > > static char * > > > > taoyunxiang@cmss.chinamobile.com > _______________________________________________ > dev mailing list > dev@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev
diff --git a/ovn-nb.ovsschema b/ovn-nb.ovsschema index 12999a466..02ae48e73 100644 --- a/ovn-nb.ovsschema +++ b/ovn-nb.ovsschema @@ -1,7 +1,7 @@ { "name": "OVN_Northbound", "version": "5.18.0", - "cksum": "2806349485 24196", + "cksum": "80177565 24240", "tables": { "NB_Global": { "columns": { @@ -204,6 +204,7 @@ "isRoot": false}, "QoS": { "columns": { + "name": {"type": "string"}, "priority": {"type": {"key": {"type": "integer", "minInteger": 0, "maxInteger": 32767}}}, diff --git a/ovn-nb.xml b/ovn-nb.xml index 4a93d2f4a..61e77397e 100644 --- a/ovn-nb.xml +++ b/ovn-nb.xml @@ -1662,6 +1662,12 @@ </p> </column> + <column name="name"> + <p> + A name for the logical router. + </p> + </column> + <column name="direction"> <p> The value of this field is similar to <ref colun="direction" diff --git a/utilities/ovn-nbctl.c b/utilities/ovn-nbctl.c index 8188948fa..93e37d169 100644 --- a/utilities/ovn-nbctl.c +++ b/utilities/ovn-nbctl.c @@ -5346,6 +5346,8 @@ static const struct ctl_table_class tables[NBREC_N_TABLES] = { [NBREC_TABLE_HA_CHASSIS_GROUP].row_ids[0] = {&nbrec_ha_chassis_group_col_name, NULL, NULL}, + + [NBREC_TABLE_QOS].row_ids[0] = {&nbrec_qos_col_name, NULL, NULL}, }; static char *
Add "name" column of QoS table Add "name" column of QoS table and make qos could be list by command "ovn-nbctl list qos "name"". Signed-off-by: Yunxiang Tao <taoyunxiang@cmss.chinamobile.com> taoyunxiang@cmss.chinamobile.com