diff mbox series

[ovs-dev] Fixes memory leaked by call to ovn_extend_table_init that is missing a corresponding ovn_extend_table_destroy in test-ovn.c. This fixes leaks for the group_table and meter_table objects.

Message ID 20180926131204.7132-1-bshastry@sect.tu-berlin.de
State Accepted
Headers show
Series [ovs-dev] Fixes memory leaked by call to ovn_extend_table_init that is missing a corresponding ovn_extend_table_destroy in test-ovn.c. This fixes leaks for the group_table and meter_table objects. | expand

Commit Message

Bhargava Shastry Sept. 26, 2018, 1:11 p.m. UTC 
From: Bhargava Shastry <bshastry@sec.t-labs.tu-berlin.de>

Signed-off-by: Bhargava Shastry <bshastry at sect.tu-berlin.de>
---
 tests/test-ovn.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

0-day Robot Sept. 26, 2018, 1:56 p.m. UTC | #1 
Bleep bloop.  Greetings Bhargava Shastry, I am a robot and I have tried out your patch.
Thanks for your contribution.

I encountered some error that I wasn't expecting.  See the details below.


checkpatch:
ERROR: Author Bhargava Shastry <bshastry@sec.t-labs.tu-berlin.de> needs to sign off.
WARNING: Unexpected sign-offs from developers who are not authors or co-authors or committers: Bhargava Shastry <bshastry at sect.tu-berlin.de>
Lines checked: 27, Warnings: 1, Errors: 1


Please check this out.  If you feel there has been an error, please email aconole@bytheb.org

Thanks,
0-day Robot
Ben Pfaff Sept. 26, 2018, 8:39 p.m. UTC | #2 
On Wed, Sep 26, 2018 at 03:11:40PM +0200, bshastry@sect.tu-berlin.de wrote:
> From: Bhargava Shastry <bshastry@sec.t-labs.tu-berlin.de>
> 
> Signed-off-by: Bhargava Shastry <bshastry at sect.tu-berlin.de>

Thanks, applied to master.
diff mbox series

Patch

diff --git a/tests/test-ovn.c b/tests/test-ovn.c
index 5e6d1c3b4..ebaf21673 100644
--- a/tests/test-ovn.c
+++ b/tests/test-ovn.c
@@ -1347,6 +1347,8 @@  test_parse_actions(struct ovs_cmdl_context *ctx OVS_UNUSED)
     dhcp_opts_destroy(&dhcp_opts);
     dhcp_opts_destroy(&dhcpv6_opts);
     nd_ra_opts_destroy(&nd_ra_opts);
+    ovn_extend_table_destroy(&group_table);
+    ovn_extend_table_destroy(&meter_table);
     exit(ok ? EXIT_SUCCESS : EXIT_FAILURE);
 }