diff mbox series

[ovs-dev,v1,4/5] rhel: allow passing more flags to configure, fedora

Message ID 20180831185243.115867-4-martinxu9.ovs@gmail.com
State Accepted
Headers show
Series [ovs-dev,v1,1/5] rhel: openvswitch-kmod-fedora.spec.in file bug fix | expand

Commit Message

Martin Xu Aug. 31, 2018, 6:52 p.m. UTC
Define a variable _ovs_config_extra_flags to allow passing more flags to
configure when building OVS kmod RPM. For example, to build with a
non-standard openssl and add an RPATH, use the following command

make rpm-fedora-kmod RPMBUILD_OPT='-D "_ovs_config_extra_flags
--with-openssl=<path to your openssl header> LDFLAGS=\"\${LDFLAGS} -Xlinker
-rpath=<path to your openssl lib>\""'

Signed-off-by: Martin Xu <martinxu9.ovs@gmail.com>
CC: Greg Rose <gvrose8192@gmail.com>
CC: Flavio Leitner <fbl@sysclose.org>
---
 rhel/openvswitch-kmod-fedora.spec.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Flavio Leitner Sept. 3, 2018, 6:34 p.m. UTC | #1
On Fri, Aug 31, 2018 at 11:52:42AM -0700, Martin Xu wrote:
> Define a variable _ovs_config_extra_flags to allow passing more flags to
> configure when building OVS kmod RPM. For example, to build with a
> non-standard openssl and add an RPATH, use the following command
> 
> make rpm-fedora-kmod RPMBUILD_OPT='-D "_ovs_config_extra_flags
> --with-openssl=<path to your openssl header> LDFLAGS=\"\${LDFLAGS} -Xlinker
> -rpath=<path to your openssl lib>\""'
> 
> Signed-off-by: Martin Xu <martinxu9.ovs@gmail.com>
> CC: Greg Rose <gvrose8192@gmail.com>
> CC: Flavio Leitner <fbl@sysclose.org>

No objections from me.
Acked-by: Flavio Leitner <fbl@sysclose.org>



> ---
>  rhel/openvswitch-kmod-fedora.spec.in | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/rhel/openvswitch-kmod-fedora.spec.in b/rhel/openvswitch-kmod-fedora.spec.in
> index bf045b585..6656da630 100644
> --- a/rhel/openvswitch-kmod-fedora.spec.in
> +++ b/rhel/openvswitch-kmod-fedora.spec.in
> @@ -50,7 +50,7 @@ traffic. This package contains the kernel modules.
>  for kv in %{kversion}; do
>      mkdir -p _$kv
>      (cd _$kv && /bin/cp -f ../configure . && %configure --srcdir=.. \
> -        --with-linux=/lib/modules/${kv}/build --enable-ssl)
> +        --with-linux=/lib/modules/${kv}/build --enable-ssl %{_ovs_config_extra_flags})
>      make %{_smp_mflags} -C _$kv/datapath/linux
>  done
>  
> -- 
> 2.12.3
> 
> _______________________________________________
> dev mailing list
> dev@openvswitch.org
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Markos Chandras Sept. 4, 2018, 1:43 p.m. UTC | #2
On 03/09/18 19:34, Flavio Leitner wrote:
> On Fri, Aug 31, 2018 at 11:52:42AM -0700, Martin Xu wrote:
>> Define a variable _ovs_config_extra_flags to allow passing more flags to
>> configure when building OVS kmod RPM. For example, to build with a
>> non-standard openssl and add an RPATH, use the following command
>>
>> make rpm-fedora-kmod RPMBUILD_OPT='-D "_ovs_config_extra_flags
>> --with-openssl=<path to your openssl header> LDFLAGS=\"\${LDFLAGS} -Xlinker
>> -rpath=<path to your openssl lib>\""'
>>
>> Signed-off-by: Martin Xu <martinxu9.ovs@gmail.com>
>> CC: Greg Rose <gvrose8192@gmail.com>
>> CC: Flavio Leitner <fbl@sysclose.org>
> 
> No objections from me.
> Acked-by: Flavio Leitner <fbl@sysclose.org>
> 
> 

Looks good to me

Reviewed-by: Markos Chandras <mchandras@suse.de>
diff mbox series

Patch

diff --git a/rhel/openvswitch-kmod-fedora.spec.in b/rhel/openvswitch-kmod-fedora.spec.in
index bf045b585..6656da630 100644
--- a/rhel/openvswitch-kmod-fedora.spec.in
+++ b/rhel/openvswitch-kmod-fedora.spec.in
@@ -50,7 +50,7 @@  traffic. This package contains the kernel modules.
 for kv in %{kversion}; do
     mkdir -p _$kv
     (cd _$kv && /bin/cp -f ../configure . && %configure --srcdir=.. \
-        --with-linux=/lib/modules/${kv}/build --enable-ssl)
+        --with-linux=/lib/modules/${kv}/build --enable-ssl %{_ovs_config_extra_flags})
     make %{_smp_mflags} -C _$kv/datapath/linux
 done