From patchwork Fri Apr 20 09:24:32 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Finucane X-Patchwork-Id: 901820 X-Patchwork-Delegate: ian.stokes@intel.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=openvswitch.org (client-ip=140.211.169.12; helo=mail.linuxfoundation.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=that.guru Authentication-Results: ozlabs.org; dkim=fail reason="key not found in DNS" (0-bit key; unprotected) header.d=that.guru header.i=@that.guru header.b="rc3cdZ7I"; dkim-atps=neutral Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 40S9Rx1ctNz9s70 for ; Fri, 20 Apr 2018 19:25:00 +1000 (AEST) Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id 7D5F4CD2; Fri, 20 Apr 2018 09:24:58 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@mail.linuxfoundation.org Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id 8EC31CBB for ; Fri, 20 Apr 2018 09:24:56 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from catfish.maple.relay.mailchannels.net (catfish.maple.relay.mailchannels.net [23.83.214.32]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id 664286B5 for ; Fri, 20 Apr 2018 09:24:55 +0000 (UTC) X-Sender-Id: 5xi41l16bi|x-authuser|stephen@that.guru Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id BE2355E1EBA; Fri, 20 Apr 2018 09:24:51 +0000 (UTC) Received: from one.mxroute.com (unknown [100.96.13.46]) (Authenticated sender: 5xi41l16bi) by relay.mailchannels.net (Postfix) with ESMTPA id 3E0765E1FAA; Fri, 20 Apr 2018 09:24:51 +0000 (UTC) X-Sender-Id: 5xi41l16bi|x-authuser|stephen@that.guru Received: from one.mxroute.com (one-outgoing.mxroute.com [172.19.42.253]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.14.1); Fri, 20 Apr 2018 09:24:51 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: 5xi41l16bi|x-authuser|stephen@that.guru X-MailChannels-Auth-Id: 5xi41l16bi X-Hysterical-Inform: 69cb666f784671d0_1524216291626_1595603569 X-MC-Loop-Signature: 1524216291626:3977035820 X-MC-Ingress-Time: 1524216291626 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=that.guru; s=default; h=References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From: Sender:Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=FDnOZHd8Pq10+UwcEX3XupzDR5kcRm3rh9ZecYAwtSY=; b=rc3cdZ7IiNOEWgltyMxB/590nG vQdRSQQJAuA08nXZMwydFW3xNcP2IGqmOttkxAUW/bF4/C9FvbY1aPK6zWIkXuW/lJiTyH7DR/mx3 qMZMgI8hQv6uIXBRgHg45NDW/1CI2Lb1uCvRTMj0hCv+GovTBz0f28DPgf8FptutAMZGuWsRzAp+0 kM1eqSSh/cWI9rtNR7qZH91nbL9qtjlt/AHe9zwdvPE+YE3EsZOi17B0JURjbMG+Vk2wTxN/qF+z4 VoCajeMBvO1pz/NOn1opWrAg2M1ERA3IIYQS3pCwE38KuHH9UfPxge51SogcXKyn5q7pxQgXT8Vcq qI/FXbqw==; From: Stephen Finucane To: dev@openvswitch.org Date: Fri, 20 Apr 2018 10:24:32 +0100 Message-Id: <20180420092432.8374-1-stephen@that.guru> X-Mailer: git-send-email 2.14.3 In-Reply-To: <20180419125729.15198-1-stephen@that.guru> References: <20180419125729.15198-1-stephen@that.guru> X-AuthUser: stephen@that.guru X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_NONE,T_DKIM_INVALID autolearn=no version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on smtp1.linux-foundation.org Subject: [ovs-dev] [PATCH v3 10/n] docs: Clarify changes in Rx queue allocation X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: ovs-dev-bounces@openvswitch.org Errors-To: ovs-dev-bounces@openvswitch.org Two mistakes here: - Automatic assignment of Rx queues to PMD threads has always existed - it was simply switched from round-robin allocation to utilization-based allocation - The above, along with the 'pmd-rxq-rebalance' command, was added in OVS 2.9.0 - not OVS 2.8.0 - while the 'pmd-rxq-show' command was added in OVS 2.6.0 and modified in OVS 2.9.0 Correct both of these and modify the NEWS entry for this to clarify things a little (it took a bit of git spelunking and bothering people on IRC to figure out). Signed-off-by: Stephen Finucane Cc: Kevin Traynor Cc: Ian Stokes Acked-by: Kevin Traynor --- I'm not sure if it's OK to modify NEWS entries after a release. If not, please simply drop that hunk when applying this. --- Documentation/topics/dpdk/pmd.rst | 17 ++++++++++------- NEWS | 2 ++ 2 files changed, 12 insertions(+), 7 deletions(-) diff --git a/Documentation/topics/dpdk/pmd.rst b/Documentation/topics/dpdk/pmd.rst index a652720e2..5f0671ecc 100644 --- a/Documentation/topics/dpdk/pmd.rst +++ b/Documentation/topics/dpdk/pmd.rst @@ -148,14 +148,17 @@ or can be triggered by using:: $ ovs-appctl dpif-netdev/pmd-rxq-rebalance -.. versionchanged:: 2.8.0 +.. versionchanged:: 2.6.0 - Automatic assignment of Rx queues to PMDs and the two related commands, - ``pmd-rxq-show`` and ``pmd-rxq-rebalance``, were added in OVS 2.8.0. Prior - to this, behavior was round-robin and processing cycles were not taken into - consideration. Tracking for stats was not available. + The ``pmd-rxq-show`` command was added in OVS 2.6.0. .. versionchanged:: 2.9.0 - The output of ``pmd-rxq-show`` was modified to include utilization as a - percentage. + Utilization-based allocation of Rx queues to PMDs and the + ``pmd-rxq-rebalance`` command were added in OVS 2.9.0. Prior to this, + allocation was round-robin and processing cycles were not taken into + consideration. + + In addition, the output of ``pmd-rxq-show`` was modified to include + Rx queue utilization of the PMD as a percentage. Prior to this, tracking of + stats was not available. diff --git a/NEWS b/NEWS index cd4ffbbfb..3e3f55385 100644 --- a/NEWS +++ b/NEWS @@ -83,6 +83,8 @@ v2.9.0 - 19 Feb 2018 "management" statistics. - ovs-ofctl dump-ports command now prints new of set custom statistics if available (for OpenFlow 1.4+). + * Switch from round-robin allocation of rxq to pmd assignments to a + utilization-based allocation. * New appctl command 'dpif-netdev/pmd-rxq-rebalance' to rebalance rxq to pmd assignments. * Add rxq utilization of pmd to appctl 'dpif-netdev/pmd-rxq-show'.