From patchwork Mon Feb 26 20:04:02 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mark Michelson X-Patchwork-Id: 878063 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=openvswitch.org (client-ip=140.211.169.12; helo=mail.linuxfoundation.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=redhat.com Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3zqt8Q0prNz9rxx for ; Tue, 27 Feb 2018 07:04:38 +1100 (AEDT) Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id 60C71116D; Mon, 26 Feb 2018 20:04:06 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@mail.linuxfoundation.org Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id B45621139 for ; Mon, 26 Feb 2018 20:04:05 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id 72AA5110 for ; Mon, 26 Feb 2018 20:04:04 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 612418D742 for ; Mon, 26 Feb 2018 20:04:03 +0000 (UTC) Received: from monae.redhat.com (ovpn-122-53.rdu2.redhat.com [10.10.122.53]) by smtp.corp.redhat.com (Postfix) with ESMTP id 381A9213AEF4 for ; Mon, 26 Feb 2018 20:04:03 +0000 (UTC) From: Mark Michelson To: dev@openvswitch.org Date: Mon, 26 Feb 2018 14:04:02 -0600 Message-Id: <20180226200402.18344-1-mmichels@redhat.com> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.2]); Mon, 26 Feb 2018 20:04:03 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.2]); Mon, 26 Feb 2018 20:04:03 +0000 (UTC) for IP:'10.11.54.6' DOMAIN:'int-mx06.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'mmichels@redhat.com' RCPT:'' X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_LOW, T_RP_MATCHES_RCVD autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on smtp1.linux-foundation.org Subject: [ovs-dev] [PATCH v2] Refer to database manpages in *ctl manpages X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: ovs-dev-bounces@openvswitch.org Errors-To: ovs-dev-bounces@openvswitch.org The ovn-nbctl, ovn-sbctl, and ovs-vsctl manpages are inconsistent in their "Database Commands" section when it comes to referring to what database tables exist. This commit amends this by making each *ctl manpage reference the corresponding database manpage instead. To aid in having a more handy list, the --help text of ovn-nbctl, ovn-sbctl, and ovs-vsctl have been modified to list the available tables. This is also referenced in the manpages for those applications. Signed-off-by: Mark Michelson Signed-off-by: Ben Pfaff Please enter the commit message for your changes. Lines starting --- lib/db-ctl-base.c | 69 ++++++++++++++++++++++++++++++++++++++++--- lib/db-ctl-base.h | 14 ++++----- ovn/lib/ovn-util.h | 5 ++++ ovn/utilities/ovn-nbctl.8.xml | 61 +++----------------------------------- ovn/utilities/ovn-nbctl.c | 5 ++-- ovn/utilities/ovn-sbctl.8.in | 5 ++-- ovn/utilities/ovn-sbctl.c | 6 ++-- utilities/ovs-vsctl.8.in | 51 ++------------------------------ utilities/ovs-vsctl.c | 7 +++-- vtep/vtep-ctl.c | 7 +++-- 10 files changed, 103 insertions(+), 127 deletions(-) diff --git a/lib/db-ctl-base.c b/lib/db-ctl-base.c index 9fec6fa0d..ae7b6cde2 100644 --- a/lib/db-ctl-base.c +++ b/lib/db-ctl-base.c @@ -35,6 +35,7 @@ #include "ovsdb-idl-provider.h" #include "openvswitch/shash.h" #include "sset.h" +#include "svec.h" #include "string.h" #include "table.h" #include "util.h" @@ -61,6 +62,9 @@ static const struct cmd_show_table *cmd_show_tables; static void (*ctl_exit_func)(int status) = NULL; OVS_NO_RETURN static void ctl_exit(int status); +/* IDL class. */ +static const struct ovsdb_idl_class *idl_class; + /* Two arrays with 'n_classes' elements, which represent the tables in this * database and how the user can refer to their rows. */ static const struct ctl_table_class *ctl_classes; @@ -2132,15 +2136,15 @@ ctl_register_commands(const struct ctl_command_syntax *commands) /* Registers the 'db_ctl_commands' to 'all_commands'. */ void -ctl_init__(const struct ovsdb_idl_table_class *idl_classes_, +ctl_init__(const struct ovsdb_idl_class *idl_class_, const struct ctl_table_class *ctl_classes_, - size_t n_classes_, const struct cmd_show_table cmd_show_tables_[], void (*ctl_exit_func_)(int status)) { - idl_classes = idl_classes_; + idl_class = idl_class_; + idl_classes = idl_class_->tables; ctl_classes = ctl_classes_; - n_classes = n_classes_; + n_classes = idl_class->n_tables; ctl_exit_func = ctl_exit_func_; ctl_register_commands(db_ctl_commands); @@ -2170,6 +2174,63 @@ ctl_get_db_cmd_usage(void) Potentially unsafe database commands require --force option.\n"; } +const char * +ctl_list_db_tables_usage(void) +{ + static struct ds s = DS_EMPTY_INITIALIZER; + if (s.length) { + return ds_cstr(&s); + } + + ds_put_cstr(&s, "Database commands may reference a row in each table in the following ways:\n"); + for (int i = 0; i < n_classes; i++) { + struct svec options = SVEC_EMPTY_INITIALIZER; + + svec_add(&options, "by UUID"); + if (idl_classes[i].is_singleton) { + svec_add(&options, "as \".\""); + } + + for (int j = 0; j < ARRAY_SIZE(ctl_classes[i].row_ids); j++) { + const struct ctl_row_id *id = &ctl_classes[i].row_ids[j]; + if (!id->name_column) { + continue; + } + + struct ds o = DS_EMPTY_INITIALIZER; + if (id->uuid_column) { + ds_put_format(&o, "via \"%s\"", id->uuid_column->name); + const struct ovsdb_idl_table_class *referrer + = ovsdb_idl_table_class_from_column(idl_class, + id->uuid_column); + if (referrer != &idl_classes[i]) { + ds_put_format(&o, " of %s", referrer->name); + } + if (id->key) { + ds_put_format(&o, " with matching \"%s:%s\"", + id->name_column->name, id->key); + } else { + ds_put_format(&o, " with matching \"%s\"", id->name_column->name); + } + } else if (id->key) { + ds_put_format(&o, "by \"%s:%s\"", id->name_column->name, id->key); + } else { + ds_put_format(&o, "by \"%s\"", id->name_column->name); + } + svec_add_nocopy(&options, ds_steal_cstr(&o)); + } + + ds_put_format(&s, " %s:", idl_classes[i].name); + for (int j = 0; j < options.n; j++) { + ds_put_format(&s, "\n %s", options.names[j]); + } + ds_put_char(&s, '\n'); + svec_destroy(&options); + } + + return ds_cstr(&s); +} + /* Initializes 'ctx' from 'command'. */ void ctl_context_init_command(struct ctl_context *ctx, diff --git a/lib/db-ctl-base.h b/lib/db-ctl-base.h index 81f0d0b27..a2f91abfb 100644 --- a/lib/db-ctl-base.h +++ b/lib/db-ctl-base.h @@ -51,13 +51,11 @@ struct cmd_show_table; /* ctl_init() figures out the number of tables on its own and flags an error if * 'ctl_classes' was defined with the wrong number of elements. */ -#define ctl_init(idl_classes, ctl_classes, cmd_show_table, ctl_exit_func) \ - (BUILD_ASSERT(ARRAY_SIZE(idl_classes) == ARRAY_SIZE(ctl_classes)), \ - ctl_init__(idl_classes, ctl_classes, ARRAY_SIZE(idl_classes), \ - cmd_show_table, ctl_exit_func)) -void ctl_init__(const struct ovsdb_idl_table_class *idl_classes, - const struct ctl_table_class *ctl_classes, - size_t n_classes, +#define ctl_init(idl_class, table_classes, ctl_classes, cmd_show_table, \ + ctl_exit_func) \ + (BUILD_ASSERT(ARRAY_SIZE(table_classes) == ARRAY_SIZE(ctl_classes)), \ + ctl_init__(idl_class, ctl_classes, cmd_show_table, ctl_exit_func)) +void ctl_init__(const struct ovsdb_idl_class *, const struct ctl_table_class *, const struct cmd_show_table *cmd_show_tables, void (*ctl_exit_func)(int status)); char *ctl_default_db(void); @@ -159,6 +157,8 @@ struct ctl_command { bool ctl_might_write_to_db(char **argv); const char *ctl_get_db_cmd_usage(void); + +const char *ctl_list_db_tables_usage(void); void ctl_print_commands(void); void ctl_print_options(const struct option *); void ctl_add_cmd_options(struct option **, size_t *n_options_p, diff --git a/ovn/lib/ovn-util.h b/ovn/lib/ovn-util.h index 7ff9f9a1c..6d5e1dfb5 100644 --- a/ovn/lib/ovn-util.h +++ b/ovn/lib/ovn-util.h @@ -68,6 +68,11 @@ char *alloc_nat_zone_key(const struct uuid *key, const char *type); const char *default_nb_db(void); const char *default_sb_db(void); +struct ovsdb_idl_table_class; +const char *db_table_usage(struct ds *tables, + const struct ovsdb_idl_table_class *class, + int n_tables); + bool ovn_is_known_nb_lsp_type(const char *type); uint32_t sbrec_logical_flow_hash(const struct sbrec_logical_flow *); diff --git a/ovn/utilities/ovn-nbctl.8.xml b/ovn/utilities/ovn-nbctl.8.xml index 4d0aea963..7f4b3aba8 100644 --- a/ovn/utilities/ovn-nbctl.8.xml +++ b/ovn/utilities/ovn-nbctl.8.xml @@ -820,64 +820,11 @@ additional ways to identify records. Some commands also take column parameters that identify a particular field within the records in a table.

-

The following tables are currently defined:

-
-
Logical_Switch
-
- An L2 logical switch. Records may be identified by name. -
- -
Logical_Switch_Port
-
- A port within an L2 logical switch. Records may be identified by name. -
- -
ACL
-
- An ACL rule for a logical switch that points to it through its acls column. -
- -
Logical_Router
-
- An L3 logical router. Records may be identified by name. -
- -
Logical_Router_Port
-
- A port within an L3 logical router. Records may be identified by name. -
- -
Logical_Router_Static_Route
-
- A static route belonging to an L3 logical router. -
-
Address_Set
-
- An address set that can be used in ACLs. -
- -
Load_Balancer
-
- A load balancer for a logical switch that points to it through its load_balancer column. -
- -
NAT
-
- A NAT rule for a Gateway router. -
- -
DHCP_Options
-
- DHCP options. -
- -
NB_Global
-
- North bound global configurations. -
- -
+

+ For a list of tables and their columns, see ovn-nb(5) or + see the table listing from the --help option. +

Record names must be specified in full and with correct capitalization, diff --git a/ovn/utilities/ovn-nbctl.c b/ovn/utilities/ovn-nbctl.c index b3f60bdb7..80fb97cd4 100644 --- a/ovn/utilities/ovn-nbctl.c +++ b/ovn/utilities/ovn-nbctl.c @@ -455,6 +455,7 @@ SSL commands:\n\ set the SSL configuration\n\ \n\ %s\ +%s\ \n\ Synchronization command (use with --wait=sb|hv):\n\ sync wait even for earlier changes to take effect\n\ @@ -469,7 +470,7 @@ Options:\n\ --dry-run do not commit changes to database\n\ --oneline print exactly one line of output per command\n", program_name, program_name, ctl_get_db_cmd_usage(), - default_nb_db()); + ctl_list_db_tables_usage(), default_nb_db()); table_usage(); vlog_usage(); printf("\ @@ -4081,6 +4082,6 @@ static const struct ctl_command_syntax nbctl_commands[] = { static void nbctl_cmd_init(void) { - ctl_init(nbrec_table_classes, tables, NULL, nbctl_exit); + ctl_init(&nbrec_idl_class, nbrec_table_classes, tables, NULL, nbctl_exit); ctl_register_commands(nbctl_commands); } diff --git a/ovn/utilities/ovn-sbctl.8.in b/ovn/utilities/ovn-sbctl.8.in index cd43cf3be..c59a9f542 100644 --- a/ovn/utilities/ovn-sbctl.8.in +++ b/ovn/utilities/ovn-sbctl.8.in @@ -278,8 +278,9 @@ parameter may be the UUID for a record, and many tables offer additional ways to identify records. Some commands also take \fIcolumn\fR parameters that identify a particular field within the records in a table. -.\" It would be kind to list all the tables and their supported identifiers -.\" here. +.PP +For a list of tables and their columns, see \fBovn\-sb\fR(5) or +see the table listing from the \fB--help\fR option. .PP Record names must be specified in full and with correct capitalization, except that UUIDs may be abbreviated to their first 4 diff --git a/ovn/utilities/ovn-sbctl.c b/ovn/utilities/ovn-sbctl.c index 5764ee336..c2fd18338 100644 --- a/ovn/utilities/ovn-sbctl.c +++ b/ovn/utilities/ovn-sbctl.c @@ -326,6 +326,7 @@ SSL commands:\n\ set the SSL configuration\n\ \n\ %s\ +%s\ \n\ Options:\n\ --db=DATABASE connect to DATABASE\n\ @@ -334,7 +335,7 @@ Options:\n\ --dry-run do not commit changes to database\n\ --oneline print exactly one line of output per command\n", program_name, program_name, ctl_get_db_cmd_usage(), - default_sb_db()); + ctl_list_db_tables_usage(), default_sb_db()); table_usage(); vlog_usage(); printf("\ @@ -1442,6 +1443,7 @@ static const struct ctl_command_syntax sbctl_commands[] = { static void sbctl_cmd_init(void) { - ctl_init(sbrec_table_classes, tables, cmd_show_tables, sbctl_exit); + ctl_init(&sbrec_idl_class, sbrec_table_classes, tables, + cmd_show_tables, sbctl_exit); ctl_register_commands(sbctl_commands); } diff --git a/utilities/ovs-vsctl.8.in b/utilities/ovs-vsctl.8.in index 34f41e4e8..b18782c31 100644 --- a/utilities/ovs-vsctl.8.in +++ b/utilities/ovs-vsctl.8.in @@ -530,55 +530,8 @@ additional ways to identify records. Some commands also take \fIcolumn\fR parameters that identify a particular field within the records in a table. .PP -The following tables are currently defined: -.IP "\fBOpen_vSwitch\fR" -Global configuration for an \fBovs\-vswitchd\fR. This table contains -exactly one record, identified by specifying \fB.\fR as the record -name. -.IP "\fBBridge\fR" -Configuration for a bridge within an Open vSwitch. Records may be -identified by bridge name. -.IP "\fBPort\fR" -A bridge port. Records may be identified by port name. -.IP "\fBInterface\fR" -A network device attached to a port. Records may be identified by -name. -.IP "\fBFlow_Table\fR" -Configuration for a particular OpenFlow flow table. Records may be -identified by name. -.IP "\fBQoS\fR" -Quality-of-service configuration for a \fBPort\fR. Records may be -identified by port name. -.IP "\fBQueue\fR" -Configuration for one queue within a \fBQoS\fR configuration. Records -may only be identified by UUID. -.IP "\fBMirror\fR" -A port mirroring configuration attached to a bridge. Records may be -identified by mirror name. -.IP "\fBController\fR" -Configuration for an OpenFlow controller. A controller attached to a -particular bridge may be identified by the bridge's name. -.IP "\fBManager\fR" -Configuration for an OVSDB connection. Records may be identified -by target (e.g. \fBtcp:1.2.3.4\fR). -.IP "\fBNetFlow\fR" -A NetFlow configuration attached to a bridge. Records may be -identified by bridge name. -.IP "\fBSSL\fR" -The global SSL configuration for \fBovs\-vswitchd\fR. The record -attached to the \fBOpen_vSwitch\fR table may be identified by -specifying \fB.\fR as the record name. -.IP "\fBsFlow\fR" -An sFlow exporter configuration attached to a bridge. Records may be -identified by bridge name. -.IP "\fBIPFIX\fR" -An IPFIX exporter configuration attached to a bridge. Records may be -identified by bridge name. -.IP "\fBFlow_Sample_Collector_Set\fR" -An IPFIX exporter configuration attached to a bridge for sampling -packets on a per-flow basis using OpenFlow \fBsample\fR actions. -.IP "\fBAutoAttach\fR" -Configuration for Auto Attach within a bridge. +For a list of tables and their columns, see \fBovs-vswitchd.conf.db\fR(5) or +see the table listing from the \fB--help\fR option. .PP Record names must be specified in full and with correct capitalization, except that UUIDs may be abbreviated to their first 4 diff --git a/utilities/ovs-vsctl.c b/utilities/ovs-vsctl.c index e22baeb28..21fa18ddb 100644 --- a/utilities/ovs-vsctl.c +++ b/utilities/ovs-vsctl.c @@ -416,6 +416,7 @@ Switch commands:\n\ emer-reset reset switch to known good state\n\ \n\ %s\ +%s\ \n\ Options:\n\ --db=DATABASE connect to DATABASE\n\ @@ -425,7 +426,8 @@ Options:\n\ -t, --timeout=SECS wait at most SECS seconds for ovs-vswitchd\n\ --dry-run do not commit changes to database\n\ --oneline print exactly one line of output per command\n", - program_name, program_name, ctl_get_db_cmd_usage(), ctl_default_db()); + program_name, program_name, ctl_get_db_cmd_usage(), + ctl_list_db_tables_usage(), ctl_default_db()); table_usage(); vlog_usage(); printf("\ @@ -2877,6 +2879,7 @@ static const struct ctl_command_syntax vsctl_commands[] = { static void vsctl_cmd_init(void) { - ctl_init(ovsrec_table_classes, tables, cmd_show_tables, vsctl_exit); + ctl_init(&ovsrec_idl_class, ovsrec_table_classes, tables, cmd_show_tables, + vsctl_exit); ctl_register_commands(vsctl_commands); } diff --git a/vtep/vtep-ctl.c b/vtep/vtep-ctl.c index 056dc687a..a8967ea1c 100644 --- a/vtep/vtep-ctl.c +++ b/vtep/vtep-ctl.c @@ -361,6 +361,7 @@ MAC binding commands:\n\ list-remote-macs LS list remote mac entries\n\ \n\ %s\ +%s\ \n\ Options:\n\ --db=DATABASE connect to DATABASE\n\ @@ -368,7 +369,8 @@ Options:\n\ -t, --timeout=SECS wait at most SECS seconds\n\ --dry-run do not commit changes to database\n\ --oneline print exactly one line of output per command\n", - program_name, program_name, ctl_get_db_cmd_usage(), ctl_default_db()); + program_name, program_name, ctl_get_db_cmd_usage(), + ctl_list_db_tables_usage(), ctl_default_db()); table_usage(); vlog_usage(); printf("\ @@ -2499,6 +2501,7 @@ static const struct ctl_command_syntax vtep_commands[] = { static void vtep_ctl_cmd_init(void) { - ctl_init(vteprec_table_classes, tables, cmd_show_tables, vtep_ctl_exit); + ctl_init(&vteprec_idl_class, vteprec_table_classes, tables, + cmd_show_tables, vtep_ctl_exit); ctl_register_commands(vtep_commands); }