| Message ID | 20170717171244.22106-1-blp@ovn.org |
|---|---|
| State | Accepted |
| Headers | show |
> On Jul 17, 2017, at 10:12 AM, Ben Pfaff <blp@ovn.org> wrote: > > GNU (at least) printf interprets -I as an option, but we want to print it > literally, so use %s. > > CC: YAMAMOTO Takashi <yamamoto@ovn.org> > Fixes: 27d41afaa446 ("acinclude.m4: Avoid echo -n") > Signed-off-by: Ben Pfaff <blp@ovn.org> Acked-by: Justin Pettit <jpettit@ovn.org> --Justin
On Mon, Jul 17, 2017 at 10:15:07AM -0700, Justin Pettit wrote: > > > On Jul 17, 2017, at 10:12 AM, Ben Pfaff <blp@ovn.org> wrote: > > > > GNU (at least) printf interprets -I as an option, but we want to print it > > literally, so use %s. > > > > CC: YAMAMOTO Takashi <yamamoto@ovn.org> > > Fixes: 27d41afaa446 ("acinclude.m4: Avoid echo -n") > > Signed-off-by: Ben Pfaff <blp@ovn.org> > > Acked-by: Justin Pettit <jpettit@ovn.org> Thanks, applied to master.
oops, thank you. On Tue, Jul 18, 2017 at 2:12 AM, Ben Pfaff <blp@ovn.org> wrote: > GNU (at least) printf interprets -I as an option, but we want to print it > literally, so use %s. > > CC: YAMAMOTO Takashi <yamamoto@ovn.org> > Fixes: 27d41afaa446 ("acinclude.m4: Avoid echo -n") > Signed-off-by: Ben Pfaff <blp@ovn.org> > --- > acinclude.m4 | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/acinclude.m4 b/acinclude.m4 > index 05c57b88d68e..e7affc514811 100644 > --- a/acinclude.m4 > +++ b/acinclude.m4 > @@ -968,7 +968,7 @@ dnl ctags ignores symbols with extras identifiers. > This builds a list of > dnl specially handled identifiers to be ignored. > AC_DEFUN([OVS_CTAGS_IDENTIFIERS], > AC_SUBST([OVS_CTAGS_IDENTIFIERS_LIST], > - [`printf '-I "'; sed -n 's/^#define > \(OVS_[A-Z_]\+\)(\.\.\.)$/\1+/p' ${srcdir}/include/openvswitch/compiler.h > | tr \\\n ' ' ; printf '"'`] )) > + [`printf %s '-I "'; sed -n 's/^#define > \(OVS_[A-Z_]\+\)(\.\.\.)$/\1+/p' ${srcdir}/include/openvswitch/compiler.h > | tr \\\n ' ' ; printf '"'`] )) > > dnl OVS_PTHREAD_SET_NAME > dnl > -- > 2.10.2 > >
diff --git a/acinclude.m4 b/acinclude.m4 index 05c57b88d68e..e7affc514811 100644 --- a/acinclude.m4 +++ b/acinclude.m4 @@ -968,7 +968,7 @@ dnl ctags ignores symbols with extras identifiers. This builds a list of dnl specially handled identifiers to be ignored. AC_DEFUN([OVS_CTAGS_IDENTIFIERS], AC_SUBST([OVS_CTAGS_IDENTIFIERS_LIST], - [`printf '-I "'; sed -n 's/^#define \(OVS_[A-Z_]\+\)(\.\.\.)$/\1+/p' ${srcdir}/include/openvswitch/compiler.h | tr \\\n ' ' ; printf '"'`] )) + [`printf %s '-I "'; sed -n 's/^#define \(OVS_[A-Z_]\+\)(\.\.\.)$/\1+/p' ${srcdir}/include/openvswitch/compiler.h | tr \\\n ' ' ; printf '"'`] )) dnl OVS_PTHREAD_SET_NAME dnl
GNU (at least) printf interprets -I as an option, but we want to print it literally, so use %s. CC: YAMAMOTO Takashi <yamamoto@ovn.org> Fixes: 27d41afaa446 ("acinclude.m4: Avoid echo -n") Signed-off-by: Ben Pfaff <blp@ovn.org> --- acinclude.m4 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)