| Message ID | 20170713145134.5594-1-aconole@redhat.com |
|---|---|
| State | Accepted |
| Headers | show |
Hi Aaron, On 13/07/17 15:51, Aaron Conole wrote: > During initialization, it's possible that the startup time takes longer > than the systemd default provided. Set this to be 5 minutes. If we > take longer than 5 minutes, maybe something is wrong. > > As an example of long initialization, enable DPDK, and allocate large > numbers of hugepages before starting ovs-vswitchd. The vswitchd can > take two or more minutes to start. During that time, systemd will decide > that the startup time took too long, and kill the parent process, leading > eventually to an error like: > ovs|00011|daemon_unix|EMER|pipe write failed (Broken pipe) > > And a systemd log like: > ovs-vswitchd.service start operation timed out. Terminating. > > The 5 minutes setting has been observed to work on a system where 400G > of hugepages were allocated. > > Signed-off-by: Aaron Conole <aconole@redhat.com> Yeah looks reasonable Reviewed-by: Markos Chandras <mchandras@suse.de>
On 07/13/2017 04:51 PM, Aaron Conole wrote: > During initialization, it's possible that the startup time takes longer > than the systemd default provided. Set this to be 5 minutes. If we > take longer than 5 minutes, maybe something is wrong. > > As an example of long initialization, enable DPDK, and allocate large > numbers of hugepages before starting ovs-vswitchd. The vswitchd can > take two or more minutes to start. During that time, systemd will decide > that the startup time took too long, and kill the parent process, leading > eventually to an error like: > ovs|00011|daemon_unix|EMER|pipe write failed (Broken pipe) > > And a systemd log like: > ovs-vswitchd.service start operation timed out. Terminating. > > The 5 minutes setting has been observed to work on a system where 400G > of hugepages were allocated. > > Signed-off-by: Aaron Conole <aconole@redhat.com> LGTM Reviewed-by: Timothy Redaelli <tredaelli@redhat.com>
On Thu, Jul 13, 2017 at 12:27 PM, Timothy M. Redaelli <tredaelli@redhat.com> wrote: > On 07/13/2017 04:51 PM, Aaron Conole wrote: >> During initialization, it's possible that the startup time takes longer >> than the systemd default provided. Set this to be 5 minutes. If we >> take longer than 5 minutes, maybe something is wrong. >> >> As an example of long initialization, enable DPDK, and allocate large >> numbers of hugepages before starting ovs-vswitchd. The vswitchd can >> take two or more minutes to start. During that time, systemd will decide >> that the startup time took too long, and kill the parent process, leading >> eventually to an error like: >> ovs|00011|daemon_unix|EMER|pipe write failed (Broken pipe) >> >> And a systemd log like: >> ovs-vswitchd.service start operation timed out. Terminating. >> >> The 5 minutes setting has been observed to work on a system where 400G >> of hugepages were allocated. >> >> Signed-off-by: Aaron Conole <aconole@redhat.com> > > LGTM > > Reviewed-by: Timothy Redaelli <tredaelli@redhat.com> Thanks, I applied to master and branch-2.7. I also updated "reviewed-by" to be "acked-by" to match OVS convention.
diff --git a/rhel/usr_lib_systemd_system_ovs-vswitchd.service b/rhel/usr_lib_systemd_system_ovs-vswitchd.service index 22a4c63..886b68a 100644 --- a/rhel/usr_lib_systemd_system_ovs-vswitchd.service +++ b/rhel/usr_lib_systemd_system_ovs-vswitchd.service @@ -18,3 +18,4 @@ ExecStop=/usr/share/openvswitch/scripts/ovs-ctl --no-ovsdb-server stop ExecReload=/usr/share/openvswitch/scripts/ovs-ctl --no-ovsdb-server \ --no-monitor --system-id=random \ restart $OPTIONS +TimeoutSec=300
During initialization, it's possible that the startup time takes longer than the systemd default provided. Set this to be 5 minutes. If we take longer than 5 minutes, maybe something is wrong. As an example of long initialization, enable DPDK, and allocate large numbers of hugepages before starting ovs-vswitchd. The vswitchd can take two or more minutes to start. During that time, systemd will decide that the startup time took too long, and kill the parent process, leading eventually to an error like: ovs|00011|daemon_unix|EMER|pipe write failed (Broken pipe) And a systemd log like: ovs-vswitchd.service start operation timed out. Terminating. The 5 minutes setting has been observed to work on a system where 400G of hugepages were allocated. Signed-off-by: Aaron Conole <aconole@redhat.com> --- rhel/usr_lib_systemd_system_ovs-vswitchd.service | 1 + 1 file changed, 1 insertion(+)