| Message ID | 20170615194651.8180-1-rams@vmware.com |
|---|---|
| State | Accepted |
| Delegated to: | Guru Shetty |
| Headers | show |
On Jun 15, 2017, at 12:46 PM, Shashank Ram <rams@vmware.com<mailto:rams@vmware.com>> wrote: The existing code throws a warning when compiled with the Windows 10 SDK: 'typedef ': ignored on left of 'NAT_ACTION' when no variable is declared Signed-off-by: Shashank Ram <rams@vmware.com<mailto:rams@vmware.com>> Acked-by: Nithin Raju <nithin@vmware.com<mailto:nithin@vmware.com>> Thanks, -- Nithin
Acked-by: Sairam Venugopal <vsairam@vmware.com> On 6/15/17, 12:46 PM, "ovs-dev-bounces@openvswitch.org on behalf of Shashank Ram" <ovs-dev-bounces@openvswitch.org on behalf of rams@vmware.com> wrote: >The existing code throws a warning when compiled >with the Windows 10 SDK: >'typedef ': ignored on left of 'NAT_ACTION' when no variable is declared > >Signed-off-by: Shashank Ram <rams@vmware.com> >--- > datapath-windows/ovsext/Conntrack.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/datapath-windows/ovsext/Conntrack.h b/datapath-windows/ovsext/Conntrack.h >index fcdd96e..04ca299 100644 >--- a/datapath-windows/ovsext/Conntrack.h >+++ b/datapath-windows/ovsext/Conntrack.h >@@ -69,14 +69,14 @@ typedef struct MD_LABELS { > struct ovs_key_ct_labels mask; > } MD_LABELS; > >-typedef enum NAT_ACTION { >+typedef enum _NAT_ACTION { > NAT_ACTION_NONE = 0, > NAT_ACTION_REVERSE = 1 << 0, > NAT_ACTION_SRC = 1 << 1, > NAT_ACTION_SRC_PORT = 1 << 2, > NAT_ACTION_DST = 1 << 3, > NAT_ACTION_DST_PORT = 1 << 4, >-}; >+} NAT_ACTION; > > typedef struct _OVS_CT_KEY { > struct ct_endpoint src; >-- >2.9.3.windows.2 > >_______________________________________________ >dev mailing list >dev@openvswitch.org >https://urldefense.proofpoint.com/v2/url?u=https-3A__mail.openvswitch.org_mailman_listinfo_ovs-2Ddev&d=DwICAg&c=uilaK90D4TOVoH58JNXRgQ&r=Z6vowHUOjP5ysP_g372c49Nqc1vEKqHKNBkR5Q5Z7uo&m=3Dz3HHrBXQtG1qmIwlchkCobPqUjawGcRt9P4TMS6MA&s=G14YPFl6TG_Nkp3lTLYzBJsy2SiG9meKRUs8j-taX3w&e=
Acked-by: Alin Gabriel Serdean <aserdean@cloudbasesolutions.com> > -----Original Message----- > From: ovs-dev-bounces@openvswitch.org [mailto:ovs-dev- > bounces@openvswitch.org] On Behalf Of Sairam Venugopal > Sent: Friday, June 16, 2017 12:20 AM > To: Shashank Ram <rams@vmware.com>; dev@openvswitch.org > Subject: Re: [ovs-dev] [PATCH] datapath-windows: Define NAT_ACTION > enum correctly > > Acked-by: Sairam Venugopal <vsairam@vmware.com> > > > > > > On 6/15/17, 12:46 PM, "ovs-dev-bounces@openvswitch.org on behalf of > Shashank Ram" <ovs-dev-bounces@openvswitch.org on behalf of > rams@vmware.com> wrote: > > >The existing code throws a warning when compiled with the Windows 10 > >SDK: [Alin Serdean] (*)WDK > >'typedef ': ignored on left of 'NAT_ACTION' when no variable is > >declared > > > >Signed-off-by: Shashank Ram <rams@vmware.com>
On 15 June 2017 at 12:46, Shashank Ram <rams@vmware.com> wrote: > The existing code throws a warning when compiled > with the Windows 10 SDK: > 'typedef ': ignored on left of 'NAT_ACTION' when no variable is declared > > Signed-off-by: Shashank Ram <rams@vmware.com> > Applied, thanks! > --- > datapath-windows/ovsext/Conntrack.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/datapath-windows/ovsext/Conntrack.h > b/datapath-windows/ovsext/Conntrack.h > index fcdd96e..04ca299 100644 > --- a/datapath-windows/ovsext/Conntrack.h > +++ b/datapath-windows/ovsext/Conntrack.h > @@ -69,14 +69,14 @@ typedef struct MD_LABELS { > struct ovs_key_ct_labels mask; > } MD_LABELS; > > -typedef enum NAT_ACTION { > +typedef enum _NAT_ACTION { > NAT_ACTION_NONE = 0, > NAT_ACTION_REVERSE = 1 << 0, > NAT_ACTION_SRC = 1 << 1, > NAT_ACTION_SRC_PORT = 1 << 2, > NAT_ACTION_DST = 1 << 3, > NAT_ACTION_DST_PORT = 1 << 4, > -}; > +} NAT_ACTION; > > typedef struct _OVS_CT_KEY { > struct ct_endpoint src; > -- > 2.9.3.windows.2 > > _______________________________________________ > dev mailing list > dev@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev >
diff --git a/datapath-windows/ovsext/Conntrack.h b/datapath-windows/ovsext/Conntrack.h index fcdd96e..04ca299 100644 --- a/datapath-windows/ovsext/Conntrack.h +++ b/datapath-windows/ovsext/Conntrack.h @@ -69,14 +69,14 @@ typedef struct MD_LABELS { struct ovs_key_ct_labels mask; } MD_LABELS; -typedef enum NAT_ACTION { +typedef enum _NAT_ACTION { NAT_ACTION_NONE = 0, NAT_ACTION_REVERSE = 1 << 0, NAT_ACTION_SRC = 1 << 1, NAT_ACTION_SRC_PORT = 1 << 2, NAT_ACTION_DST = 1 << 3, NAT_ACTION_DST_PORT = 1 << 4, -}; +} NAT_ACTION; typedef struct _OVS_CT_KEY { struct ct_endpoint src;
The existing code throws a warning when compiled with the Windows 10 SDK: 'typedef ': ignored on left of 'NAT_ACTION' when no variable is declared Signed-off-by: Shashank Ram <rams@vmware.com> --- datapath-windows/ovsext/Conntrack.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)