[ovs-dev,02/31] fixup: packet_type originated in OpenFlow 1.5, not 1.3.

Signed-off-by: Ben Pfaff <blp@ovn.org>
---
 include/openvswitch/meta-flow.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Agree, packet type was introduced only in OF 1.5.

The intention with making packet type match field available from OF 1.3 was to allow SDN controllers to consume this functionality without having to implement the OF 1.5 wire protocol and (associated) the support of multiple OF versions in parallel. I believe that is a bigger hurdle for e.g. OpenDaylight.

Do you reject the support in OF 1.3 in general or just for the standard OXM point code? Would you except introduction support of packet type as experimenter extension field in OF 1.3/1.4?

A similar question arises for EXT-382 encap/decap actions that are not even in OF 1.5 and would have to be modelled as experimenter actions.

We believe PTAP and EXT-382 can work in OF 1.3+, with the exception of Packet Out messages for non-Ethernet packets, which is likely uncritical.

> -----Original Message-----
> From: ovs-dev-bounces@openvswitch.org [mailto:ovs-dev-bounces@openvswitch.org] On Behalf Of Ben Pfaff
> Sent: Tuesday, 13 June, 2017 00:28
> To: dev@openvswitch.org
> Cc: Ben Pfaff <blp@ovn.org>
> Subject: [ovs-dev] [PATCH 02/31] fixup: packet_type originated in OpenFlow 1.5, not 1.3.
> 
> Signed-off-by: Ben Pfaff <blp@ovn.org>
> ---
>  include/openvswitch/meta-flow.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/include/openvswitch/meta-flow.h b/include/openvswitch/meta-flow.h
> index 3a17d7b0618e..fc109501d869 100644
> --- a/include/openvswitch/meta-flow.h
> +++ b/include/openvswitch/meta-flow.h
> @@ -255,7 +255,7 @@ enum OVS_PACKED_ENUM mf_field_id {
> 
>      /* "packet_type".
>       *
> -     * Define the packet type in OpenFlow 1.3+.
> +     * Define the packet type in OpenFlow 1.5+.
>       *
>       * Type: be32.
>       * Maskable: no.
> @@ -263,7 +263,7 @@ enum OVS_PACKED_ENUM mf_field_id {
>       * Prerequisites: none.
>       * Access: read-only.
>       * NXM: none.
> -     * OXM: OXM_OF_PACKET_TYPE(44) since OF1.3 and v2.8.
> +     * OXM: OXM_OF_PACKET_TYPE(44) since OF1.5 and v2.8.
>       */
>      MFF_PACKET_TYPE,
> 
> --
> 2.10.2
> 
> _______________________________________________
> dev mailing list
> dev@openvswitch.org
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev

This is not any kind of rejection.  Open vSwitch accepts any OXM as part
of a flow for any version of OpenFlow.  It is merely a correction to the
documentation.

On Wed, Jun 14, 2017 at 06:11:42PM +0000, Jan Scheurich wrote:
> Agree, packet type was introduced only in OF 1.5.
> 
> The intention with making packet type match field available from OF 1.3 was to allow SDN controllers to consume this functionality without having to implement the OF 1.5 wire protocol and (associated) the support of multiple OF versions in parallel. I believe that is a bigger hurdle for e.g. OpenDaylight.
> 
> Do you reject the support in OF 1.3 in general or just for the standard OXM point code? Would you except introduction support of packet type as experimenter extension field in OF 1.3/1.4?
> 
> A similar question arises for EXT-382 encap/decap actions that are not even in OF 1.5 and would have to be modelled as experimenter actions.
> 
> We believe PTAP and EXT-382 can work in OF 1.3+, with the exception of Packet Out messages for non-Ethernet packets, which is likely uncritical.
> 
> > -----Original Message-----
> > From: ovs-dev-bounces@openvswitch.org [mailto:ovs-dev-bounces@openvswitch.org] On Behalf Of Ben Pfaff
> > Sent: Tuesday, 13 June, 2017 00:28
> > To: dev@openvswitch.org
> > Cc: Ben Pfaff <blp@ovn.org>
> > Subject: [ovs-dev] [PATCH 02/31] fixup: packet_type originated in OpenFlow 1.5, not 1.3.
> > 
> > Signed-off-by: Ben Pfaff <blp@ovn.org>
> > ---
> >  include/openvswitch/meta-flow.h | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/include/openvswitch/meta-flow.h b/include/openvswitch/meta-flow.h
> > index 3a17d7b0618e..fc109501d869 100644
> > --- a/include/openvswitch/meta-flow.h
> > +++ b/include/openvswitch/meta-flow.h
> > @@ -255,7 +255,7 @@ enum OVS_PACKED_ENUM mf_field_id {
> > 
> >      /* "packet_type".
> >       *
> > -     * Define the packet type in OpenFlow 1.3+.
> > +     * Define the packet type in OpenFlow 1.5+.
> >       *
> >       * Type: be32.
> >       * Maskable: no.
> > @@ -263,7 +263,7 @@ enum OVS_PACKED_ENUM mf_field_id {
> >       * Prerequisites: none.
> >       * Access: read-only.
> >       * NXM: none.
> > -     * OXM: OXM_OF_PACKET_TYPE(44) since OF1.3 and v2.8.
> > +     * OXM: OXM_OF_PACKET_TYPE(44) since OF1.5 and v2.8.
> >       */
> >      MFF_PACKET_TYPE,
> > 
> > --
> > 2.10.2
> > 
> > _______________________________________________
> > dev mailing list
> > dev@openvswitch.org
> > https://mail.openvswitch.org/mailman/listinfo/ovs-dev