From patchwork Mon Jun 12 14:38:18 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: santosh X-Patchwork-Id: 774670 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3wmbBg6DFnz9s65 for ; Tue, 13 Jun 2017 00:39:23 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=CAVIUMNETWORKS.onmicrosoft.com header.i=@CAVIUMNETWORKS.onmicrosoft.com header.b="BPK5T7nk"; dkim-atps=neutral Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id B5114B5D; Mon, 12 Jun 2017 14:39:20 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@mail.linuxfoundation.org Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id 7E0BAB4B for ; Mon, 12 Jun 2017 14:39:19 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.7.6 Received: from NAM01-BY2-obe.outbound.protection.outlook.com (mail-by2nam01on0074.outbound.protection.outlook.com [104.47.34.74]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id 1BF321CC for ; Mon, 12 Jun 2017 14:39:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=LqN1rsCX71KE8ruTvXOOA5CfB/XlJvqNoirrbO+1ua8=; b=BPK5T7nkyLI0HbPln7FmN34CZ0BYGYyq4npldBDnhNWg1HyeyPxwS8wKd1AAVWBmJdbMSFMqQ+NU7FW7aqYZIEP7H+CRZJAasAaqcptFocsCxEv+7d6tyYU6ioecho+a9+J8SL4phwtX0iNIvLm3pfn0V2CPHhS8Z/M/no4CwA8= Authentication-Results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=caviumnetworks.com; Received: from localhost.localdomain (111.93.218.67) by CY4PR07MB3093.namprd07.prod.outlook.com (10.172.115.7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1157.12; Mon, 12 Jun 2017 14:39:13 +0000 From: Santosh Shukla To: ian.stokes@intel.com, blp@ovn.org, mark.b.kavanagh@intel.com, dball@vmware.com, dev@openvswitch.org Date: Mon, 12 Jun 2017 14:38:18 +0000 Message-Id: <20170612143819.1908-1-santosh.shukla@caviumnetworks.com> X-Mailer: git-send-email 2.13.0 In-Reply-To: <20170609070141.19541-1-santosh.shukla@caviumnetworks.com> References: <20170609070141.19541-1-santosh.shukla@caviumnetworks.com> MIME-Version: 1.0 X-Originating-IP: [111.93.218.67] X-ClientProxiedBy: PN1PR01CA0085.INDPRD01.PROD.OUTLOOK.COM (10.174.144.153) To CY4PR07MB3093.namprd07.prod.outlook.com (10.172.115.7) X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PR07MB3093: X-MS-Office365-Filtering-Correlation-Id: bbde2475-daa1-43c0-a752-08d4b1a0cd56 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(201703131423075)(201703031133081); SRVR:CY4PR07MB3093; X-Microsoft-Exchange-Diagnostics: 1; CY4PR07MB3093; 3:xdnw2EmKQo4N5XyIyD9rzGg0+kmFpUnIPTkJeRT+Yx7e/i1nsFvY+rYkYRbUOPtusBE0QNrCMdjySvVbqu12MTdlLB32xWjRzGtbCEHux4aYqBtku+ic+VDKbjBh4Jit2U8phg/7DZP8Y+uCRmjMM9tUvv/mYSrS5vPNasPUlmBsKUy4pC5dKfMab2KmkyQfJXJC9DcMLNTDOnzWkYO0AZB74uZUrO2XnUjv1L46AUVzQ2q2s/LMUbBX6VI8YCKiMiEBXFamOKe/1TF6ELet7svWO6vz0p0sgZmrtzppbk08vZuHiY4na11lQT9jb79Tvnoi2ve+r1DqLxHA036/lw==; 25:CZ6HA+TkhJaOca4yEoYkZJCZxTK8LEUIKHsaasfh8xRcG1QSWjk+WUnDVapeTeVWd1QsbDd2TwOmtW5zTICFGxMxBqzAQ1zZ54dvKFFl9FIv4hEh9UwJOgVO+V9ata7NLtsEQkotiVI2KBKO+8OhAoaoxFRg1ckDa3ZL4w1WKrCZ1xvoR3EY51Hj64bI88AF9bFmgtrXe+S7+iREVmYrkVX8xevrHoYw0+aUw3Ll1hFuY/81b7SWmGsPBOccsnmWgIZ0H5ezEY0Wkf9A56g1Lagb2AgQgANQscurQeoq/3CQ9yQmZJu2Jj0of3Flc+dvvunatILXXC/+C/hQ0cwEkGL7v7hvYsxZUhhWG9FZstpxJsT0lqQAgDQMMrDT4zKPtCNkKlXtEfyjmbAD2ZNtDT2qzrdVPtHIhiEhoz4uV5S1K8h1EUNBXZIZg2JFYrYL+pPjXSB+rY3TqdxM9ALu2xhEEmumf+6D4+1J6MOX6xM= X-Microsoft-Exchange-Diagnostics: 1; CY4PR07MB3093; 31:way40gqvK/tFg3Qhrgbv5dX4wmis9eVG7A8RwXkIC2VKrgBrvZE2gThoIKeOpUzE/dGhn8AWaZbPnKEf7oryTsNSQ5Z1pD2mVak5RYWOGKv8hvoOqxMSvFfep4TKRo3my33FWIo37lwjIbg0UpNdZMt21CNgA+ZNQavb4pEqbEx9NMA41KnbwFXshE5eTjNGJv0Zo3FXm81xiNfK4NUOLkf4danigeoDMR2FheZCwzM=; 20:+uA6ltBgkLTlokG/LDQdkKFQxVhTqQMgS7KWEGEkyROZSgzf/HgdF3yGreCDBxqyugJWC29lNyNqDNxukcW2/cbreQ5/RIXEJy23ybCf4gvMOKwAVb/CXkOu7tFLCGx2yv4c92OErecO++1JOcgS8pFGMYPtgC4SLozjCv7mAH1b7aCbR7L0FZoSkfMlcKBjfhg7udBhRIYC94PmrKL9E04tLep8B5YiumGr90k1LKpbOgGAaPgOHmc+sP7nQ4riXyYbAMLFYrYpD6fmUEaxMgpIy1j7XxhK3i86P+FYSUPAd7qTwVyz0ekAxHm5dMQrUbafnh0gWVjeqv3J7FmgLh1HgHEFRDSXT+lQCMssNhdhhzt+cPkaylOfrA6lPketvmSU8toI10vft5+Y/Nyeq7yM6qOsFbpujrW4O/4V+HysJ6kClmJaUhxp4lQpGdP4IhevY2wMNOH0Sv5mrmGylC54rNrnfop7SJTJgoDhxwinUohaiBbwU8qM6H5BTAWAQqCaKpuxQqcVs4yb5/sVe8Vx292JkXJMEibT1RJp8fkLcnx/UY0BUjZGeryT9gA2rXDa7ZMnEVQt12HSWU5njD51eYhMM0bW+tomOP2DtZY= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(228905959029699); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(8121501046)(5005006)(93006095)(3002001)(10201501046)(100000703101)(100105400095)(6041248)(20161123564025)(20161123562025)(20161123555025)(20161123558100)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(6072148)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:CY4PR07MB3093; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:CY4PR07MB3093; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; CY4PR07MB3093; 4:5ED5tOD5/4crl9EeB2Z1qtQJimLusxmE12taYqqPRh?= =?us-ascii?Q?hCFK0pNas/s8e2Rb9jQ6ZiBpuxlC20TAfsg8ECZ/HC6kmdrUBp3FQOz5QfGJ?= =?us-ascii?Q?4U/r57drzkOCHPTKBvDp5O9kR5iDh2HPZGKgEOiQskPkelVJVOi19tZ8BcDA?= =?us-ascii?Q?9o4dK/uPXN/OyAy3uuy6PvPcZrC6/uIUBMxrg4H8D461tF65q2hieIRPOETw?= =?us-ascii?Q?yRG3don0W66kqqghSW8ZgRLKNAq3JvIztJSJQi8yEuxi6tm6FyzoSDvla9bi?= =?us-ascii?Q?o5Fm9zgzgSNPXdPMSDTyP7PqZjXbZe7K0v/AfDQtPrnfEUO1kUaB3+4D151K?= =?us-ascii?Q?d7xJP4OwS/hIXYNNkJIObu3FtVg9m64XQbZRMbvNhJ39gMnzPwt72VBblf+R?= =?us-ascii?Q?bMjFpIkYcQAixZPywbrQYeGgFitPq/u1pISMNZkUoGr5aAX/aqUbWFH4ngGk?= =?us-ascii?Q?BfSxXIdgK13Zb5L5Hdm0AUuNq6nFQGtZsRKx8u4VcdzRjdpA4AJmNB8Wf00p?= =?us-ascii?Q?SAv9/0YMWcG9h5pOlb+5GWiyvwt80JdYFtR1nEWQqiM1EMoYEuW/eAK7EhFT?= =?us-ascii?Q?yKR70e2b7oPWNcrBFBQUEOEn6HVEo8tfSYr8qZm2AuFriBXyB6/fL6nWTYFt?= =?us-ascii?Q?7H+PgTO2FFc3ISrCpgVJJTgq9ubL3XG6CRyUu1MqKuJmIzeJ7EXDbMvZeld3?= =?us-ascii?Q?931bgdsZeFClYKvZLMr249tamsVDmB3L6IZjrN1Ky/8ymSBypPLCCC+J3tKe?= =?us-ascii?Q?xeG6gJlc5v0nPHAL10yvZFl33NtIAQo/nIJ7cbZRbMjsMSYBALcDLfLQ1CPG?= =?us-ascii?Q?jNA9KOGD0ZFJcGCfPA+PzU4xaeAMTlg+H/E2cHvEgJNrLP2BYwZB6AKWLLCj?= =?us-ascii?Q?08ut/VA3dEgcVF4e34bKybVum/+h0o8rXEk9Voq72Dux001srmRTYJ+egI0M?= =?us-ascii?Q?jL6M+3Qp9E4FQq5F1zLqqEeXhv13BTxFPW+OaJLOwu+YA09TpALkeslRp4A/?= =?us-ascii?Q?5u3ItFeCcIRYnQrCzbbnxMNcyU9TGdzTOHAU2jH54JiHQBsj/kOhf4Z4IzdV?= =?us-ascii?Q?QzN5C07WfSOsrxyWP8RSMbvSBKMeQ/UvA2WdFXlsqrLwcqt34gNCG3C5JYKM?= =?us-ascii?Q?e9nmZVgWNG+cePmegqTt3Su1N80yjqY9cv3V/cFApCwdWdzXNhvw=3D=3D?= X-Forefront-PRVS: 03361FCC43 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(6009001)(6069001)(39410400002)(39840400002)(39850400002)(39450400003)(39400400002)(53936002)(25786009)(8676002)(305945005)(7736002)(33646002)(107886003)(110136004)(76176999)(50986999)(1076002)(47776003)(2950100002)(42882006)(5009440100003)(48376002)(50226002)(6506006)(6486002)(66066001)(42186005)(6306002)(6512007)(81166006)(8656002)(5660300001)(4326008)(72206003)(5003940100001)(36756003)(478600001)(966005)(2906002)(189998001)(38730400002)(3846002); DIR:OUT; SFP:1101; SCL:1; SRVR:CY4PR07MB3093; H:localhost.localdomain; FPR:; SPF:None; MLV:sfv; LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; CY4PR07MB3093; 23:QfvDPZ3AqIRQAA1bLizPC4unhm208VTLLu/SPMbDK?= =?us-ascii?Q?7AG8b7vCZ5hr8Er/16F5PW0dTmRUBYyhkIctSTigyj4hJ3emIFcnuu+/4OUg?= =?us-ascii?Q?4h3A4LS4pcWNKCaDYNxHGNbEx2Y4BwN08cuJmkEsrNyE1Yf8eUSAUOYcgFlP?= =?us-ascii?Q?oWavBbKixv8kMb69gqPnuu49/3HdPkCD76g4avyyx52IORCVIYErUa7eFEcs?= =?us-ascii?Q?6LKuGv1aTY3r+JFgUWW3UNSgJz2dq9ozQCCLrOAegoAD6h7CqtP+Fw6MXZe3?= =?us-ascii?Q?wCVJmMtY+c+NBc50s/I7PP+N6sPKpDHIqdJxDTWjwwMI0e8ptYl/Zrjfwtlu?= =?us-ascii?Q?vU0ilfseVNjP1ab6kP5DbBTCZD+Ix1l/QSmrbYxLC2bxQQ+sbLAXWvNau3/U?= =?us-ascii?Q?B2ZY2xoxiA8zn6N4l0MS/Kxp6tvHoVNiYyneU+3W50fVAPGU4IBtt6knOZeT?= =?us-ascii?Q?B9Cg7Oa6aqgyrLUThYLb8aXCS1fzVYJNoL0tG5h+Ir8HOD6zkltWms3BXL0j?= =?us-ascii?Q?erOQOusYawKJ5oA7Aj2JU83FxiEoiVsx1iESh202C/QSe78B9S+Z1BehrnXc?= =?us-ascii?Q?8f2fx54AutNielB2czNGApXpcZpLwpuRJJ1dfxm5YWqb07u6cJ3PiZFYI8l2?= =?us-ascii?Q?HktLpVeVcJ24xFutW++Ep8qsS16fLw3dVndZHaAWlv/dUtr8ju9gZVvC+HU7?= =?us-ascii?Q?LQj/stijp6coKF0dGuav0ybS/qgVIHttRLGElyBBT0gQX1YHCeh53IPeanJf?= =?us-ascii?Q?SUC0RZ+JY8LDy7SYjgajBIy14gKiCQhe6MIX7Tqzn2f6hjhpAmuJfbQjEO2X?= =?us-ascii?Q?9KToxoNK6XbQasxE6w/Fo618YaFoW8ysXNhboZgk9S84Nx6kwoVZAffNWc+1?= =?us-ascii?Q?uTOR3DGLY4YU5bVFpI2+J6ySrtBAypqPVNh+83Js/JiCO6UBFlzYtdb3qy7+?= =?us-ascii?Q?+ixGkLU+YGIWtLKceDIEYdoPWBSAoxe1/w9UAoPiNyUoEAbWVYyR3zZwbBek?= =?us-ascii?Q?qlHaG3ZoDsBnP300jdmF1rhZXPmpY6BbmGK7LGJTllp0iFB5xIlo/XSdV7ob?= =?us-ascii?Q?HMVwUh0B62TyFE5d8zuIGPTyfhJej7ynaqK9z+BIXqKTzaxbRaHvZPiDbsGb?= =?us-ascii?Q?JDxw79m5S4=3D?= X-Microsoft-Exchange-Diagnostics: 1; CY4PR07MB3093; 6:CLEKdBtP578zQ9a5dmaORtdcFoW+KnhBuVjWyY5xuFyJ+j0uoq46yQYML4DkVGT6r48ywaXHru68Ij0nmKJqqrzR45iWaRuPXnjp2Y+ZXXqdNa/2pjsgMjgnNcrwbfygLxSfdnlOScXFxdssyCsUaMvqaGthvJNNzfroX1QAu+2/XxhXmUe2wfdXp5sYE6+9Q+MCqlQAuKuAX9jnBlY8cmNt5ZoK/KKJT3FU1SwBKSeDmvHEUJlc0bhAzHj95+qBmbDbBFURR8F8JF0NucWTVWcS7OU98tftUK17L7jPhGWSIw2j3ITtrmoRlkoNH14f8RSvzFksaKmtTIp12rgzqNhElX70eGQ+CGrswho+5YXfU7HqaWEZ2ihewz4n7E3gUbMWp1HVWovxdybU+4Kvw/CHhR1h+q8Z8L3XSXPbfEQxFJiAplyn/VKkQfQ4oPPsunKFI0TzXS99024oTFCzV9HLklKh/CjiKw6AzoQR7I6S9XZ09pnMzIYHviA4yBO6YU3aRvXR9HHU34I8YWWqyw== X-Microsoft-Exchange-Diagnostics: 1; CY4PR07MB3093; 5:FpzW9T6n9rDNXyHw5fSXhDC75zQhHs1rUuR11V91MCtUYENBSXXnkSxLIDyb7huwFNOmWoV5C0HaDul7SCewc3go4GTmwJ3Zhmjsa1XJNL+gQdiSUOJAYEsgAtZxDPqD0BiLvNCGOIuLhlARvUghCHpP6BrbtcG3eismWq1BRHTnyMlGkzyw3fx0Ch4A1tcqmNjivmzte25+JgVXX+4guhPBRMqYeAmWnu0/nSw0SgrGIe8Yq0uM758SYQ5N2hFdUc+oSEW6x6vtMkTmREQDTaFyJK6xo02fB28fuq/FQYVJcAgEyzSsWeUkjJVK7sK9b87cN3iHPEe9FHalgZd1TTqArltNP0vwwh7Wa8p0YGOI5ZlmzLNx6saqyS1LBB2Y+ExoFAY92EKEi629pHHzz9vriKWEFFbqBwSmsjRYt7edW/XvbptRP/DyP8d4onRVcogzdkeSVUkwFVa6deaygEvDI3N3Wn9wenZMPIib4c0n0+ffVnpJOTgMNdQSoNTl; 24:YdfH/bFACVDu8uYiCLpdUIG5I+PvoHEOtUGGHGlUF9xgHTieHQanrn9nVq86kD6RGcFLsp+0PdP4vEFbiqgdDSUokKvnAbGv/1iAn/DDhS4= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; CY4PR07MB3093; 7:6gTY1wr1efoKNK167n1VHxo5r9JYE+yceeTTWyCehbeoMwzPwMDXSPMRCIXv/byoxmk7NDE27ge3fkOivUVGgfau6uSSzKvFjRa2RFEKxJGJJToPUs3V/sDRHj7c3hbAGDKKOvqRIVo9a/wacRiKG5FqKS4qFgZslnn+fw5SnUSqw1AdB4u3gKgGObrGf4Jn/iouG01vcpqzwE7Uqha/vj5q66ntOQLz6Fk/On76wRK+X6AUmpSYCJL43Fy2QX54D6j2xiQSU8i9FPAedpzJ1ZdoAjnNYApJOGupeLUr62n08Kg8zdXpL6e4h7wbOUb9+5OE7PLAjAntMkw48KYvYA== X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jun 2017 14:39:13.4629 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR07MB3093 X-Spam-Status: No, score=-0.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, RCVD_IN_DNSWL_NONE, RCVD_IN_SORBS_WEB autolearn=no version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on smtp1.linux-foundation.org Cc: jerin.jacob@caviumnetworks.com Subject: [ovs-dev] [PATCH v3] netdev-dpdk: round up mbuf_size to cache_line_size X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: ovs-dev-bounces@openvswitch.org Errors-To: ovs-dev-bounces@openvswitch.org Some pmd driver(e.g: vNIC thunderx PMD) want mbuf_size to be multiple of cache_line_size. With out this fix, Netdev-dpdk initialization would fail for those PMD. Signed-off-by: Santosh Shukla Acked-by: Mark Kavanagh Tested-by: Mark Kavanagh Acked-by: Ian Stokes --- v1 --> v2 - Removed mtu to dmp->mtu change in v2. - Removed extra MTU macro definition (_MBUF_SIZE) in v2. Now MBUF_SIZE looks after the round_up. - For details refer v1 [1]. [1] https://patchwork.ozlabs.org/patch/769113/ v2 --> v3 - Included Ian tag. For more info refer v2 [2] [2] https://patchwork.ozlabs.org/patch/773693/ lib/netdev-dpdk.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c index 810800ed3..023880ca6 100644 --- a/lib/netdev-dpdk.c +++ b/lib/netdev-dpdk.c @@ -76,9 +76,10 @@ static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(5, 20); #define MTU_TO_MAX_FRAME_LEN(mtu) ((mtu) + ETHER_HDR_MAX_LEN) #define FRAME_LEN_TO_MTU(frame_len) ((frame_len) \ - ETHER_HDR_LEN - ETHER_CRC_LEN) -#define MBUF_SIZE(mtu) (MTU_TO_MAX_FRAME_LEN(mtu) \ - + sizeof(struct dp_packet) \ - + RTE_PKTMBUF_HEADROOM) +#define MBUF_SIZE(mtu) ROUND_UP((MTU_TO_MAX_FRAME_LEN(mtu) \ + + sizeof(struct dp_packet) \ + + RTE_PKTMBUF_HEADROOM), \ + RTE_CACHE_LINE_SIZE) #define NETDEV_DPDK_MBUF_ALIGN 1024 #define NETDEV_DPDK_MAX_PKT_LEN 9728