| Message ID | 20170517135450.6336-1-aserdean@cloudbasesolutions.com |
|---|---|
| State | Accepted |
| Headers | show |
Thanks for identifying and fixing this. Acked-by: Anand Kumar <kumaranand@vmware.com> Regards, Anand Kumar On 5/17/17, 6:54 AM, "ovs-dev-bounces@openvswitch.org on behalf of Alin Serdean" <ovs-dev-bounces@openvswitch.org on behalf of aserdean@cloudbasesolutions.com> wrote: Found using static analysis tools. Signed-off-by: Alin Gabriel Serdean <aserdean@cloudbasesolutions.com> --- datapath-windows/ovsext/IpFragment.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/datapath-windows/ovsext/IpFragment.c b/datapath-windows/ovsext/IpFragment.c index 675c32e..0874cb9 100644 --- a/datapath-windows/ovsext/IpFragment.c +++ b/datapath-windows/ovsext/IpFragment.c @@ -343,7 +343,7 @@ OvsProcessIpv4Fragment(POVS_SWITCH_CONTEXT switchContext, } POVS_FRAGMENT_LIST next = entry->head; POVS_FRAGMENT_LIST prev = entry->tail; - if (prev != NULL || prev->offset < offset) { + if (prev != NULL && prev->offset < offset) { next = NULL; goto found; } -- 2.10.2.windows.1 _______________________________________________ dev mailing list dev@openvswitch.org https://urldefense.proofpoint.com/v2/url?u=https-3A__mail.openvswitch.org_mailman_listinfo_ovs-2Ddev&d=DwICAg&c=uilaK90D4TOVoH58JNXRgQ&r=Q5z9tBe-nAOpE7LIHSPV8uy5-437agMXvkeHHMkR8Us&m=CWdGnCwQAqL4DBYA2RcH6SVyKhJMwEh0s9_AwzmByns&s=oNiDelVhtnHmgoVawTP5ysWACw1yvHXAtTxiQ-A6KnU&e=
On 17 May 2017 at 06:54, Alin Serdean <aserdean@cloudbasesolutions.com> wrote: > Found using static analysis tools. > > Signed-off-by: Alin Gabriel Serdean <aserdean@cloudbasesolutions.com> > Applied, thanks! > --- > datapath-windows/ovsext/IpFragment.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/datapath-windows/ovsext/IpFragment.c > b/datapath-windows/ovsext/IpFragment.c > index 675c32e..0874cb9 100644 > --- a/datapath-windows/ovsext/IpFragment.c > +++ b/datapath-windows/ovsext/IpFragment.c > @@ -343,7 +343,7 @@ OvsProcessIpv4Fragment(POVS_SWITCH_CONTEXT > switchContext, > } > POVS_FRAGMENT_LIST next = entry->head; > POVS_FRAGMENT_LIST prev = entry->tail; > - if (prev != NULL || prev->offset < offset) { > + if (prev != NULL && prev->offset < offset) { > next = NULL; > goto found; > } > -- > 2.10.2.windows.1 > _______________________________________________ > dev mailing list > dev@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev >
diff --git a/datapath-windows/ovsext/IpFragment.c b/datapath-windows/ovsext/IpFragment.c index 675c32e..0874cb9 100644 --- a/datapath-windows/ovsext/IpFragment.c +++ b/datapath-windows/ovsext/IpFragment.c @@ -343,7 +343,7 @@ OvsProcessIpv4Fragment(POVS_SWITCH_CONTEXT switchContext, } POVS_FRAGMENT_LIST next = entry->head; POVS_FRAGMENT_LIST prev = entry->tail; - if (prev != NULL || prev->offset < offset) { + if (prev != NULL && prev->offset < offset) { next = NULL; goto found; }
Found using static analysis tools. Signed-off-by: Alin Gabriel Serdean <aserdean@cloudbasesolutions.com> --- datapath-windows/ovsext/IpFragment.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)