diff mbox

[ovs-dev] datapath-windows: Update the key after defragmentation

Message ID 20170517134934.4476-1-aserdean@cloudbasesolutions.com
State Accepted
Headers show

Commit Message

Alin Serdean May 17, 2017, 1:49 p.m. UTC
Update the key used by the actions which follow up defragmentation, with
no fragment set in the IP header.

Found while testing OVN with two VMs on the same host.

Signed-off-by: Alin Gabriel Serdean <aserdean@cloudbasesolutions.com>
---
 datapath-windows/ovsext/Actions.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Anand Kumar May 17, 2017, 6:31 p.m. UTC | #1
Acked-by: Anand Kumar kumaranand@vmware.com

Thanks,
Anand Kumar

On 5/17/17, 6:49 AM, "ovs-dev-bounces@openvswitch.org on behalf of Alin Serdean" <ovs-dev-bounces@openvswitch.org on behalf of aserdean@cloudbasesolutions.com> wrote:

    Update the key used by the actions which follow up defragmentation, with
    no fragment set in the IP header.
    
    Found while testing OVN with two VMs on the same host.
    
    Signed-off-by: Alin Gabriel Serdean <aserdean@cloudbasesolutions.com>
    ---
     datapath-windows/ovsext/Actions.c | 1 +
     1 file changed, 1 insertion(+)
    
    diff --git a/datapath-windows/ovsext/Actions.c b/datapath-windows/ovsext/Actions.c
    index 31b4514..c3f0362 100644
    --- a/datapath-windows/ovsext/Actions.c
    +++ b/datapath-windows/ovsext/Actions.c
    @@ -2052,6 +2052,7 @@ OvsDoExecuteActions(POVS_SWITCH_CONTEXT switchContext,
                                          NET_BUFFER_LIST_SWITCH_FORWARDING_DETAIL(ovsFwdCtx.curNbl),
                                          ovsFwdCtx.completionList,
                                          &ovsFwdCtx.layers, FALSE);
    +                key->ipKey.nwFrag = OVS_FRAG_TYPE_NONE;
                 }
                 break;
             }
    -- 
    2.10.2.windows.1
    _______________________________________________
    dev mailing list
    dev@openvswitch.org
    https://urldefense.proofpoint.com/v2/url?u=https-3A__mail.openvswitch.org_mailman_listinfo_ovs-2Ddev&d=DwICAg&c=uilaK90D4TOVoH58JNXRgQ&r=Q5z9tBe-nAOpE7LIHSPV8uy5-437agMXvkeHHMkR8Us&m=oirVwU1t-01D6SSv7OmCQFD8r2FB7Ao2Nn0HV6ydu5E&s=9TihOd-FPgWRz7fhTe9WyqLiuREPZwz8UOz7ai2KCLQ&e=
Gurucharan Shetty May 23, 2017, 10:29 p.m. UTC | #2
On 17 May 2017 at 06:49, Alin Serdean <aserdean@cloudbasesolutions.com>
wrote:

> Update the key used by the actions which follow up defragmentation, with
> no fragment set in the IP header.
>
> Found while testing OVN with two VMs on the same host.
>
> Signed-off-by: Alin Gabriel Serdean <aserdean@cloudbasesolutions.com>
>

Thanks, applied!

> ---
>  datapath-windows/ovsext/Actions.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/datapath-windows/ovsext/Actions.c b/datapath-windows/ovsext/
> Actions.c
> index 31b4514..c3f0362 100644
> --- a/datapath-windows/ovsext/Actions.c
> +++ b/datapath-windows/ovsext/Actions.c
> @@ -2052,6 +2052,7 @@ OvsDoExecuteActions(POVS_SWITCH_CONTEXT
> switchContext,
>                                       NET_BUFFER_LIST_SWITCH_
> FORWARDING_DETAIL(ovsFwdCtx.curNbl),
>                                       ovsFwdCtx.completionList,
>                                       &ovsFwdCtx.layers, FALSE);
> +                key->ipKey.nwFrag = OVS_FRAG_TYPE_NONE;
>              }
>              break;
>          }
> --
> 2.10.2.windows.1
> _______________________________________________
> dev mailing list
> dev@openvswitch.org
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
>
diff mbox

Patch

diff --git a/datapath-windows/ovsext/Actions.c b/datapath-windows/ovsext/Actions.c
index 31b4514..c3f0362 100644
--- a/datapath-windows/ovsext/Actions.c
+++ b/datapath-windows/ovsext/Actions.c
@@ -2052,6 +2052,7 @@  OvsDoExecuteActions(POVS_SWITCH_CONTEXT switchContext,
                                      NET_BUFFER_LIST_SWITCH_FORWARDING_DETAIL(ovsFwdCtx.curNbl),
                                      ovsFwdCtx.completionList,
                                      &ovsFwdCtx.layers, FALSE);
+                key->ipKey.nwFrag = OVS_FRAG_TYPE_NONE;
             }
             break;
         }