| Message ID | 20170501195807.31051-2-joe@ovn.org |
|---|---|
| State | Accepted |
| Headers | show |
Acked-by: Jarno Rajahalme <jarno@ovn.org> > On May 1, 2017, at 12:58 PM, Joe Stringer <joe@ovn.org> wrote: > > This was being logged using xlate_strerror(), but the return code is > actually an errno code. Use ovs_strerror() instead. > > Fixes: dd0dc9eda0e0 ("revalidator: Reuse xlate_ukey from deletion.") > Signed-off-by: Joe Stringer <joe@ovn.org> > --- > ofproto/ofproto-dpif-upcall.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/ofproto/ofproto-dpif-upcall.c b/ofproto/ofproto-dpif-upcall.c > index 2e23fe702281..21916731fa07 100644 > --- a/ofproto/ofproto-dpif-upcall.c > +++ b/ofproto/ofproto-dpif-upcall.c > @@ -2217,8 +2217,8 @@ push_dp_ops(struct udpif *udpif, struct ukey_op *ops, size_t n_ops) > if (error) { > static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(1, 5); > > - VLOG_WARN_RL(&rl, "xlate_actions failed (%s)!", > - xlate_strerror(error)); > + VLOG_WARN_RL(&rl, "xlate_key failed (%s)!", > + ovs_strerror(error)); > } else { > xlate_out_uninit(&ctx.xout); > if (netflow) { > -- > 2.11.1 >
On 1 May 2017 at 13:05, Jarno Rajahalme <jarno@ovn.org> wrote:
> Acked-by: Jarno Rajahalme <jarno@ovn.org>
Thanks, applied to master and branch-2.7.
diff --git a/ofproto/ofproto-dpif-upcall.c b/ofproto/ofproto-dpif-upcall.c index 2e23fe702281..21916731fa07 100644 --- a/ofproto/ofproto-dpif-upcall.c +++ b/ofproto/ofproto-dpif-upcall.c @@ -2217,8 +2217,8 @@ push_dp_ops(struct udpif *udpif, struct ukey_op *ops, size_t n_ops) if (error) { static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(1, 5); - VLOG_WARN_RL(&rl, "xlate_actions failed (%s)!", - xlate_strerror(error)); + VLOG_WARN_RL(&rl, "xlate_key failed (%s)!", + ovs_strerror(error)); } else { xlate_out_uninit(&ctx.xout); if (netflow) {
This was being logged using xlate_strerror(), but the return code is actually an errno code. Use ovs_strerror() instead. Fixes: dd0dc9eda0e0 ("revalidator: Reuse xlate_ukey from deletion.") Signed-off-by: Joe Stringer <joe@ovn.org> --- ofproto/ofproto-dpif-upcall.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)