diff mbox

[ovs-dev] ovsdb: Expose openvswitch run directory through ovsdb

Message ID 20170309113911.GA8570@debian
State Superseded
Headers show

Commit Message

Robert Wojciechowicz March 9, 2017, 11:39 a.m. UTC 
On Wed, Mar 08, 2017 at 09:31:22PM -0800, Ben Pfaff wrote:
> On Thu, Mar 02, 2017 at 02:40:19PM +0000, Robert Wojciechowicz wrote:
> > When using vhost-user client or server mode with openstack,
> > neutron needs to be able to construct the fully qualified socket path
> > and pass it to nova.
> > While the relative vhost-user socket directory is exposed via
> > the `Open_vSwitch` table (other_config:vhost-sock-dir),
> > the openvswith run directory is not.
> > As the full socket path is the combination of the openvswitch run
> > directory + relative vhost-user socket dir + interface name without
> > exposing the run directory the full path cannot be calculated.
> > Since `external_ids` column is meant for storing
> > key-value pairs for use by external frameworks that integrate
> > with Open vSwitch it is a perfect place for exposing OVS
> > run directory.
> > So this patch adds to the `Open_vSwitch` table `external_ids` column
> > this key:
> > 1. ovs-run-dir    - OVS run directory
> > 
> > Signed-off-by: Robert Wojciechowicz <robertx.wojciechowicz@intel.com>
> > Acked-by: Sean K Mooney <sean.k.mooney@intel.com>
> 
> Please add documentation for this in the Open_vSwitch table in
> vswitch.xml.

Maybe something like that:



Should I resend the complete patch again?

Br,
Robert
diff mbox

Patch

diff --git a/vswitchd/vswitch.xml b/vswitchd/vswitch.xml
index 782417f..43a94e4 100644
--- a/vswitchd/vswitch.xml
+++ b/vswitchd/vswitch.xml
@@ -77,6 +77,10 @@ 
         qualified domain name since version 2.6.2.
       </column>

+      <column name="external_ids" key="ovs-run-dir">
+        The run directory of the running Open vSwitch daemon.
+      </column>
+
       <column name="other_config" key="stats-update-interval"
               type='{"type": "integer", "minInteger": 5000}'>
         <p>