| Message ID | 20170308002953.13453-1-blp@ovn.org |
|---|---|
| State | Accepted |
| Headers | show |
Hi Ben, On 03/08/2017 12:29 AM, Ben Pfaff wrote: > This would have found a .gitignore file recently added to the distribution. > > CC: Markos Chandras <mchandras@suse.de> > CC: Alin Gabriel Serdean <aserdean@cloudbasesolutions.com> > Signed-off-by: Ben Pfaff <blp@ovn.org> > --- Looks reasonable to me. Thank you Reviewed-by: Markos Chandras <mchandras@suse.de>
On Wed, Mar 08, 2017 at 12:33:47AM +0000, Markos Chandras wrote: > Hi Ben, > > On 03/08/2017 12:29 AM, Ben Pfaff wrote: > > This would have found a .gitignore file recently added to the distribution. > > > > CC: Markos Chandras <mchandras@suse.de> > > CC: Alin Gabriel Serdean <aserdean@cloudbasesolutions.com> > > Signed-off-by: Ben Pfaff <blp@ovn.org> > > --- > > Looks reasonable to me. Thank you > > Reviewed-by: Markos Chandras <mchandras@suse.de> Thanks! I applied this to master.
diff --git a/Makefile.am b/Makefile.am index cdf42d3ad244..90f5c0353811 100644 --- a/Makefile.am +++ b/Makefile.am @@ -1,4 +1,4 @@ -# Copyright (C) 2007-2016 Nicira, Inc. +# Copyright (C) 2007-2017 Nicira, Inc. # # Copying and distribution of this file, with or without modification, # are permitted in any medium without royalty provided the copyright @@ -203,6 +203,11 @@ dist-hook-git: distfiles cat missing-distfiles; \ exit 1; \ fi; \ + if LC_ALL=C grep '\.gitignore$$' all-distfiles; then \ + echo "See above for list of files that are distributed but"; \ + echo "should not be."; \ + exit 1; \ + fi \ fi CLEANFILES += all-distfiles all-gitfiles missing-distfiles # The following is based on commands for the Automake "distdir" target.
This would have found a .gitignore file recently added to the distribution. CC: Markos Chandras <mchandras@suse.de> CC: Alin Gabriel Serdean <aserdean@cloudbasesolutions.com> Signed-off-by: Ben Pfaff <blp@ovn.org> --- Makefile.am | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)