| Message ID | 20170307161608.32133-1-russell@ovn.org |
|---|---|
| State | Accepted |
| Headers | show |
On Tue, Mar 07, 2017 at 11:16:08AM -0500, Russell Bryant wrote: > OpenStack CI is currently failing due to some flake8 warnings > emitted from the flake8-import-order plugin. Just ignore all of > those warnings since they're just style things that aren't important. > > Signed-off-by: Russell Bryant <russell@ovn.org> I didn't test this but it sounds reasonable to me. Fuck style. Acked-by: Ben Pfaff <blp@ovn.org>
On Tue, Mar 7, 2017 at 1:57 PM, Ben Pfaff <blp@ovn.org> wrote: > On Tue, Mar 07, 2017 at 11:16:08AM -0500, Russell Bryant wrote: > > OpenStack CI is currently failing due to some flake8 warnings > > emitted from the flake8-import-order plugin. Just ignore all of > > those warnings since they're just style things that aren't important. > > > > Signed-off-by: Russell Bryant <russell@ovn.org> > > I didn't test this but it sounds reasonable to me. Fuck style. > > Acked-by: Ben Pfaff <blp@ovn.org> > Thanks! I applied this to master and branch-2.7. I'll have another patch to delete the coding guidelines document shortly.
On Tue, Mar 07, 2017 at 02:50:41PM -0500, Russell Bryant wrote: > On Tue, Mar 7, 2017 at 1:57 PM, Ben Pfaff <blp@ovn.org> wrote: > > > On Tue, Mar 07, 2017 at 11:16:08AM -0500, Russell Bryant wrote: > > > OpenStack CI is currently failing due to some flake8 warnings > > > emitted from the flake8-import-order plugin. Just ignore all of > > > those warnings since they're just style things that aren't important. > > > > > > Signed-off-by: Russell Bryant <russell@ovn.org> > > > > I didn't test this but it sounds reasonable to me. Fuck style. > > > > Acked-by: Ben Pfaff <blp@ovn.org> > > > > Thanks! I applied this to master and branch-2.7. > > I'll have another patch to delete the coding guidelines document shortly. Hahaha.
diff --git a/Makefile.am b/Makefile.am index a4dd7b8..cdf42d3 100644 --- a/Makefile.am +++ b/Makefile.am @@ -350,7 +350,7 @@ ALL_LOCAL += flake8-check # H233 Python 3.x incompatible use of print operator # H238 old style class declaration, use new style (inherit from `object`) FLAKE8_SELECT = H231,H232,H233,H238 -FLAKE8_IGNORE = E121,E123,E125,E126,E127,E128,E129,E131,W503,F811,D,H +FLAKE8_IGNORE = E121,E123,E125,E126,E127,E128,E129,E131,W503,F811,D,H,I flake8-check: $(FLAKE8_PYFILES) $(AM_V_GEN) \ src='$^' && \
OpenStack CI is currently failing due to some flake8 warnings emitted from the flake8-import-order plugin. Just ignore all of those warnings since they're just style things that aren't important. Signed-off-by: Russell Bryant <russell@ovn.org> --- Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)