diff mbox

[ovs-dev,2/4] configure: Use -Wformat-security with -Wformat.

Message ID 20161205223853.29234-2-blp@ovn.org
State Accepted
Headers show

Commit Message

Ben Pfaff Dec. 5, 2016, 10:38 p.m. UTC 
GCC 6.1 warns that -Wformat-security has no effect without -Wformat, so
this commit fixes the problem.

The change to _OVS_CHECK_CC_OPTION is needed so that the cache variable
name doesn't end up with a space in it, which obviously doesn't work.

Signed-off-by: Ben Pfaff <blp@ovn.org>
---
 acinclude.m4 | 2 +-
 configure.ac | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

Comments

Andy Zhou Dec. 7, 2016, 2:08 a.m. UTC | #1 
On Mon, Dec 5, 2016 at 2:38 PM, Ben Pfaff <blp@ovn.org> wrote:

> GCC 6.1 warns that -Wformat-security has no effect without -Wformat, so
> this commit fixes the problem.
>
> The change to _OVS_CHECK_CC_OPTION is needed so that the cache variable
> name doesn't end up with a space in it, which obviously doesn't work.
>
> Signed-off-by: Ben Pfaff <blp@ovn.org>
>

 Acked-by: Andy Zhou <azhou@ovn.org>
diff mbox

Patch

diff --git a/acinclude.m4 b/acinclude.m4
index d253dee..5dcc20f 100644
--- a/acinclude.m4
+++ b/acinclude.m4
@@ -768,7 +768,7 @@  dnl gives unlimited permission to copy and/or distribute it,
 dnl with or without modifications, as long as this notice is preserved.
 
 AC_DEFUN([_OVS_CHECK_CC_OPTION], [dnl
-  m4_define([ovs_cv_name], [ovs_cv_[]m4_translit([$1], [-=], [__])])dnl
+  m4_define([ovs_cv_name], [ovs_cv_[]m4_translit([$1], [-= ], [__])])dnl
   AC_CACHE_CHECK([whether $CC accepts $1], [ovs_cv_name], 
     [ovs_save_CFLAGS="$CFLAGS"
      dnl Include -Werror in the compiler options, because without -Werror
diff --git a/configure.ac b/configure.ac
index 2f854dd..ece6bf3 100644
--- a/configure.ac
+++ b/configure.ac
@@ -1,4 +1,4 @@ 
-# Copyright (c) 2008, 2009, 2010, 2011, 2012, 2013, 2014, 2015 Nicira, Inc.
+# Copyright (c) 2008, 2009, 2010, 2011, 2012, 2013, 2014, 2015, 2016 Nicira, Inc.
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
 # you may not use this file except in compliance with the License.
@@ -147,7 +147,7 @@  OVS_ENABLE_OPTION([-Wall])
 OVS_ENABLE_OPTION([-Wextra])
 OVS_ENABLE_OPTION([-Wno-sign-compare])
 OVS_ENABLE_OPTION([-Wpointer-arith])
-OVS_ENABLE_OPTION([-Wformat-security])
+OVS_ENABLE_OPTION([-Wformat -Wformat-security])
 OVS_ENABLE_OPTION([-Wswitch-enum])
 OVS_ENABLE_OPTION([-Wunused-parameter])
 OVS_ENABLE_OPTION([-Wbad-function-cast])