From patchwork Fri Nov 11 02:39:26 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Russell Bryant X-Patchwork-Id: 693531 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3tFPJY0yl6z9t1F for ; Fri, 11 Nov 2016 13:39:39 +1100 (AEDT) Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id E12D5C74; Fri, 11 Nov 2016 02:39:35 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@mail.linuxfoundation.org Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id 8E55BC66 for ; Fri, 11 Nov 2016 02:39:34 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id 12030196 for ; Fri, 11 Nov 2016 02:39:33 +0000 (UTC) Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 80CB73B712; Fri, 11 Nov 2016 02:39:33 +0000 (UTC) Received: from t460s.redhat.com (ovpn-112-20.phx2.redhat.com [10.3.112.20]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id uAB2dU8O012426; Thu, 10 Nov 2016 21:39:32 -0500 From: Russell Bryant To: dev@openvswitch.org Date: Thu, 10 Nov 2016 21:39:26 -0500 Message-Id: <20161111023926.23597-1-russell@ovn.org> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Fri, 11 Nov 2016 02:39:33 +0000 (UTC) X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on smtp1.linux-foundation.org Subject: [ovs-dev] [PATCH] ovn-trace: Note that no match means drop. X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: ovs-dev-bounces@openvswitch.org Errors-To: ovs-dev-bounces@openvswitch.org ovn-trace will tell you when a packet processing ends because no flow is matched in a given logical flow table. Update the output to clarify that when this occurs, the packet is implicitly dropped. The output now looks like this: ingress(dp="sw0", inport="sw0-port1") ------------------------------------- 0. ls_in_port_sec_l2: no match (implicit drop) Signed-off-by: Russell Bryant Acked-by: Ben Pfaff --- ovn/utilities/ovn-trace.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ovn/utilities/ovn-trace.c b/ovn/utilities/ovn-trace.c index 692b274..13a980b 100644 --- a/ovn/utilities/ovn-trace.c +++ b/ovn/utilities/ovn-trace.c @@ -1359,7 +1359,7 @@ trace__(const struct ovntrace_datapath *dp, struct flow *uflow, ds_put_format(&s, "%s, priority %d", f->match_s, f->priority); } else { char *stage_name = ovntrace_stage_name(dp, table_id, pipeline); - ds_put_format(&s, "%s%sno match", + ds_put_format(&s, "%s%sno match (implicit drop)", stage_name ? stage_name : "", stage_name ? ": " : ""); free(stage_name);