| Message ID | 20160919231602.6008-1-rams@vmware.com |
|---|---|
| State | Accepted |
| Headers | show |
Thanks for fixing this. Acked-by: Sairam Venugopal <vsairam@vmware.com> On 9/19/16, 4:16 PM, "Shashank Ram" <rams@vmware.com> wrote: >Adds a define for the last defined module number. > >Change-Id: I1ea9230317a849e911900cf69e96ed85a65d3a8c >Signed-off-by: Shashank Ram <rams@vmware.com> >--- > datapath-windows/ovsext/Debug.c | 1 + > datapath-windows/ovsext/Debug.h | 4 ++-- > 2 files changed, 3 insertions(+), 2 deletions(-) > >diff --git a/datapath-windows/ovsext/Debug.c >b/datapath-windows/ovsext/Debug.c >index a96d38d..c3d14ae 100644 >--- a/datapath-windows/ovsext/Debug.c >+++ b/datapath-windows/ovsext/Debug.c >@@ -25,6 +25,7 @@ > > UINT32 ovsLogFlags = 0xffffffff; > UINT32 ovsLogLevel = OVS_DBG_DEFAULT; >+BUILD_ASSERT(OVS_DBG_LAST < 31); /* 'ovsLogLevel' is 32 bits. */ > > #define OVS_LOG_BUFFER_SIZE 384 > >diff --git a/datapath-windows/ovsext/Debug.h >b/datapath-windows/ovsext/Debug.h >index 935f858..cae6ac9 100644 >--- a/datapath-windows/ovsext/Debug.h >+++ b/datapath-windows/ovsext/Debug.h >@@ -43,8 +43,8 @@ > #define OVS_DBG_CONTRK BIT32(23) > #define OVS_DBG_GENEVE BIT32(24) > >-#define OVS_DBG_RESERVED BIT32(31) >-//Please add above OVS_DBG_RESERVED. >+#define OVS_DBG_LAST 24 /* Set this to the last defined module >number. */ >+/* Please add above OVS_DBG_LAST. */ > > #define OVS_DBG_ERROR DPFLTR_ERROR_LEVEL > #define OVS_DBG_WARN DPFLTR_WARNING_LEVEL >-- >2.9.3.windows.2 > >_______________________________________________ >dev mailing list >dev@openvswitch.org >https://urldefense.proofpoint.com/v2/url?u=http-3A__openvswitch.org_mailma >n_listinfo_dev&d=CwIGaQ&c=Sqcl0Ez6M0X8aeM67LKIiDJAXVeAw-YihVMNtXt-uEs&r=Dc >ruz40PROJ40ROzSpxyQSLw6fcrOWpJgEcEmNR3JEQ&m=TOmB5UNcg-zFOda-mCbQv18k8tPK5t >Ym77eotJR0pnk&s=sYgoL2PsKAO-t1fQ6K-YkddMZxD8v35UogStZIhQD24&e=
Acked-by: Nithin Raju <nithin@vmware.com> -----Original Message----- From: dev <dev-bounces@openvswitch.org> on behalf of Sairam Venugopal <vsairam@vmware.com> Date: Monday, September 19, 2016 at 4:21 PM To: Shashank Ram <rams@vmware.com>, "dev@openvswitch.org" <dev@openvswitch.org> Subject: Re: [ovs-dev] [PATCH v3] datapath-windows: Add define for last module number >Thanks for fixing this. > >Acked-by: Sairam Venugopal <vsairam@vmware.com> > > > >On 9/19/16, 4:16 PM, "Shashank Ram" <rams@vmware.com> wrote: > >>Adds a define for the last defined module number. >> >>Change-Id: I1ea9230317a849e911900cf69e96ed85a65d3a8c >>Signed-off-by: Shashank Ram <rams@vmware.com> >>--- >> datapath-windows/ovsext/Debug.c | 1 + >> datapath-windows/ovsext/Debug.h | 4 ++-- >> 2 files changed, 3 insertions(+), 2 deletions(-) >> >>diff --git a/datapath-windows/ovsext/Debug.c >>b/datapath-windows/ovsext/Debug.c >>index a96d38d..c3d14ae 100644 >>--- a/datapath-windows/ovsext/Debug.c >>+++ b/datapath-windows/ovsext/Debug.c >>@@ -25,6 +25,7 @@ >> >> UINT32 ovsLogFlags = 0xffffffff; >> UINT32 ovsLogLevel = OVS_DBG_DEFAULT; >>+BUILD_ASSERT(OVS_DBG_LAST < 31); /* 'ovsLogLevel' is 32 bits. */ >> >> #define OVS_LOG_BUFFER_SIZE 384 >> >>diff --git a/datapath-windows/ovsext/Debug.h >>b/datapath-windows/ovsext/Debug.h >>index 935f858..cae6ac9 100644 >>--- a/datapath-windows/ovsext/Debug.h >>+++ b/datapath-windows/ovsext/Debug.h >>@@ -43,8 +43,8 @@ >> #define OVS_DBG_CONTRK BIT32(23) >> #define OVS_DBG_GENEVE BIT32(24) >> >>-#define OVS_DBG_RESERVED BIT32(31) >>-//Please add above OVS_DBG_RESERVED. >>+#define OVS_DBG_LAST 24 /* Set this to the last defined module >>number. */ >>+/* Please add above OVS_DBG_LAST. */ >> >> #define OVS_DBG_ERROR DPFLTR_ERROR_LEVEL >> #define OVS_DBG_WARN DPFLTR_WARNING_LEVEL >>-- >>2.9.3.windows.2 >> >>_______________________________________________ >>dev mailing list >>dev@openvswitch.org >>https://urldefense.proofpoint.com/v2/url?u=http-3A__openvswitch.org_mailm >>a >>n_listinfo_dev&d=CwIGaQ&c=Sqcl0Ez6M0X8aeM67LKIiDJAXVeAw-YihVMNtXt-uEs&r=D >>c >>ruz40PROJ40ROzSpxyQSLw6fcrOWpJgEcEmNR3JEQ&m=TOmB5UNcg-zFOda-mCbQv18k8tPK5 >>t >>Ym77eotJR0pnk&s=sYgoL2PsKAO-t1fQ6K-YkddMZxD8v35UogStZIhQD24&e= > >_______________________________________________ >dev mailing list >dev@openvswitch.org >https://urldefense.proofpoint.com/v2/url?u=http-3A__openvswitch.org_mailma >n_listinfo_dev&d=CwIGaQ&c=Sqcl0Ez6M0X8aeM67LKIiDJAXVeAw-YihVMNtXt-uEs&r=pN >HQcdr7B40b4h6Yb7FIedI1dnBsxdDuTLBYD3JqV80&m=KrXss9NJ7JRZh4IY1EmPSvyJzScW73 >GyOZ0FvvQ6R0k&s=V0Qbul9QWt-TInWnBTIT8EdyxAbbhynFi3uTQ79Wixw&e=
On 19 September 2016 at 16:16, Shashank Ram <rams@vmware.com> wrote: > Adds a define for the last defined module number. > > Change-Id: I1ea9230317a849e911900cf69e96ed85a65d3a8c > Signed-off-by: Shashank Ram <rams@vmware.com> > I removed the Change-Id, added you to AUTHORS and applied this to master and 2.6 Thanks! > --- > datapath-windows/ovsext/Debug.c | 1 + > datapath-windows/ovsext/Debug.h | 4 ++-- > 2 files changed, 3 insertions(+), 2 deletions(-) > > diff --git a/datapath-windows/ovsext/Debug.c b/datapath-windows/ovsext/ > Debug.c > index a96d38d..c3d14ae 100644 > --- a/datapath-windows/ovsext/Debug.c > +++ b/datapath-windows/ovsext/Debug.c > @@ -25,6 +25,7 @@ > > UINT32 ovsLogFlags = 0xffffffff; > UINT32 ovsLogLevel = OVS_DBG_DEFAULT; > +BUILD_ASSERT(OVS_DBG_LAST < 31); /* 'ovsLogLevel' is 32 bits. */ > > #define OVS_LOG_BUFFER_SIZE 384 > > diff --git a/datapath-windows/ovsext/Debug.h b/datapath-windows/ovsext/ > Debug.h > index 935f858..cae6ac9 100644 > --- a/datapath-windows/ovsext/Debug.h > +++ b/datapath-windows/ovsext/Debug.h > @@ -43,8 +43,8 @@ > #define OVS_DBG_CONTRK BIT32(23) > #define OVS_DBG_GENEVE BIT32(24) > > -#define OVS_DBG_RESERVED BIT32(31) > -//Please add above OVS_DBG_RESERVED. > +#define OVS_DBG_LAST 24 /* Set this to the last defined module > number. */ > +/* Please add above OVS_DBG_LAST. */ > > #define OVS_DBG_ERROR DPFLTR_ERROR_LEVEL > #define OVS_DBG_WARN DPFLTR_WARNING_LEVEL > -- > 2.9.3.windows.2 > > _______________________________________________ > dev mailing list > dev@openvswitch.org > http://openvswitch.org/mailman/listinfo/dev >
-----Original Message----- From: dev <dev-bounces@openvswitch.org> on behalf of Guru Shetty <guru@ovn.org> Date: Tuesday, September 20, 2016 at 7:40 AM To: Shashank Ram <rams@vmware.com> Cc: ovs dev <dev@openvswitch.org> Subject: Re: [ovs-dev] [PATCH v3] datapath-windows: Add define for last module number >On 19 September 2016 at 16:16, Shashank Ram <rams@vmware.com> wrote: > >> Adds a define for the last defined module number. >> >> Change-Id: I1ea9230317a849e911900cf69e96ed85a65d3a8c >> Signed-off-by: Shashank Ram <rams@vmware.com> >> > >I removed the Change-Id, added you to AUTHORS and applied this to master >and 2.6 Thanks Guru.
diff --git a/datapath-windows/ovsext/Debug.c b/datapath-windows/ovsext/Debug.c index a96d38d..c3d14ae 100644 --- a/datapath-windows/ovsext/Debug.c +++ b/datapath-windows/ovsext/Debug.c @@ -25,6 +25,7 @@ UINT32 ovsLogFlags = 0xffffffff; UINT32 ovsLogLevel = OVS_DBG_DEFAULT; +BUILD_ASSERT(OVS_DBG_LAST < 31); /* 'ovsLogLevel' is 32 bits. */ #define OVS_LOG_BUFFER_SIZE 384 diff --git a/datapath-windows/ovsext/Debug.h b/datapath-windows/ovsext/Debug.h index 935f858..cae6ac9 100644 --- a/datapath-windows/ovsext/Debug.h +++ b/datapath-windows/ovsext/Debug.h @@ -43,8 +43,8 @@ #define OVS_DBG_CONTRK BIT32(23) #define OVS_DBG_GENEVE BIT32(24) -#define OVS_DBG_RESERVED BIT32(31) -//Please add above OVS_DBG_RESERVED. +#define OVS_DBG_LAST 24 /* Set this to the last defined module number. */ +/* Please add above OVS_DBG_LAST. */ #define OVS_DBG_ERROR DPFLTR_ERROR_LEVEL #define OVS_DBG_WARN DPFLTR_WARNING_LEVEL
Adds a define for the last defined module number. Change-Id: I1ea9230317a849e911900cf69e96ed85a65d3a8c Signed-off-by: Shashank Ram <rams@vmware.com> --- datapath-windows/ovsext/Debug.c | 1 + datapath-windows/ovsext/Debug.h | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-)