From patchwork Tue Oct 6 22:52:41 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ben Pfaff X-Patchwork-Id: 527046 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from archives.nicira.com (li376-54.members.linode.com [96.126.127.54]) by ozlabs.org (Postfix) with ESMTP id DFA1B140D93 for ; Wed, 7 Oct 2015 09:52:51 +1100 (AEDT) Received: from archives.nicira.com (localhost [127.0.0.1]) by archives.nicira.com (Postfix) with ESMTP id 634F310610; Tue, 6 Oct 2015 15:52:49 -0700 (PDT) X-Original-To: dev@openvswitch.org Delivered-To: dev@openvswitch.org Received: from mx3v1.cudamail.com (mx3.cudamail.com [64.34.241.5]) by archives.nicira.com (Postfix) with ESMTPS id 69FD1105F6 for ; Tue, 6 Oct 2015 15:52:48 -0700 (PDT) Received: from bar3.cudamail.com (bar1 [192.168.15.1]) by mx3v1.cudamail.com (Postfix) with ESMTP id 333A061841D for ; Tue, 6 Oct 2015 16:52:47 -0600 (MDT) X-ASG-Debug-ID: 1444171966-03dd7b7d3e08ba0001-byXFYA Received: from mx3-pf3.cudamail.com ([192.168.14.3]) by bar3.cudamail.com with ESMTP id PIz9Hy8z0VAbK7eG (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Tue, 06 Oct 2015 16:52:46 -0600 (MDT) X-Barracuda-Envelope-From: blp@nicira.com X-Barracuda-RBL-Trusted-Forwarder: 192.168.14.3 Received: from unknown (HELO mail-pa0-f51.google.com) (209.85.220.51) by mx3-pf3.cudamail.com with ESMTPS (RC4-SHA encrypted); 6 Oct 2015 22:52:45 -0000 Received-SPF: unknown (mx3-pf3.cudamail.com: Multiple SPF records returned) X-Barracuda-RBL-Trusted-Forwarder: 209.85.220.51 Received: by pablk4 with SMTP id lk4so116391pab.3 for ; Tue, 06 Oct 2015 15:52:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-type:content-disposition:in-reply-to :user-agent; bh=7coTv6tGPA5fN0VUt3J7NVZ/0oMDxGEtifYqrE1qF9Y=; b=CzDCMoSkfp6OLe4Fr1cKJYqjFhmQHmP03AV6M25V0ymzZuzKI7KbTGk7rrTnaLmta+ ILG22ECV4T4X4hAZKGJd9P2wQNqQvLh3QOGI2s2r792cuICv0EkI32k2Zx5voEjyG94H dvECRr6pauKPG/mvD/M5c6zk7ZfZnSKhe9QcFILppw4EUaqzv1ksqPDwZYCiWHFUMAw7 EOX9iNiS9e8qa2id+lwJkIjiaVvvP7RjskMdGY/fBk+3kNOoGH90SiMAdlAH1Z4+IWr9 B4tNr7qwoPfHyDZHU6ipCQFmse/6m6ghHa+RPEuURB2vY00bQ0UJwAKRIOjuiFDnXJGP 65PA== X-Gm-Message-State: ALoCoQl4qCXuSvov8ttLKnfXtVuVxgKB4HUqJz6mhDRtSioru7gcR9NyBcSpnC/jEPAK9OQQ3xW5 X-Received: by 10.68.196.161 with SMTP id in1mr6526400pbc.127.1444171965462; Tue, 06 Oct 2015 15:52:45 -0700 (PDT) Received: from nicira.com (173-228-112-165.dsl.dynamic.fusionbroadband.com. [173.228.112.165]) by smtp.gmail.com with ESMTPSA id so4sm35451354pbc.72.2015.10.06.15.52.43 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 06 Oct 2015 15:52:43 -0700 (PDT) Date: Tue, 6 Oct 2015 15:52:41 -0700 X-Barracuda-Apparent-Source-IP: 173.228.112.165 X-CudaMail-Envelope-Sender: blp@nicira.com From: Ben Pfaff To: Russell Bryant X-CudaMail-Whitelist-To: dev@openvswitch.org X-CudaMail-MID: CM-V3-1005070241 X-CudaMail-DTE: 100615 X-CudaMail-Originating-IP: 209.85.220.51 Message-ID: <20151006225241.GB10773@nicira.com> X-ASG-Orig-Subj: [##CM-V3-1005070241##]Re: [ovs-dev] [PATCH] ovn-sb.xml: Reorganize Port_Binding documentation. References: <1444163536-26626-1-git-send-email-blp@nicira.com> <56144863.6000607@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <56144863.6000607@redhat.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-Barracuda-Connect: UNKNOWN[192.168.14.3] X-Barracuda-Start-Time: 1444171966 X-Barracuda-Encrypted: DHE-RSA-AES256-SHA X-Barracuda-URL: https://web.cudamail.com:443/cgi-mod/mark.cgi X-ASG-Whitelist: Header =?UTF-8?B?eFwtY3VkYW1haWxcLXdoaXRlbGlzdFwtdG8=?= X-Virus-Scanned: by bsmtpd at cudamail.com X-Barracuda-BRTS-Status: 1 Cc: dev@openvswitch.org Subject: Re: [ovs-dev] [PATCH] ovn-sb.xml: Reorganize Port_Binding documentation. X-BeenThere: dev@openvswitch.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@openvswitch.org Sender: "dev" On Tue, Oct 06, 2015 at 11:17:07PM +0100, Russell Bryant wrote: > On 10/06/2015 09:32 PM, Ben Pfaff wrote: > > This takes advantage of column grouping and the ability to document a key > > within a column. > > > > Signed-off-by: Ben Pfaff > > I like the grouping. The only issue I saw is that "tag" is only > included under "Nested Containers". It's now used for localnet ports, > as well. You're right, that's not really clear. I applied the following incremental and I'll apply this to master soon: Acked-by: Russell Bryant diff --git a/ovn/ovn-sb.xml b/ovn/ovn-sb.xml index d1b37f0..f9e21c6 100644 --- a/ovn/ovn-sb.xml +++ b/ovn/ovn-sb.xml @@ -1060,6 +1060,12 @@ another chassis.

+ + + If set, indicates that the port represents a connection to a specific + VLAN on a locally accessible network. The VLAN ID is used to match + incoming traffic and is also added to outgoing traffic. + @@ -1080,8 +1086,11 @@

- These columns support containers nested within a VM. They are empty - for containers or VMs that run directly on a hypervisor. + These columns support containers nested within a VM. Specifically, + they are used when is empty and identifies the interface of a container spawned + inside a VM. They are empty for containers or VMs that run directly on + a hypervisor.

@@ -1093,19 +1102,13 @@

- When is empty and - identifies the interface of a container spawned inside a VM, this - column identifies the VLAN tag in the network traffic associated with - that container's network interface. It is left empty if belongs to a VM or a container created in the - hypervisor. + Identifies the VLAN tag in the network traffic associated with that + container's network interface.

- When is set to localnet, this can - be set to indicate that the port represents a connection to a - specific VLAN on a locally accessible network. The VLAN ID is used to - match incoming traffic and is also added to outgoing traffic. + This column is used for a different purpose when + is localnet (see Localnet Options, above).