diff mbox series

[ovs-dev] ovn: debhelper compatibility levels before 10 are deprecated

Message ID 1982961656934073@myt6-f022a9bff406.qloud-c.yandex.net
State Not Applicable
Headers show
Series [ovs-dev] ovn: debhelper compatibility levels before 10 are deprecated | expand

Checks

Context Check Description
ovsrobot/apply-robot success apply and check: success
ovsrobot/github-robot-_Build_and_Test success github build: passed
ovsrobot/intel-ovs-compilation fail test: fail

Commit Message

Igor Zhukov July 4, 2022, 11:27 a.m. UTC 
Ilya Maximets said me that there is another patch that changes debian build: https://patchwork.ozlabs.org/project/openvswitch/list/?series=307155&state=
So maybe the patch is not helpful.
And could be closed without merging.
But I want to ensure that I learnt how to submit a patch to ovn.

From 744d20cc8e23c408444c6cc67014f86aa1eaeee7 Mon Sep 17 00:00:00 2001
From: Igor Zhukov <ivzhukov@sbercloud.ru>
Date: Mon, 4 Jul 2022 11:52:45 +0700
Subject: [PATCH ovn] Fix a warning: "Compatibility levels before 10 are
 deprecated (level 9 in use)"

Signed-off-by: Igor Zhukov <ivzhukov@sbercloud.ru>
---
 debian/compat | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Igor Zhukov July 4, 2022, 12:48 p.m. UTC | #1 
I looked history and I found: https://github.com/ovn-org/ovn/commit/f492eb8f049a657203ad4dc6bd79bd0231de521e
So it seems we need to modify debian/control also.

So, am I correct with this command?

$ git format-patch --subject-prefix="PATCH ovn" -2 HEAD -v2

From 62ee138da86293305e322cdfccbc2f51b35b2dd1 Mon Sep 17 00:00:00 2001
From: Igor Zhukov <ivzhukov@sbercloud.ru>
Date: Mon, 4 Jul 2022 19:40:18 +0700
Subject: [PATCH ovn v2 2/2] make build-depends consistent

Signed-off-by: Igor Zhukov <ivzhukov@sbercloud.ru>
---
 debian/control | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/debian/control b/debian/control
index 6ee2192d0..ef069351c 100644
--- a/debian/control
+++ b/debian/control
@@ -7,7 +7,7 @@ Build-Depends: graphviz,
                autoconf (>= 2.64),
                automake (>= 1.10) | automake1.10,
                bzip2,
-               debhelper (>= 8),
+               debhelper (>= 10),
                dh-autoreconf,
                libssl-dev,
                libtool,
Igor Zhukov July 4, 2022, 1:01 p.m. UTC | #2 
Looks wrong :(
Another try.
I rebased and squashed to one commit.

$ git rebase -i HEAD~2
$ git format-patch --subject-prefix="PATCH ovn" -1 HEAD -v3

From b899dee39ea7c6ef8d8a0af83eba4631deb95c03 Mon Sep 17 00:00:00 2001
From: Igor Zhukov <ivzhukov@sbercloud.ru>
Date: Mon, 4 Jul 2022 11:52:45 +0700
Subject: [PATCH ovn v3] Fix a warning: "Compatibility levels before 10 are
 deprecated (level 9 in use)"

Signed-off-by: Igor Zhukov <ivzhukov@sbercloud.ru>
---
 debian/compat  | 2 +-
 debian/control | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/debian/compat b/debian/compat
index ec635144f..f599e28b8 100644
--- a/debian/compat
+++ b/debian/compat
@@ -1 +1 @@
-9
+10
diff --git a/debian/control b/debian/control
index 6ee2192d0..ef069351c 100644
--- a/debian/control
+++ b/debian/control
@@ -7,7 +7,7 @@ Build-Depends: graphviz,
                autoconf (>= 2.64),
                automake (>= 1.10) | automake1.10,
                bzip2,
-               debhelper (>= 8),
+               debhelper (>= 10),
                dh-autoreconf,
                libssl-dev,
                libtool,
Igor Zhukov July 4, 2022, 1:08 p.m. UTC | #3 
Looks wrong :(
Another try.
I rebased and squashed to one commit.

$ git rebase -i HEAD~2
$ git format-patch --subject-prefix="PATCH ovn" -1 HEAD -v3

From b899dee39ea7c6ef8d8a0af83eba4631deb95c03 Mon Sep 17 00:00:00 2001
From: Igor Zhukov <ivzhukov@sbercloud.ru>
Date: Mon, 4 Jul 2022 11:52:45 +0700
Subject: [PATCH ovn v3] Fix a warning: "Compatibility levels before 10 are
 deprecated (level 9 in use)"

Signed-off-by: Igor Zhukov <ivzhukov@sbercloud.ru>
---
 debian/compat  | 2 +-
 debian/control | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/debian/compat b/debian/compat
index ec635144f..f599e28b8 100644
--- a/debian/compat
+++ b/debian/compat
@@ -1 +1 @@
-9
+10
diff --git a/debian/control b/debian/control
index 6ee2192d0..ef069351c 100644
--- a/debian/control
+++ b/debian/control
@@ -7,7 +7,7 @@ Build-Depends: graphviz,
                autoconf (>= 2.64),
                automake (>= 1.10) | automake1.10,
                bzip2,
-               debhelper (>= 8),
+               debhelper (>= 10),
                dh-autoreconf,
                libssl-dev,
                libtool,
diff mbox series

Patch

diff --git a/debian/compat b/debian/compat
index ec635144f..f599e28b8 100644
--- a/debian/compat
+++ b/debian/compat
@@ -1 +1 @@ 
-9
+10