| Message ID | 192fd7705ac34efab09d2e5c37dc7dbff58fc630.1716896375.git.echaudro@redhat.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | Coverity fixes. | expand |
| Context | Check | Description |
|---|---|---|
| ovsrobot/apply-robot | success | apply and check: success |
| ovsrobot/github-robot-_Build_and_Test | success | github build: passed |
| ovsrobot/intel-ovs-compilation | success | test: success |
On Tue, May 28, 2024 at 7:46 AM Eelco Chaudron <echaudro@redhat.com> wrote: > > Fix the warning from Coverity about potential truncation of the > time_t value when copying to a local variable by changing the > local variable's type to time_t. > > ccc24fc88d59 ("ofproto-dpif: APIs and CLI option to add/delete static fdb entry.") > Signed-off-by: Eelco Chaudron <echaudro@redhat.com> > --- Acked-by: Mike Pattrick <mkp@redhat.com>
Eelco Chaudron <echaudro@redhat.com> writes: > Fix the warning from Coverity about potential truncation of the > time_t value when copying to a local variable by changing the > local variable's type to time_t. > > ccc24fc88d59 ("ofproto-dpif: APIs and CLI option to add/delete static fdb entry.") It seems "Fixes:" slipped out here. I guess this could be fixed while applying. That aside, Acked-by: Paolo Valerio <pvalerio@redhat.com> > Signed-off-by: Eelco Chaudron <echaudro@redhat.com> > --- > ofproto/ofproto-dpif.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c > index 32d037be6..fcd7cd753 100644 > --- a/ofproto/ofproto-dpif.c > +++ b/ofproto/ofproto-dpif.c > @@ -6097,7 +6097,7 @@ ofproto_unixctl_fdb_add(struct unixctl_conn *conn, int argc OVS_UNUSED, > const char *port_name = argv[2]; > uint16_t vlan = atoi(argv[3]); > struct eth_addr mac; > - int age; > + time_t age; > > ofproto = ofproto_dpif_lookup_by_name(br_name); > if (!ofproto) { > -- > 2.44.0 > > _______________________________________________ > dev mailing list > dev@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On 28 May 2024, at 19:56, Paolo Valerio wrote: > Eelco Chaudron <echaudro@redhat.com> writes: > >> Fix the warning from Coverity about potential truncation of the >> time_t value when copying to a local variable by changing the >> local variable's type to time_t. >> >> ccc24fc88d59 ("ofproto-dpif: APIs and CLI option to add/delete static fdb entry.") > > It seems "Fixes:" slipped out here. > I guess this could be fixed while applying. > That aside, > > Acked-by: Paolo Valerio <pvalerio@redhat.com> Thanks Paolo for the review. I’ll make sure it gets fixed on commit if no new version is required. >> Signed-off-by: Eelco Chaudron <echaudro@redhat.com> >> --- >> ofproto/ofproto-dpif.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c >> index 32d037be6..fcd7cd753 100644 >> --- a/ofproto/ofproto-dpif.c >> +++ b/ofproto/ofproto-dpif.c >> @@ -6097,7 +6097,7 @@ ofproto_unixctl_fdb_add(struct unixctl_conn *conn, int argc OVS_UNUSED, >> const char *port_name = argv[2]; >> uint16_t vlan = atoi(argv[3]); >> struct eth_addr mac; >> - int age; >> + time_t age; >> >> ofproto = ofproto_dpif_lookup_by_name(br_name); >> if (!ofproto) { >> -- >> 2.44.0 >> >> _______________________________________________ >> dev mailing list >> dev@openvswitch.org >> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c index 32d037be6..fcd7cd753 100644 --- a/ofproto/ofproto-dpif.c +++ b/ofproto/ofproto-dpif.c @@ -6097,7 +6097,7 @@ ofproto_unixctl_fdb_add(struct unixctl_conn *conn, int argc OVS_UNUSED, const char *port_name = argv[2]; uint16_t vlan = atoi(argv[3]); struct eth_addr mac; - int age; + time_t age; ofproto = ofproto_dpif_lookup_by_name(br_name); if (!ofproto) {
Fix the warning from Coverity about potential truncation of the time_t value when copying to a local variable by changing the local variable's type to time_t. ccc24fc88d59 ("ofproto-dpif: APIs and CLI option to add/delete static fdb entry.") Signed-off-by: Eelco Chaudron <echaudro@redhat.com> --- ofproto/ofproto-dpif.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)