diff mbox series

[ovs-dev,v11,07/11] test: Fix 'conntrack - Multiple ICMP traverse' for tc case.

Message ID 167577875586.1166983.13189989565997555304.stgit@ebuild.local
State Accepted
Commit 25b6f5585ba04e92560ef7f5cd37826caf54cc68
Headers show
Series tests: Add system-traffic.at tests to check-offloads. | expand

Checks

Context Check Description
ovsrobot/apply-robot success apply and check: success
ovsrobot/github-robot-_Build_and_Test success github build: passed
ovsrobot/intel-ovs-compilation success test: success

Commit Message

Eelco Chaudron Feb. 7, 2023, 2:05 p.m. UTC 
tc does not include ethernet header length in packet byte count.
This fix will allow the packets that go trough tc to be 14 bytes less.

This difference in the TC implementation is already described in
tc-offload.rst.

Signed-off-by: Eelco Chaudron <echaudro@redhat.com>
Acked-by: Roi Dayan <roid@nvidia.com>
---
 tests/system-traffic.at |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Simon Horman Feb. 8, 2023, 4:35 p.m. UTC | #1 
On Tue, Feb 07, 2023 at 03:05:57PM +0100, Eelco Chaudron wrote:
> tc does not include ethernet header length in packet byte count.
> This fix will allow the packets that go trough tc to be 14 bytes less.
> 
> This difference in the TC implementation is already described in
> tc-offload.rst.
> 
> Signed-off-by: Eelco Chaudron <echaudro@redhat.com>
> Acked-by: Roi Dayan <roid@nvidia.com>

Reviewed-by: Simon Horman <simon.horman@corigine.com>
Tested-by: Simon Horman <simon.horman@corigine.com>
diff mbox series

Patch

diff --git a/tests/system-traffic.at b/tests/system-traffic.at
index b57054985..4f3e76789 100644
--- a/tests/system-traffic.at
+++ b/tests/system-traffic.at
@@ -7117,7 +7117,6 @@  AT_SETUP([conntrack - Multiple ICMP traverse])
 dnl This tracks sending ICMP packets via conntrack multiple times for the
 dnl same packet
 CHECK_CONNTRACK()
-CHECK_NO_TC_OFFLOAD()
 OVS_TRAFFIC_VSWITCHD_START()
 OVS_CHECK_CT_CLEAR()
 
@@ -7149,7 +7148,7 @@  AT_CHECK([ovs-appctl dpctl/dump-conntrack | FORMAT_CT(10.1.1)], [0], [dnl
 icmp,orig=(src=10.1.1.1,dst=10.1.1.2,id=<cleared>,type=8,code=0),reply=(src=10.1.1.2,dst=10.1.1.1,id=<cleared>,type=0,code=0)
 ])
 
-AT_CHECK([ovs-ofctl dump-flows br0 | grep table=2, | OFPROTO_CLEAR_DURATION_IDLE],
+AT_CHECK([ovs-ofctl dump-flows br0 | grep table=2, | OFPROTO_CLEAR_DURATION_IDLE | sed 's/n_bytes=70,/n_bytes=84,/'],
          [0], [dnl
  cookie=0x0, duration=<cleared>, table=2, n_packets=2, n_bytes=84, idle_age=<cleared>, priority=10,ct_state=+new+trk,in_port=1 actions=drop
  cookie=0x0, duration=<cleared>, table=2, n_packets=0, n_bytes=0, idle_age=<cleared>, priority=10,ct_state=+est+trk actions=drop