From patchwork Tue Nov 15 12:35:03 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Eelco Chaudron X-Patchwork-Id: 1704064 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org (client-ip=2605:bc80:3010::136; helo=smtp3.osuosl.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=CLyIIUeW; dkim-atps=neutral Received: from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4NBQcl3Xb2z20KC for ; Tue, 15 Nov 2022 23:35:19 +1100 (AEDT) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 8AC7860E34; Tue, 15 Nov 2022 12:35:17 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 8AC7860E34 Authentication-Results: smtp3.osuosl.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=CLyIIUeW X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id QmyPK0EwJXBK; Tue, 15 Nov 2022 12:35:16 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp3.osuosl.org (Postfix) with ESMTPS id 9C4AE60E25; Tue, 15 Nov 2022 12:35:15 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 9C4AE60E25 Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 3116FC002D; Tue, 15 Nov 2022 12:35:15 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@lists.linuxfoundation.org Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by lists.linuxfoundation.org (Postfix) with ESMTP id 187ACC0070 for ; Tue, 15 Nov 2022 12:35:14 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id C4F4A409C1 for ; Tue, 15 Nov 2022 12:35:11 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org C4F4A409C1 Authentication-Results: smtp2.osuosl.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=CLyIIUeW X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id rU3rLhTX8B9T for ; Tue, 15 Nov 2022 12:35:11 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org F2E194064D Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by smtp2.osuosl.org (Postfix) with ESMTPS id F2E194064D for ; Tue, 15 Nov 2022 12:35:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1668515710; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NGWf96Hwnr//bc7tc6YKLO7d8ZmdjRmh8scn3HtzdJI=; b=CLyIIUeWk52iywXS4wR/31Fiv4kLn76by2rAE1i+jvgD298UuHl/+TebfW51Hi3SBCq0Rc DamvoFWxzd1/haDpsIoWajEahfFbpe4ZCWFx2BSBbvmWdK9dUHKMy+GP7imP+SnAWOnIvr Ap8g7hZ0zpaAwJU0KdRX/kPASmqZUkk= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-187-h8TZ61n4PCehL--dXBEkFw-1; Tue, 15 Nov 2022 07:35:08 -0500 X-MC-Unique: h8TZ61n4PCehL--dXBEkFw-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 592C529A8AEA; Tue, 15 Nov 2022 12:35:08 +0000 (UTC) Received: from ebuild.redhat.com (unknown [10.39.193.124]) by smtp.corp.redhat.com (Postfix) with ESMTP id DAEF2140EBF3; Tue, 15 Nov 2022 12:35:07 +0000 (UTC) From: Eelco Chaudron To: dev@openvswitch.org Date: Tue, 15 Nov 2022 13:35:03 +0100 Message-Id: <166851570306.872016.4598334881175756417.stgit@ebuild> In-Reply-To: <166851534894.872016.10933356563476630373.stgit@ebuild> References: <166851534894.872016.10933356563476630373.stgit@ebuild> User-Agent: StGit/1.1 MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.7 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Subject: [ovs-dev] [PATCH v2 15/15] tests: Comment currently failing TC system-traffic tests. X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: ovs-dev-bounces@openvswitch.org Sender: "dev" The goal was to run 200 successful tc tests in a row. To do this the following was run: for i in {1..200}; do make check-offloads || break; \ echo "ALL_200_OK: $i"; done; Unfortunately, a bunch of test cases showed occasional failures. For now, they are excluded from the test cases and need further investigation. They are: 802.1ad - vlan_limit conntrack - DNAT load balancing conntrack - DNAT load balancing with NC conntrack - ICMP related conntrack - ICMP related to original direction conntrack - ICMP related with NAT conntrack - IPv4 fragmentation with fragments specified conntrack - multiple namespaces, internal ports conntrack - zones from other field conntrack - zones from other field, more tests datapath - basic truncate action datapath - multiple mpls label pop datapath - truncate and output to gre tunnel datapath - truncate and output to gre tunnel by simulated packets Some other test cases also fail due to what looks like problems in the tc kernel conntrack implementation. For details see the details in the system-offloads.at exclusion list definition. Signed-off-by: Eelco Chaudron --- tests/system-offloads.at | 43 +++++++++++++++++++++++++++++++++++++------ 1 file changed, 37 insertions(+), 6 deletions(-) diff --git a/tests/system-offloads.at b/tests/system-offloads.at index 638cd88d5..49f93b287 100644 --- a/tests/system-offloads.at +++ b/tests/system-offloads.at @@ -40,20 +40,51 @@ m4_define([CHECK_CONNTRACK_ALG], # issue. m4_define([OVS_TEST_SKIP_LIST], [ovs_test_skip_list=" +# TC does not support moving ports to a different namespace than vswitchd's +# namespace, so we need to disable this test. conntrack - multiple namespaces, internal ports + +# When moving through different zones, it can take up to ~8 seconds before +# the conntrack state gets updated causing these tests to fail. conntrack - ct metadata, multiple zones -conntrack - ICMP related -conntrack - ICMP related to original direction +conntrack - multiple zones, local +conntrack - multi-stage pipeline, local + +# The kernel's tcf_ct_act() function does not seem to take care of any (QinQ) +# VLAN headers causing commits to fail. However, if this is solved, we have to +# make sure conntrack does not break the VLAN boundary, i.e., putting together +# two packets with different CVLAN+SVLAN values. conntrack - IPv4 fragmentation + cvlan -conntrack - IPv4 fragmentation with fragments specified conntrack - IPv6 fragmentation + cvlan + +# Fragmentation handling in ct zone 9 does not seem to work correctly. +# When moving this test over to the default zone all works fine. conntrack - Fragmentation over vxlan conntrack - IPv6 Fragmentation over vxlan -conntrack - multiple zones, local -conntrack - multi-stage pipeline, local + +# Occasionaly we fail on the 'execute ct(commit) failed (Invalid argument) on +# packet...' log message being present +conntrack - zones from other field +conntrack - zones from other field, more tests +conntrack - multiple namespaces, internal ports +conntrack - IPv4 fragmentation with fragments specified + +# Occasionaly we fail on the 'failed to flow_get/flow_del (No such file or directory) +# ufid:..' log message being present. +datapath - multiple mpls label pop +datapath - basic truncate action +conntrack - ICMP related +conntrack - ICMP related to original direction conntrack - ICMP related with NAT conntrack - DNAT load balancing -conntrack - DNAT load balancing with NC" +conntrack - DNAT load balancing with NC +802.1ad - vlan_limit + +# Occasionalt we fail with extreme high byte counters, i.e. +# n_bytes=18446744073705804134 +datapath - truncate and output to gre tunnel by simulated packets +datapath - truncate and output to gre tunnel +" echo "$ovs_test_skip_list" | sed "s// /g"]) m4_include([tests/system-traffic.at])