| Message ID | 166851552289.872016.16207458464139496610.stgit@ebuild |
|---|---|
| State | Superseded |
| Headers | show |
| Series | tests: Add system-traffic.at tests to check-offloads. | expand |
| Context | Check | Description |
|---|---|---|
| ovsrobot/apply-robot | success | apply and check: success |
| ovsrobot/github-robot-_Build_and_Test | success | github build: passed |
| ovsrobot/intel-ovs-compilation | fail | test: fail |
On 15/11/2022 14:32, Eelco Chaudron wrote: > The tc conntrack implementation does not support the timeout option. > The current implementation is silently ignoring the timeout option > by adding a general conntrack entry. > > This patch will skip the related test by overriding the support macro. > > Signed-off-by: Eelco Chaudron <echaudro@redhat.com> > Acked-by: Roi Dayan <roid@nvidia.com> > --- > tests/system-offloads.at | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/tests/system-offloads.at b/tests/system-offloads.at > index c8d1fd183..a9bfda164 100644 > --- a/tests/system-offloads.at > +++ b/tests/system-offloads.at > @@ -51,7 +51,6 @@ conntrack - IPv4 fragmentation with fragments specified > conntrack - IPv6 fragmentation + cvlan > conntrack - Fragmentation over vxlan > conntrack - IPv6 Fragmentation over vxlan > -conntrack - zone-based timeout policy > conntrack - multiple zones, local > conntrack - multi-stage pipeline, local > conntrack - ICMP related with NAT > the commit is missing the override macro for offloads in system-offloads.at +# Conntrack timeout not supported for tc. +m4_define([CHECK_CONNTRACK_TIMEOUT], +[ + AT_SKIP_IF([:]) +]) +
On 16 Nov 2022, at 14:32, Roi Dayan wrote: > On 15/11/2022 14:32, Eelco Chaudron wrote: >> The tc conntrack implementation does not support the timeout option. >> The current implementation is silently ignoring the timeout option >> by adding a general conntrack entry. >> >> This patch will skip the related test by overriding the support macro. >> >> Signed-off-by: Eelco Chaudron <echaudro@redhat.com> >> Acked-by: Roi Dayan <roid@nvidia.com> >> --- >> tests/system-offloads.at | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/tests/system-offloads.at b/tests/system-offloads.at >> index c8d1fd183..a9bfda164 100644 >> --- a/tests/system-offloads.at >> +++ b/tests/system-offloads.at >> @@ -51,7 +51,6 @@ conntrack - IPv4 fragmentation with fragments specified >> conntrack - IPv6 fragmentation + cvlan >> conntrack - Fragmentation over vxlan >> conntrack - IPv6 Fragmentation over vxlan >> -conntrack - zone-based timeout policy >> conntrack - multiple zones, local >> conntrack - multi-stage pipeline, local >> conntrack - ICMP related with NAT >> > > the commit is missing the override macro for offloads > in system-offloads.at > > > +# Conntrack timeout not supported for tc. > +m4_define([CHECK_CONNTRACK_TIMEOUT], > +[ > + AT_SKIP_IF([:]) > +]) > + Whoops, I messed up merging this to the new file :( Odd that the test where not failing, guess because I was only doing single runs :( Let me know once you are done with the series and do a long run over the weekend. Cheers, Eelco
On 16/11/2022 16:20, Eelco Chaudron wrote: > > > On 16 Nov 2022, at 14:32, Roi Dayan wrote: > >> On 15/11/2022 14:32, Eelco Chaudron wrote: >>> The tc conntrack implementation does not support the timeout option. >>> The current implementation is silently ignoring the timeout option >>> by adding a general conntrack entry. >>> >>> This patch will skip the related test by overriding the support macro. >>> >>> Signed-off-by: Eelco Chaudron <echaudro@redhat.com> >>> Acked-by: Roi Dayan <roid@nvidia.com> >>> --- >>> tests/system-offloads.at | 1 - >>> 1 file changed, 1 deletion(-) >>> >>> diff --git a/tests/system-offloads.at b/tests/system-offloads.at >>> index c8d1fd183..a9bfda164 100644 >>> --- a/tests/system-offloads.at >>> +++ b/tests/system-offloads.at >>> @@ -51,7 +51,6 @@ conntrack - IPv4 fragmentation with fragments specified >>> conntrack - IPv6 fragmentation + cvlan >>> conntrack - Fragmentation over vxlan >>> conntrack - IPv6 Fragmentation over vxlan >>> -conntrack - zone-based timeout policy >>> conntrack - multiple zones, local >>> conntrack - multi-stage pipeline, local >>> conntrack - ICMP related with NAT >>> >> >> the commit is missing the override macro for offloads >> in system-offloads.at >> >> >> +# Conntrack timeout not supported for tc. >> +m4_define([CHECK_CONNTRACK_TIMEOUT], >> +[ >> + AT_SKIP_IF([:]) >> +]) >> + > > Whoops, I messed up merging this to the new file :( Odd that the test where not failing, guess because I was only doing single runs :( > > Let me know once you are done with the series and do a long run over the weekend. > > Cheers, > > > Eelco > Hi, I'm done with this. we didn't notice new or suspected failures. Thanks, Roi
diff --git a/tests/system-offloads.at b/tests/system-offloads.at index c8d1fd183..a9bfda164 100644 --- a/tests/system-offloads.at +++ b/tests/system-offloads.at @@ -51,7 +51,6 @@ conntrack - IPv4 fragmentation with fragments specified conntrack - IPv6 fragmentation + cvlan conntrack - Fragmentation over vxlan conntrack - IPv6 Fragmentation over vxlan -conntrack - zone-based timeout policy conntrack - multiple zones, local conntrack - multi-stage pipeline, local conntrack - ICMP related with NAT