Message ID | 166238335537.2220027.7096564517002249191.stgit@ebuild |
---|---|
State | Superseded |
Headers | show |
Series | tests: Add system-traffic.at tests to check-offloads. | expand |
Context | Check | Description |
---|---|---|
ovsrobot/apply-robot | success | apply and check: success |
ovsrobot/github-robot-_Build_and_Test | success | github build: passed |
ovsrobot/intel-ovs-compilation | success | test: success |
On 05/09/2022 16:09, Eelco Chaudron wrote: > The tc conntrack implementation does not support the timeout option. > The current implementation is silently ignoring the timeout option > by adding a general conntrack entry. > > This patch will skip the related test by overriding the support macro. > > Signed-off-by: Eelco Chaudron <echaudro@redhat.com> > --- > tests/system-offloads-testsuite.at | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/tests/system-offloads-testsuite.at b/tests/system-offloads-testsuite.at > index 61c23717a..30b2bf60b 100644 > --- a/tests/system-offloads-testsuite.at > +++ b/tests/system-offloads-testsuite.at > @@ -61,6 +61,13 @@ m4_define([CHECK_CONNTRACK_ALG], > ]) > > > +# Conntrack timeout not supported for tc. > +m4_define([CHECK_CONNTRACK_TIMEOUT], > +[ > + AT_SKIP_IF([:]) > +]) > + > + > # The list below are tests that will not pass for a "test environment" specific > # issue. > m4_define([OVS_TEST_SKIP_LIST], > @@ -76,7 +83,6 @@ conntrack - IPv4 fragmentation with fragments specified > conntrack - IPv6 fragmentation + cvlan > conntrack - Fragmentation over vxlan > conntrack - IPv6 Fragmentation over vxlan > -conntrack - zone-based timeout policy > conntrack - multiple zones, local > conntrack - multi-stage pipeline, local > conntrack - ICMP related with NAT > > _______________________________________________ > dev mailing list > dev@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev Acked-by: Roi Dayan <roid@nvidia.com>
diff --git a/tests/system-offloads-testsuite.at b/tests/system-offloads-testsuite.at index 61c23717a..30b2bf60b 100644 --- a/tests/system-offloads-testsuite.at +++ b/tests/system-offloads-testsuite.at @@ -61,6 +61,13 @@ m4_define([CHECK_CONNTRACK_ALG], ]) +# Conntrack timeout not supported for tc. +m4_define([CHECK_CONNTRACK_TIMEOUT], +[ + AT_SKIP_IF([:]) +]) + + # The list below are tests that will not pass for a "test environment" specific # issue. m4_define([OVS_TEST_SKIP_LIST], @@ -76,7 +83,6 @@ conntrack - IPv4 fragmentation with fragments specified conntrack - IPv6 fragmentation + cvlan conntrack - Fragmentation over vxlan conntrack - IPv6 Fragmentation over vxlan -conntrack - zone-based timeout policy conntrack - multiple zones, local conntrack - multi-stage pipeline, local conntrack - ICMP related with NAT
The tc conntrack implementation does not support the timeout option. The current implementation is silently ignoring the timeout option by adding a general conntrack entry. This patch will skip the related test by overriding the support macro. Signed-off-by: Eelco Chaudron <echaudro@redhat.com> --- tests/system-offloads-testsuite.at | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-)