| Message ID | 1635742143-27780-1-git-send-email-wangyunjian@huawei.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [ovs-dev] ofproto-dpif-xlate: Add a trace log for tnl_port_build_header() error. | expand |
| Context | Check | Description |
|---|---|---|
| ovsrobot/apply-robot | success | apply and check: success |
| ovsrobot/github-robot-_Build_and_Test | success | github build: passed |
On 11/1/21 05:49, Yunjian Wang wrote: > It is useful to also log when tnl_port_build_header() failed. > > Signed-off-by: Yunjian Wang <wangyunjian@huawei.com> > --- > ofproto/ofproto-dpif-xlate.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/ofproto/ofproto-dpif-xlate.c b/ofproto/ofproto-dpif-xlate.c > index 9d336bc6a..a9c12a207 100644 > --- a/ofproto/ofproto-dpif-xlate.c > +++ b/ofproto/ofproto-dpif-xlate.c > @@ -3681,6 +3681,7 @@ native_tunnel_output(struct xlate_ctx *ctx, const struct xport *xport, > netdev_init_tnl_build_header_params(&tnl_params, flow, &s_ip6, dmac, smac); > err = tnl_port_build_header(xport->ofport, &tnl_push_data, &tnl_params); > if (err) { > + xlate_report(ctx, OFT_WARN, "native tunnel build header failed"); > return err; > } > tnl_push_data.tnl_port = tunnel_odp_port; > Applied. Thanks! Best regards, Ilya Maximets.
diff --git a/ofproto/ofproto-dpif-xlate.c b/ofproto/ofproto-dpif-xlate.c index 9d336bc6a..a9c12a207 100644 --- a/ofproto/ofproto-dpif-xlate.c +++ b/ofproto/ofproto-dpif-xlate.c @@ -3681,6 +3681,7 @@ native_tunnel_output(struct xlate_ctx *ctx, const struct xport *xport, netdev_init_tnl_build_header_params(&tnl_params, flow, &s_ip6, dmac, smac); err = tnl_port_build_header(xport->ofport, &tnl_push_data, &tnl_params); if (err) { + xlate_report(ctx, OFT_WARN, "native tunnel build header failed"); return err; } tnl_push_data.tnl_port = tunnel_odp_port;
It is useful to also log when tnl_port_build_header() failed. Signed-off-by: Yunjian Wang <wangyunjian@huawei.com> --- ofproto/ofproto-dpif-xlate.c | 1 + 1 file changed, 1 insertion(+)