diff mbox series

[ovs-dev,v2] dpif:Fix function pointer check for bond_add.

Message ID 1634799866-27516-1-git-send-email-somnath.b.chatterjee@ericsson.com
State Accepted
Headers show
Series [ovs-dev,v2] dpif:Fix function pointer check for bond_add. | expand

Checks

Context Check Description
ovsrobot/apply-robot success apply and check: success
ovsrobot/github-robot-_Build_and_Test success github build: passed

Commit Message

Somnath Chatterjee Oct. 21, 2021, 7:04 a.m. UTC 
There was typo in function pointer check in
dpif_bond_add() before calling bond_add()

Fixes: 9df65060cf4c ("userspace: Avoid dp_hash recirculation for balance-tcp bond mode.")
Signed-off-by: Somnath Chatterjee <somnath.b.chatterjee@ericsson.com>
---
 lib/dpif.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Kevin Traynor Oct. 21, 2021, 12:48 p.m. UTC | #1 
On 21/10/2021 08:04, Somnath Chatterjee wrote:
> There was typo in function pointer check in
> dpif_bond_add() before calling bond_add()
> 
> Fixes: 9df65060cf4c ("userspace: Avoid dp_hash recirculation for balance-tcp bond mode.")
> Signed-off-by: Somnath Chatterjee <somnath.b.chatterjee@ericsson.com>

Acked-by: Kevin Traynor <ktraynor@redhat.com>

> ---
>   lib/dpif.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/dpif.c b/lib/dpif.c
> index 8c4aed4..294b1c4 100644
> --- a/lib/dpif.c
> +++ b/lib/dpif.c
> @@ -2012,7 +2012,7 @@ dpif_meter_del(struct dpif *dpif, ofproto_meter_id meter_id,
>   int
>   dpif_bond_add(struct dpif *dpif, uint32_t bond_id, odp_port_t *member_map)
>   {
> -    return dpif->dpif_class->bond_del
> +    return dpif->dpif_class->bond_add
>              ? dpif->dpif_class->bond_add(dpif, bond_id, member_map)
>              : EOPNOTSUPP;
>   }
>
Ilya Maximets Nov. 3, 2021, 4:29 p.m. UTC | #2 
On 10/21/21 14:48, Kevin Traynor wrote:
> On 21/10/2021 08:04, Somnath Chatterjee wrote:
>> There was typo in function pointer check in
>> dpif_bond_add() before calling bond_add()
>>
>> Fixes: 9df65060cf4c ("userspace: Avoid dp_hash recirculation for balance-tcp bond mode.")
>> Signed-off-by: Somnath Chatterjee <somnath.b.chatterjee@ericsson.com>
> 
> Acked-by: Kevin Traynor <ktraynor@redhat.com>

Applied.  Thanks!

Best regards, Ilya Maximets.
diff mbox series

Patch

diff --git a/lib/dpif.c b/lib/dpif.c
index 8c4aed4..294b1c4 100644
--- a/lib/dpif.c
+++ b/lib/dpif.c
@@ -2012,7 +2012,7 @@  dpif_meter_del(struct dpif *dpif, ofproto_meter_id meter_id,
 int
 dpif_bond_add(struct dpif *dpif, uint32_t bond_id, odp_port_t *member_map)
 {
-    return dpif->dpif_class->bond_del
+    return dpif->dpif_class->bond_add
            ? dpif->dpif_class->bond_add(dpif, bond_id, member_map)
            : EOPNOTSUPP;
 }