From patchwork Mon Oct 18 11:02:37 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Somnath Chatterjee X-Patchwork-Id: 1542529 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=ericsson.com header.i=@ericsson.com header.a=rsa-sha256 header.s=selector1 header.b=N8TYhrMv; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org (client-ip=140.211.166.138; helo=smtp1.osuosl.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=) Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4HXvkD4PWJz9sRN for ; Mon, 18 Oct 2021 22:27:48 +1100 (AEDT) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id E52318291C; Mon, 18 Oct 2021 11:27:45 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id TmYt_i2TgIer; Mon, 18 Oct 2021 11:27:45 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [IPv6:2605:bc80:3010:104::8cd3:938]) by smtp1.osuosl.org (Postfix) with ESMTPS id 320CF82560; Mon, 18 Oct 2021 11:27:44 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id EAFEDC000F; Mon, 18 Oct 2021 11:27:43 +0000 (UTC) X-Original-To: ovs-dev@openvswitch.org Delivered-To: ovs-dev@lists.linuxfoundation.org Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by lists.linuxfoundation.org (Postfix) with ESMTP id 163B9C000D for ; Mon, 18 Oct 2021 11:27:42 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 0C0F0404C4 for ; Mon, 18 Oct 2021 11:27:42 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Authentication-Results: smtp4.osuosl.org (amavisd-new); dkim=pass (1024-bit key) header.d=ericsson.com Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id H51QqULV7Uc4 for ; Mon, 18 Oct 2021 11:27:40 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.8.0 Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-eopbgr10059.outbound.protection.outlook.com [40.107.1.59]) by smtp4.osuosl.org (Postfix) with ESMTPS id 7CB7A404C1 for ; Mon, 18 Oct 2021 11:27:40 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SWJ41wjPrWzmbHEhDZmkjWZcJOkvct2K+EtKm2vUPcWZbaCaBmK42MTWpo6yEGCnKP5gZrmLXMEUkdp9jnJx0diGoU48JNTicqzqFW2V1n0TRWnasEm7B+z+rq5K0OLvyogfvDmXtd2B/o11nwSpO4+EYqPKMdwU2VQ17APHW47Q0hIyRd57F6sEnjKueQFvikOqaZGu2dqrZK+6xdMTt5JZrup5E1MmhLVGFWci+L33GkObTj2lQad9yuNPSHJZ5hqcXfT9h6BiYGxUzZf/dQWZj6aCmK4Pp07fLQAoFLYUC7rnrwrapuYllDyiH1EWNjhqUXxd//1rn2pDtfb/lw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=i3ql2CA1bnByzH59maD84kyG+Y/R2aA8Usz/FkWM3Ks=; b=Yh7wD2Am6VujPloCPiljlVJe76qAFeocwJrGhI0vbo1YBD3Dm5gBewXRPKJ/s4D8wR2UmY4kifOFXhhfhMhUPZmIx5G3IWtik5GroQujhTkNz/wPWNAcS44dn1t2E65180sigYx1XBpw/UQKu4cJU9lvE6W2eKL9qvX1MN31cUF42ltyC7pAwn/JBeo4QYRZ6g8zNnQTE6z6sMSwN2ZfY+WX+Rf7WSj15ZySaCLtnZyaTN3YZNrah0fcMOrI6Pk/Er/1Se8tH0hs+zLTskVjHhyztnm1j6C5v4ympxx5iQzdVhPSxe56LE/Yy9P0fZpWGwGi02VLnpxOT4TbP5P6Cg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 192.176.1.74) smtp.rcpttodomain=openvswitch.org smtp.mailfrom=ericsson.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=ericsson.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericsson.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=i3ql2CA1bnByzH59maD84kyG+Y/R2aA8Usz/FkWM3Ks=; b=N8TYhrMvI5DD6QSkNcZvdmgd7GfDhVNRQVUD+/OvmbK7V+xaXvn8K+WLtiEO/GLHexylzGFiNMyGw2L6QSu3RIFnaW32qJtzz/EHqMiezR5ZyrJdMB7yG7LmpPzDRV5/FIpnvxdRMZZXP61aSn/BpAeb/bUC5IdFQozAuAkI1xg= Received: from AM6PR02CA0019.eurprd02.prod.outlook.com (2603:10a6:20b:6e::32) by AM6PR07MB5174.eurprd07.prod.outlook.com (2603:10a6:20b:69::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.13; Mon, 18 Oct 2021 11:27:37 +0000 Received: from AM5EUR02FT046.eop-EUR02.prod.protection.outlook.com (2603:10a6:20b:6e:cafe::16) by AM6PR02CA0019.outlook.office365.com (2603:10a6:20b:6e::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.16 via Frontend Transport; Mon, 18 Oct 2021 11:27:37 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 192.176.1.74) smtp.mailfrom=ericsson.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=ericsson.com; Received-SPF: Pass (protection.outlook.com: domain of ericsson.com designates 192.176.1.74 as permitted sender) receiver=protection.outlook.com; client-ip=192.176.1.74; helo=oa.msg.ericsson.com; Received: from oa.msg.ericsson.com (192.176.1.74) by AM5EUR02FT046.mail.protection.outlook.com (10.152.8.221) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.20.4608.15 via Frontend Transport; Mon, 18 Oct 2021 11:27:35 +0000 Received: from ESESSMB501.ericsson.se (153.88.183.162) by ESESSMR504.ericsson.se (153.88.183.126) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2242.12; Mon, 18 Oct 2021 13:27:35 +0200 Received: from localhost.localdomain (153.88.183.153) by ESESSMB501.ericsson.se (153.88.183.162) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2242.12; Mon, 18 Oct 2021 13:27:34 +0200 To: Date: Mon, 18 Oct 2021 13:02:37 +0200 Message-ID: <1634554957-25556-1-git-send-email-somnath.b.chatterjee@ericsson.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 X-ClientProxiedBy: ESESBMB504.ericsson.se (153.88.183.171) To ESESSMB501.ericsson.se (153.88.183.162) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 58a67207-446d-45b9-34f4-08d9922a48fc X-MS-TrafficTypeDiagnostic: AM6PR07MB5174: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:1728; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: hHkYTt2ELyhqD2ZpJUPKV6xNjFUQDsv6Yj9Vk13vC+sV9QS0H4TS0eyI3gN2Zsy/8Gt2++wVHxnCdcENdreUEbMtEex6kWe0ATf02d0zhXm4+5tw71uWntwgH292/P6LPxgGajBJpfdA8KBnJk2nVjEx60mzQH29vyRz8AzxeFWqq8UOlw8Vdst7nIYKni9xORLz+WvpSwl6b2u4olNtSs4I78PJ5LoeX0EiAs9pa6LFdLAobEdiXo3n46dNa5nYPHmZQ2VE1cLcLIZYk6v38GvsBe69uGkXGKrCWWe05EM2Zl1f72c+iHL8e5Bja5gf/ZxA1IPjLTpPyHKjeQSRsIfS4G/PeQKcCCgtkmM4qNy20aScEa4bvnX5qMscgT1CUnQYqblNFYt8/c6p7d5If9tdqGHunq+HxM34GUrsTm3VelLTiRBc0BLgxVou2d1s72MMJ6pDwz4RuTm8XsGTtGTV1qHzFYeIhpfXJovs2sHVfpZqMEECGL+X6NJIsxaAiS37VVn81a+sI8HNqeqc8/4h8SGBr2KzARbWg416LTbUV5UFCKssAESaECmLEop4/xuD/Sp1DkxUpiM/AkTL6AnqL/DjbVyun8DkYlN8dDKhcfw4FNx9X2COcv1QdGlEQVwD6aASABhtI+Q3vGzVav54eTYcOSxH4SMAUknOCNhweJ0i+5n8pGXb2sHj5GZoKilo/qhrr+YtN0wezzr1jT+WSfQkT+c9Ol+de8jc7+I= X-Forefront-Antispam-Report: CIP:192.176.1.74; CTRY:SE; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:oa.msg.ericsson.com; PTR:office365.se.ericsson.net; CAT:NONE; SFS:(4636009)(46966006)(36840700001)(5660300002)(70586007)(26005)(70206006)(34020700004)(508600001)(82960400001)(336012)(107886003)(6916009)(83380400001)(8676002)(316002)(186003)(86362001)(4326008)(956004)(356005)(36860700001)(54906003)(2616005)(36756003)(47076005)(8936002)(2906002)(82310400003)(7636003)(4744005); DIR:OUT; SFP:1101; X-OriginatorOrg: ericsson.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2021 11:27:35.9756 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 58a67207-446d-45b9-34f4-08d9922a48fc X-MS-Exchange-CrossTenant-Id: 92e84ceb-fbfd-47ab-be52-080c6b87953f X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=92e84ceb-fbfd-47ab-be52-080c6b87953f; Ip=[192.176.1.74]; Helo=[oa.msg.ericsson.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR02FT046.eop-EUR02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR07MB5174 Cc: Somnath Chatterjee Subject: [ovs-dev] [PATCH] dpif:Fix function pointer check for bond_add. X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Somnath Chatterjee via dev From: Somnath Chatterjee Reply-To: Somnath Chatterjee Errors-To: ovs-dev-bounces@openvswitch.org Sender: "dev" There was typo in function pointer check in dpif_bond_add() before calling bond_add() Fixes: 9df65060cf4c ("userspace: Avoid dp_hash recirculation for balance-tcp bond mode.") Signed-off-by: Somnath Chatterjee --- lib/dpif.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/dpif.c b/lib/dpif.c index 8c4aed4..294b1c4 100644 --- a/lib/dpif.c +++ b/lib/dpif.c @@ -2012,7 +2012,7 @@ dpif_meter_del(struct dpif *dpif, ofproto_meter_id meter_id, int dpif_bond_add(struct dpif *dpif, uint32_t bond_id, odp_port_t *member_map) { - return dpif->dpif_class->bond_del + return dpif->dpif_class->bond_add ? dpif->dpif_class->bond_add(dpif, bond_id, member_map) : EOPNOTSUPP; }