| Message ID | 1634208052-20048-1-git-send-email-somnath.b.chatterjee@ericsson.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [ovs-dev] dpif:Fix function pointer check for bond_add. | expand |
| Context | Check | Description |
|---|---|---|
| ovsrobot/apply-robot | success | apply and check: success |
| ovsrobot/github-robot-_Build_and_Test | success | github build: passed |
Hi Somnath, On 14/10/2021 11:40, Somnath Chatterjee via dev wrote: > There was typo in function pointer check in > dpif_bond_add() before calling bond_add() > You need to add a reference to the fixed commit at this point as per comment on v1. If you take a look at the git repo and search for 'Fixes' you can see how it is for other fixes. This helps the maintainers to know which branches the fix should be backported to. For this fix, it should be (without line wrap): Fixes: 9df65060cf4c ("userspace: Avoid dp_hash recirculation for balance-tcp bond mode.") > Signed-off-by: Somnath Chatterjee <somnath.b.chatterjee@ericsson.com> > --- > lib/dpif.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/dpif.c b/lib/dpif.c > index 8c4aed4..294b1c4 100644 > --- a/lib/dpif.c > +++ b/lib/dpif.c > @@ -2012,7 +2012,7 @@ dpif_meter_del(struct dpif *dpif, ofproto_meter_id meter_id, > int > dpif_bond_add(struct dpif *dpif, uint32_t bond_id, odp_port_t *member_map) > { > - return dpif->dpif_class->bond_del > + return dpif->dpif_class->bond_add > ? dpif->dpif_class->bond_add(dpif, bond_id, member_map) > : EOPNOTSUPP; > } > A few tips for the mailing list. For a second version of the patch the subject should have [PATCH v2] as it's prefix, and so on for further versions. You can do this with the git format-patch flag --subject-prefix='PATCH v2' . Also, it is good to add reviewers from one version as cc to subsequent versions as they may miss them on the mailing list, you can do this with the git send-email flag --cc=<email_addr>. thanks, Kevin.
diff --git a/lib/dpif.c b/lib/dpif.c index 8c4aed4..294b1c4 100644 --- a/lib/dpif.c +++ b/lib/dpif.c @@ -2012,7 +2012,7 @@ dpif_meter_del(struct dpif *dpif, ofproto_meter_id meter_id, int dpif_bond_add(struct dpif *dpif, uint32_t bond_id, odp_port_t *member_map) { - return dpif->dpif_class->bond_del + return dpif->dpif_class->bond_add ? dpif->dpif_class->bond_add(dpif, bond_id, member_map) : EOPNOTSUPP; }
There was typo in function pointer check in dpif_bond_add() before calling bond_add() Signed-off-by: Somnath Chatterjee <somnath.b.chatterjee@ericsson.com> --- lib/dpif.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)