diff mbox series

[ovs-dev,V2] rhel: ovs-kmod-manage.sh: Disable unneeded warning

Message ID 1597960601-10306-1-git-send-email-gvrose8192@gmail.com
State New
Headers show
Series [ovs-dev,V2] rhel: ovs-kmod-manage.sh: Disable unneeded warning | expand

Commit Message

Gregory Rose Aug. 20, 2020, 9:56 p.m. UTC
The script itself says which versions the script is needed for but
it is run on RHEL 8.x as well where it is not needed.  Disable the
warning and change the exit code to zero since it may unnecessarily
alarm users and is really only for debugging anyway.

Signed-off-by: Greg Rose <gvrose8192@gmail.com>
---

V2 - As per Yi-Hung's suggestion change exit code to zero.
---
 rhel/usr_share_openvswitch_scripts_ovs-kmod-manage.sh | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Yi-Hung Wei Aug. 20, 2020, 10:27 p.m. UTC | #1
On Thu, Aug 20, 2020 at 2:56 PM Greg Rose <gvrose8192@gmail.com> wrote:
>
> The script itself says which versions the script is needed for but
> it is run on RHEL 8.x as well where it is not needed.  Disable the
> warning and change the exit code to zero since it may unnecessarily
> alarm users and is really only for debugging anyway.
>
> Signed-off-by: Greg Rose <gvrose8192@gmail.com>
> ---
>
> V2 - As per Yi-Hung's suggestion change exit code to zero.
> ---

LGTM

Acked-by: Yi-Hung Wei <yihung.wei@gmail.com>
diff mbox series

Patch

diff --git a/rhel/usr_share_openvswitch_scripts_ovs-kmod-manage.sh b/rhel/usr_share_openvswitch_scripts_ovs-kmod-manage.sh
index c70e135..bb0d909 100644
--- a/rhel/usr_share_openvswitch_scripts_ovs-kmod-manage.sh
+++ b/rhel/usr_share_openvswitch_scripts_ovs-kmod-manage.sh
@@ -136,8 +136,8 @@  elif [ "$mainline_major" = "4" ] && [ "$mainline_minor" = "12" ]; then
 fi
 
 if [ X"$ver_offset" = X ]; then
-    echo "This script is not intended to run on kernel $(uname -r)"
-    exit 1
+#    echo "This script is not intended to run on kernel $(uname -r)"
+    exit 0
 fi
 
 #IFS='.\|-' read -r -a version_nums <<<"${current_kernel}"