| Message ID | 1569930422-19453-2-git-send-email-david.marchand@redhat.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [ovs-dev,dpdk-latest,1/2] sparse: Get rid of obsolete rte_flow header. | expand |
On 01.10.2019 14:47, David Marchand wrote: > Make this branch point to current dpdk master branch so that we can > track API breakage and benefit from the latest enhancements. > > Signed-off-by: David Marchand <david.marchand@redhat.com> > --- > .travis.yml | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/.travis.yml b/.travis.yml > index 6802631..416b5bc 100644 > --- a/.travis.yml > +++ b/.travis.yml > @@ -34,14 +34,14 @@ env: > - OPTS="--disable-ssl" > - TESTSUITE=1 KERNEL=3.16 > - TESTSUITE=1 OPTS="--enable-shared" > - - TESTSUITE=1 DPDK=1 > + - TESTSUITE=1 DPDK=1 DPDK_VER=refs/heads/master > - TESTSUITE=1 LIBS=-ljemalloc > - KERNEL_LIST="5.0 4.20 4.19 4.18 4.17 4.16" > - KERNEL_LIST="4.15 4.14 4.9 4.4 3.19 3.16" > - BUILD_ENV="-m32" OPTS="--disable-ssl" > - - DPDK=1 OPTS="--enable-shared" > - - DPDK_SHARED=1 > - - DPDK_SHARED=1 OPTS="--enable-shared" > + - DPDK=1 DPDK_VER=refs/heads/master OPTS="--enable-shared" > + - DPDK_SHARED=1 DPDK_VER=refs/heads/master > + - DPDK_SHARED=1 DPDK_VER=refs/heads/master OPTS="--enable-shared" Hi David. Thanks for the patch. It looks fine, but it might be better to just export DPDK_VER=refs/heads/master in the 'before_script:' section like we're exporting PATH. This will be less invasive and easier to maintain. What do you think? Best regards, Ilya Maximets.
On Thu, Oct 3, 2019 at 6:00 PM Ilya Maximets <i.maximets@ovn.org> wrote: > > On 01.10.2019 14:47, David Marchand wrote: > > Make this branch point to current dpdk master branch so that we can > > track API breakage and benefit from the latest enhancements. > > > > Signed-off-by: David Marchand <david.marchand@redhat.com> > > --- > > .travis.yml | 8 ++++---- > > 1 file changed, 4 insertions(+), 4 deletions(-) > > > > diff --git a/.travis.yml b/.travis.yml > > index 6802631..416b5bc 100644 > > --- a/.travis.yml > > +++ b/.travis.yml > > @@ -34,14 +34,14 @@ env: > > - OPTS="--disable-ssl" > > - TESTSUITE=1 KERNEL=3.16 > > - TESTSUITE=1 OPTS="--enable-shared" > > - - TESTSUITE=1 DPDK=1 > > + - TESTSUITE=1 DPDK=1 DPDK_VER=refs/heads/master > > - TESTSUITE=1 LIBS=-ljemalloc > > - KERNEL_LIST="5.0 4.20 4.19 4.18 4.17 4.16" > > - KERNEL_LIST="4.15 4.14 4.9 4.4 3.19 3.16" > > - BUILD_ENV="-m32" OPTS="--disable-ssl" > > - - DPDK=1 OPTS="--enable-shared" > > - - DPDK_SHARED=1 > > - - DPDK_SHARED=1 OPTS="--enable-shared" > > + - DPDK=1 DPDK_VER=refs/heads/master OPTS="--enable-shared" > > + - DPDK_SHARED=1 DPDK_VER=refs/heads/master > > + - DPDK_SHARED=1 DPDK_VER=refs/heads/master OPTS="--enable-shared" > > Hi David. > Thanks for the patch. > > It looks fine, but it might be better to just export > DPDK_VER=refs/heads/master in the 'before_script:' > section like we're exporting PATH. This will be less > invasive and easier to maintain. > What do you think? Hello Ilya, Looks fine, let me try it and send a v2.
diff --git a/.travis.yml b/.travis.yml index 6802631..416b5bc 100644 --- a/.travis.yml +++ b/.travis.yml @@ -34,14 +34,14 @@ env: - OPTS="--disable-ssl" - TESTSUITE=1 KERNEL=3.16 - TESTSUITE=1 OPTS="--enable-shared" - - TESTSUITE=1 DPDK=1 + - TESTSUITE=1 DPDK=1 DPDK_VER=refs/heads/master - TESTSUITE=1 LIBS=-ljemalloc - KERNEL_LIST="5.0 4.20 4.19 4.18 4.17 4.16" - KERNEL_LIST="4.15 4.14 4.9 4.4 3.19 3.16" - BUILD_ENV="-m32" OPTS="--disable-ssl" - - DPDK=1 OPTS="--enable-shared" - - DPDK_SHARED=1 - - DPDK_SHARED=1 OPTS="--enable-shared" + - DPDK=1 DPDK_VER=refs/heads/master OPTS="--enable-shared" + - DPDK_SHARED=1 DPDK_VER=refs/heads/master + - DPDK_SHARED=1 DPDK_VER=refs/heads/master OPTS="--enable-shared" matrix: include:
Make this branch point to current dpdk master branch so that we can track API breakage and benefit from the latest enhancements. Signed-off-by: David Marchand <david.marchand@redhat.com> --- .travis.yml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)