From patchwork Wed Jul 31 10:43:01 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Damijan Skvarc X-Patchwork-Id: 1139672 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=openvswitch.org (client-ip=140.211.169.12; helo=mail.linuxfoundation.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="lEHYnnLo"; dkim-atps=neutral Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 45z9Kn5jZQz9sML for ; Wed, 31 Jul 2019 20:54:36 +1000 (AEST) Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id C47783BC3; Wed, 31 Jul 2019 10:54:32 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@mail.linuxfoundation.org Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id C5CE73BA8 for ; Wed, 31 Jul 2019 10:43:10 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.7.6 Received: from mail-ed1-f66.google.com (mail-ed1-f66.google.com [209.85.208.66]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id 486AEA8 for ; Wed, 31 Jul 2019 10:43:10 +0000 (UTC) Received: by mail-ed1-f66.google.com with SMTP id i11so1764052edq.0 for ; Wed, 31 Jul 2019 03:43:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=gOqbvYHkpPIuVnCyYsbxTOVl++7deaabVxJT/OxnGZU=; b=lEHYnnLo0zFWhywoGUA3CNOI0Srd3hQo6LS21JQpvUfg3YkYCtLHG0pnkU4YonVRGl XFp5g19EBdrZqg7bT9ktFw/rGBdL3txFbdAwpqLHtpPpC/fQZbm2j1bE86jNN2P3mvca +F6F2K7y4cSDTxknlj1yGi4ulfLN53uE7LuiyJvRQ85zUX0mjqP0DH+rwyv2ouqjbip4 32EXVy9/CZKN1zQdpu+Lm33wSoI6qRVVflQwsPvjvcTWx0Z3XtUTwRsLM4UFtBQSunls Ivjq/RkpWsvXitBpBo4cby4/JML33R3NxryWZ1aN2/aQijmAFbeXX1qYoicGJp74jY3k FrVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=gOqbvYHkpPIuVnCyYsbxTOVl++7deaabVxJT/OxnGZU=; b=etnT10FKOqFRnAsw7WK+aHnWLSiSRV1hXXjrH8Ktlod9EEO/bO+7wEW3QvGmEKAApW K+Mnz4shCVQBWuzCoiXx7v+/Zt2Z2syE0vpmuuQmk5oVwDIrgdCdV/ZqpVjg/G2jNEw9 mjPx6OezZ3Thw8SZ3rz/IJpBuljYrJkHbLauc+dzxbzAJzGiuAr4CfKaXmQ3tqsgjaNi U+4/H82tJy5DkVyZgMp1kAaUBk2eMKqDb99vxuDfUEyaz7XPhAf/vxEPTqrynbjw+3OJ dW0AfdGXuwE1t8mRPOrPRTi9eVHYi5DINY19nhmBUZO2kSFKlQk0S2KuqRI7OtqkbOv0 dOMQ== X-Gm-Message-State: APjAAAVgpy6ga9oI1lBq5tkGGuCAFdP6fZpzZ7xvoRHM5Q6m1VzPFrjf mCzHwSA7jGxiLwsZzE0EJBqTsg9S X-Google-Smtp-Source: APXvYqx35HZDG+zGAEUWe3s+nOJn2SBu8QOD4h8FKjiaYcPaa/Qol2Bf0srCPBxF1T526fV5Xif41g== X-Received: by 2002:a17:906:6c85:: with SMTP id s5mr94331033ejr.199.1564569788479; Wed, 31 Jul 2019 03:43:08 -0700 (PDT) Received: from damijan-PC.i-tech.local (mail.i-tech.si. [89.212.78.105]) by smtp.gmail.com with ESMTPSA id t2sm17269784eda.95.2019.07.31.03.43.06 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 31 Jul 2019 03:43:07 -0700 (PDT) From: Damijan Skvarc To: dev@openvswitch.org Date: Wed, 31 Jul 2019 12:43:01 +0200 Message-Id: <1564569781-15676-1-git-send-email-damjan.skvarc@gmail.com> X-Mailer: git-send-email 2.7.4 X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on smtp1.linux-foundation.org Subject: [ovs-dev] [PATCH 1/1] ovn-northd: fix memory leak in add_distributed_nat_routes() function X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: ovs-dev-bounces@openvswitch.org Errors-To: ovs-dev-bounces@openvswitch.org Within this function actions & match dynamic strings are used as helper variables for adding entries into logical flow table. Variables are used several times in order to optimize number of memory allocations, however at the end memory was forgotten to be deallocated. Signed-off-by: Damijan Skvarc Acked-by: Mark Michelson --- northd/ovn-northd.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/northd/ovn-northd.c b/northd/ovn-northd.c index 979dea4..8588961 100644 --- a/northd/ovn-northd.c +++ b/northd/ovn-northd.c @@ -5667,6 +5667,8 @@ add_distributed_nat_routes(struct hmap *lflows, const struct ovn_port *op) ds_clear(&actions); } } + ds_destroy(&match); + ds_destroy(&actions); } static void