From patchwork Fri Jul 5 11:38:47 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Damijan Skvarc X-Patchwork-Id: 1127986 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=openvswitch.org (client-ip=140.211.169.12; helo=mail.linuxfoundation.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="LJJsmfRy"; dkim-atps=neutral Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 45gCY26Ckbz9sNp for ; Fri, 5 Jul 2019 21:39:00 +1000 (AEST) Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id D3E4011C2; Fri, 5 Jul 2019 11:38:56 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@mail.linuxfoundation.org Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id 2181B1198 for ; Fri, 5 Jul 2019 11:38:55 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.7.6 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id AA1888B2 for ; Fri, 5 Jul 2019 11:38:54 +0000 (UTC) Received: by mail-wm1-f53.google.com with SMTP id w9so7287885wmd.1 for ; Fri, 05 Jul 2019 04:38:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=95jNq205ZHGJdH/7LGZFRa2aczPQw9HHllZpX0sE9/8=; b=LJJsmfRy+H8M+t1WhwJV1KiI9XOJ3JDmD/uDLku754I6uZEOMU9Nb0OGk+k+7+8NsE wsPKubqdtOHMSCE0Wy2O6ruowk+EAun9AlKjjl3COG2nx3wauI+0T5LJpVq5l+PvnlDL Y5YOh4gF4kyLN9BuVfUGF/Y2An/7nLpYuzJzVbIXWW5FXclIXlMpVLExJDqhO2uUD5OB +bWrrIDP1/todAMRtsO9wwadWxCZGOEF1f1/RQvVId9tt0X2vPX0zUu62MTJgjRtw4KX mVazsuBo4KvwAjucCbWvV0JbjT1jg9VVh/lT59hKESlcrUP4b770Q2vhJ+Lxr/WwGm6G CAlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=95jNq205ZHGJdH/7LGZFRa2aczPQw9HHllZpX0sE9/8=; b=XPK/l4IA9XJcKbY536he7Mr9poUTAv+lnvheloyrkZg0KQs+9BU9lRE511wjwpXBxH OdGv2x2Gkdq0Q8RUkB31eGLq0dwPf1io3sPoai0+iGvTE1m2il6Ubh1t93vucPTfyYBR zcGymNuDSi9zQKoj2YrYjKCoV7eC82yPkupU9G2L/oCzDMV0CULmD3gEjXQgpgI/GIS3 r5g9NSiTkehWJUA5ru8lzsX1jyKjy8wc/KX5WzMKDnF1FMKbWRsN+nUSrRGE6dJpPD6r eix3fessWuYvuSnTFrmcLJ7k2OgKr+7DqSDMKig9f8gdfoDTdeKSX9g3tIwyoC9EYB1z EB1g== X-Gm-Message-State: APjAAAVrvde8T5Bc9kEavmKV81KeebRLoJpv38iQlHL7IIjh2NVRAKm8 oQwXGpfeBfbL7uIstp6jpvRCbN2n X-Google-Smtp-Source: APXvYqyKgjKz+9cCCk4qEThZWucx35lq0D2yxuCb9N3Ni/poE4y2IblGuHiRQ4YeqK4rbOxd2irohg== X-Received: by 2002:a1c:3:: with SMTP id 3mr3319456wma.6.1562326732910; Fri, 05 Jul 2019 04:38:52 -0700 (PDT) Received: from damijan-PC.i-tech.local (mail.i-tech.si. [89.212.78.105]) by smtp.gmail.com with ESMTPSA id b8sm2674918wrv.78.2019.07.05.04.38.50 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 05 Jul 2019 04:38:52 -0700 (PDT) From: Damijan Skvarc To: dev@openvswitch.org Date: Fri, 5 Jul 2019 13:38:47 +0200 Message-Id: <1562326727-31933-1-git-send-email-damjan.skvarc@gmail.com> X-Mailer: git-send-email 2.7.4 X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on smtp1.linux-foundation.org Subject: [ovs-dev] [PATCH 1/1] db-ctl-base: fix memory leak in cmd-get() function X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: ovs-dev-bounces@openvswitch.org Errors-To: ovs-dev-bounces@openvswitch.org Memory leak occured in case specified key was not found in table record. Signed-off-by: Damijan Skvarc --- lib/db-ctl-base.c | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/db-ctl-base.c b/lib/db-ctl-base.c index fc09293..3bd9f00 100644 --- a/lib/db-ctl-base.c +++ b/lib/db-ctl-base.c @@ -986,6 +986,7 @@ cmd_get(struct ctl_context *ctx) ctx, "no key \"%s\" in %s record \"%s\" column %s", key_string, table->name, record_id, column->name); free(key_string); + ovsdb_atom_destroy(&key, column->type.key.type); return; } } else {