diff mbox series

[ovs-dev,v1,1/1] dpdk: Use DPDK 18.11.2 release.

Message ID 1561035625-5933-1-git-send-email-ian.stokes@intel.com
State Changes Requested
Headers show
Series [ovs-dev,v1,1/1] dpdk: Use DPDK 18.11.2 release. | expand

Commit Message

Stokes, Ian June 20, 2019, 1 p.m. UTC
Modify travis linux build script to use the latest DPDK stable release
18.11.2. Update docs for latest DPDK stable releases.

Note: due to commit [1] in DPDK 18.11.2, the behaviour of the vhost
destroy callback has changed. DPDK 18.11.2 is now the default DPDK
release currently supported. DPDK 18.11.1 and below are no longer
supported.

[1] 2b4e951cc341 ("vhost: fix passing destroyed device to destroy
callback")

Signed-off-by: Ian Stokes <ian.stokes@intel.com>
---
 .travis/linux-build.sh                   | 2 +-
 Documentation/faq/releases.rst           | 2 +-
 Documentation/intro/install/dpdk.rst     | 8 ++++----
 Documentation/topics/dpdk/vhost-user.rst | 6 +++---
 NEWS                                     | 4 +++-
 5 files changed, 12 insertions(+), 10 deletions(-)

Comments

Stokes, Ian June 20, 2019, 1:16 p.m. UTC | #1
> Modify travis linux build script to use the latest DPDK stable release
> 18.11.2. Update docs for latest DPDK stable releases.
> 
> Note: due to commit [1] in DPDK 18.11.2, the behaviour of the vhost
> destroy callback has changed. DPDK 18.11.2 is now the default DPDK
> release currently supported. DPDK 18.11.1 and below are no longer
> supported.
> 
> [1] 2b4e951cc341 ("vhost: fix passing destroyed device to destroy
> callback")
> 
> Signed-off-by: Ian Stokes <ian.stokes@intel.com>
> ---
>  .travis/linux-build.sh                   | 2 +-
>  Documentation/faq/releases.rst           | 2 +-
>  Documentation/intro/install/dpdk.rst     | 8 ++++----
>  Documentation/topics/dpdk/vhost-user.rst | 6 +++---
>  NEWS                                     | 4 +++-
>  5 files changed, 12 insertions(+), 10 deletions(-)
> 
> diff --git a/.travis/linux-build.sh b/.travis/linux-build.sh
> index 9d84411c5..17428fa6b 100755
> --- a/.travis/linux-build.sh
> +++ b/.travis/linux-build.sh
> @@ -105,7 +105,7 @@ fi
> 
>  if [ "$DPDK" ] || [ "$DPDK_SHARED" ]; then
>      if [ -z "$DPDK_VER" ]; then
> -        DPDK_VER="18.11.1"
> +        DPDK_VER="18.11.2"
>      fi
>      install_dpdk $DPDK_VER
>      if [ "$CC" = "clang" ]; then
> diff --git a/Documentation/faq/releases.rst
> b/Documentation/faq/releases.rst
> index d9504d682..723d95f2f 100644
> --- a/Documentation/faq/releases.rst
> +++ b/Documentation/faq/releases.rst
> @@ -177,7 +177,7 @@ Q: What DPDK version does each Open vSwitch release
> work with?
>      2.8.x        17.05.2
>      2.9.x        17.11.4
>      2.10.x       17.11.4
> -    2.11.x       18.11.1
> +    2.11.x       18.11.2
>      ============ =======
> 
>  Q: Are all the DPDK releases that OVS versions work with maintained?
> diff --git a/Documentation/intro/install/dpdk.rst
> b/Documentation/intro/install/dpdk.rst
> index 149548bc1..6e5f1ea60 100644
> --- a/Documentation/intro/install/dpdk.rst
> +++ b/Documentation/intro/install/dpdk.rst
> @@ -42,7 +42,7 @@ Build requirements
>  In addition to the requirements described in :doc:`general`, building
> Open
>  vSwitch with DPDK will require the following:
> 
> -- DPDK 18.11.1
> +- DPDK 18.11.2
> 
>  - A `DPDK supported NIC`_
> 
> @@ -71,9 +71,9 @@ Install DPDK
>  #. Download the `DPDK sources`_, extract the file and set ``DPDK_DIR``::
> 
>         $ cd /usr/src/
> -       $ wget http://fast.dpdk.org/rel/dpdk-18.11.1.tar.xz
> -       $ tar xf dpdk-18.11.1.tar.xz
> -       $ export DPDK_DIR=/usr/src/dpdk-stable-18.11.1
> +       $ wget http://fast.dpdk.org/rel/dpdk-18.11.2.tar.xz
> +       $ tar xf dpdk-18.11.2.tar.xz
> +       $ export DPDK_DIR=/usr/src/dpdk-stable-18.11.2
>         $ cd $DPDK_DIR
> 
>  #. (Optional) Configure DPDK as a shared library
> diff --git a/Documentation/topics/dpdk/vhost-user.rst
> b/Documentation/topics/dpdk/vhost-user.rst
> index f7b4b338e..ac5f46c43 100644
> --- a/Documentation/topics/dpdk/vhost-user.rst
> +++ b/Documentation/topics/dpdk/vhost-user.rst
> @@ -367,9 +367,9 @@ To begin, instantiate a guest as described in
> :ref:`dpdk-vhost-user` or
>  DPDK sources to VM and build DPDK::
> 
>      $ cd /root/dpdk/
> -    $ wget http://fast.dpdk.org/rel/dpdk-18.11.1.tar.xz
> -    $ tar xf dpdk-18.11.1.tar.xz
> -    $ export DPDK_DIR=/root/dpdk/dpdk-stable-18.11.1
> +    $ wget http://fast.dpdk.org/rel/dpdk-18.11.2.tar.xz
> +    $ tar xf dpdk-18.11.2.tar.xz
> +    $ export DPDK_DIR=/root/dpdk/dpdk-stable-18.11.2
>      $ export DPDK_TARGET=x86_64-native-linuxapp-gcc
>      $ export DPDK_BUILD=$DPDK_DIR/$DPDK_TARGET
>      $ cd $DPDK_DIR
> diff --git a/NEWS b/NEWS
> index a38ab258f..4c6dc3124 100644
> --- a/NEWS
> +++ b/NEWS
> @@ -4,7 +4,9 @@ Post-v2.11.0
>       * New option 'other_config:dpdk-socket-limit' to limit amount of
>         hugepage memory that can be used by DPDK.
>       * Add support for vHost Post-copy Live Migration (experimental).
> -     * OVS validated with DPDK 18.11.1 which is recommended to be used.
> +     * DPDK:

Just spotted that the additional * DPDK above is unneeded, will spin a v2 if there any other comments.

Ian
> +       - DPDK 18.11.2 is the new minimal supported version.
> +       - DPDK 18.11.1 and lower is no longer supported.
>     - OpenFlow:
>       * Removed support for OpenFlow 1.6 (draft), which ONF abandoned.
>       * New action "check_pkt_larger".
> --
> 2.13.6
Ilya Maximets June 20, 2019, 1:38 p.m. UTC | #2
On 20.06.2019 16:16, Stokes, Ian wrote:
>> Modify travis linux build script to use the latest DPDK stable release
>> 18.11.2. Update docs for latest DPDK stable releases.
>>
>> Note: due to commit [1] in DPDK 18.11.2, the behaviour of the vhost
>> destroy callback has changed. DPDK 18.11.2 is now the default DPDK
>> release currently supported. DPDK 18.11.1 and below are no longer
>> supported.
>>
>> [1] 2b4e951cc341 ("vhost: fix passing destroyed device to destroy
>> callback")
>>
>> Signed-off-by: Ian Stokes <ian.stokes@intel.com>
>> ---
>>  .travis/linux-build.sh                   | 2 +-
>>  Documentation/faq/releases.rst           | 2 +-
>>  Documentation/intro/install/dpdk.rst     | 8 ++++----
>>  Documentation/topics/dpdk/vhost-user.rst | 6 +++---
>>  NEWS                                     | 4 +++-
>>  5 files changed, 12 insertions(+), 10 deletions(-)
>>
>> diff --git a/.travis/linux-build.sh b/.travis/linux-build.sh
>> index 9d84411c5..17428fa6b 100755
>> --- a/.travis/linux-build.sh
>> +++ b/.travis/linux-build.sh
>> @@ -105,7 +105,7 @@ fi
>>
>>  if [ "$DPDK" ] || [ "$DPDK_SHARED" ]; then
>>      if [ -z "$DPDK_VER" ]; then
>> -        DPDK_VER="18.11.1"
>> +        DPDK_VER="18.11.2"
>>      fi
>>      install_dpdk $DPDK_VER
>>      if [ "$CC" = "clang" ]; then
>> diff --git a/Documentation/faq/releases.rst
>> b/Documentation/faq/releases.rst
>> index d9504d682..723d95f2f 100644
>> --- a/Documentation/faq/releases.rst
>> +++ b/Documentation/faq/releases.rst
>> @@ -177,7 +177,7 @@ Q: What DPDK version does each Open vSwitch release
>> work with?
>>      2.8.x        17.05.2
>>      2.9.x        17.11.4
>>      2.10.x       17.11.4
>> -    2.11.x       18.11.1
>> +    2.11.x       18.11.2
>>      ============ =======
>>
>>  Q: Are all the DPDK releases that OVS versions work with maintained?
>> diff --git a/Documentation/intro/install/dpdk.rst
>> b/Documentation/intro/install/dpdk.rst
>> index 149548bc1..6e5f1ea60 100644
>> --- a/Documentation/intro/install/dpdk.rst
>> +++ b/Documentation/intro/install/dpdk.rst
>> @@ -42,7 +42,7 @@ Build requirements
>>  In addition to the requirements described in :doc:`general`, building
>> Open
>>  vSwitch with DPDK will require the following:
>>
>> -- DPDK 18.11.1
>> +- DPDK 18.11.2
>>
>>  - A `DPDK supported NIC`_
>>
>> @@ -71,9 +71,9 @@ Install DPDK
>>  #. Download the `DPDK sources`_, extract the file and set ``DPDK_DIR``::
>>
>>         $ cd /usr/src/
>> -       $ wget http://fast.dpdk.org/rel/dpdk-18.11.1.tar.xz
>> -       $ tar xf dpdk-18.11.1.tar.xz
>> -       $ export DPDK_DIR=/usr/src/dpdk-stable-18.11.1
>> +       $ wget http://fast.dpdk.org/rel/dpdk-18.11.2.tar.xz
>> +       $ tar xf dpdk-18.11.2.tar.xz
>> +       $ export DPDK_DIR=/usr/src/dpdk-stable-18.11.2
>>         $ cd $DPDK_DIR
>>
>>  #. (Optional) Configure DPDK as a shared library
>> diff --git a/Documentation/topics/dpdk/vhost-user.rst
>> b/Documentation/topics/dpdk/vhost-user.rst
>> index f7b4b338e..ac5f46c43 100644
>> --- a/Documentation/topics/dpdk/vhost-user.rst
>> +++ b/Documentation/topics/dpdk/vhost-user.rst
>> @@ -367,9 +367,9 @@ To begin, instantiate a guest as described in
>> :ref:`dpdk-vhost-user` or
>>  DPDK sources to VM and build DPDK::
>>
>>      $ cd /root/dpdk/
>> -    $ wget http://fast.dpdk.org/rel/dpdk-18.11.1.tar.xz
>> -    $ tar xf dpdk-18.11.1.tar.xz
>> -    $ export DPDK_DIR=/root/dpdk/dpdk-stable-18.11.1
>> +    $ wget http://fast.dpdk.org/rel/dpdk-18.11.2.tar.xz
>> +    $ tar xf dpdk-18.11.2.tar.xz
>> +    $ export DPDK_DIR=/root/dpdk/dpdk-stable-18.11.2
>>      $ export DPDK_TARGET=x86_64-native-linuxapp-gcc
>>      $ export DPDK_BUILD=$DPDK_DIR/$DPDK_TARGET
>>      $ cd $DPDK_DIR
>> diff --git a/NEWS b/NEWS
>> index a38ab258f..4c6dc3124 100644
>> --- a/NEWS
>> +++ b/NEWS
>> @@ -4,7 +4,9 @@ Post-v2.11.0
>>       * New option 'other_config:dpdk-socket-limit' to limit amount of
>>         hugepage memory that can be used by DPDK.
>>       * Add support for vHost Post-copy Live Migration (experimental).
>> -     * OVS validated with DPDK 18.11.1 which is recommended to be used.
>> +     * DPDK:
> 
> Just spotted that the additional * DPDK above is unneeded, will spin a v2 if there any other comments.
> 
> Ian
>> +       - DPDK 18.11.2 is the new minimal supported version.
>> +       - DPDK 18.11.1 and lower is no longer supported.

Not a strong opinion, but maybe this should be part of David's patch?
i.e. for this patch we'll update "validated" version with 18.11.2,
and David will bump the "minimal supported" version in his patch along
with the actual changes to callback usage. This looks more consistent.
This will also allow us to not have strong 18.11.2 requirement (only
recommendation) for 2.11 branch where we'll not backport "enabled vhost
queues" patch-set.

What do you think?

Best regards, Ilya Maximets.
David Marchand June 20, 2019, 2:35 p.m. UTC | #3
On Thu, Jun 20, 2019 at 3:38 PM Ilya Maximets <i.maximets@samsung.com>
wrote:

> On 20.06.2019 16:16, Stokes, Ian wrote:
> >> Modify travis linux build script to use the latest DPDK stable release
> >> 18.11.2. Update docs for latest DPDK stable releases.
> >>
> >> Note: due to commit [1] in DPDK 18.11.2, the behaviour of the vhost
> >> destroy callback has changed. DPDK 18.11.2 is now the default DPDK
> >> release currently supported. DPDK 18.11.1 and below are no longer
> >> supported.
> >>
> >> [1] 2b4e951cc341 ("vhost: fix passing destroyed device to destroy
> >> callback")
> >>
> >> Signed-off-by: Ian Stokes <ian.stokes@intel.com>
> >> ---
> >>  .travis/linux-build.sh                   | 2 +-
> >>  Documentation/faq/releases.rst           | 2 +-
> >>  Documentation/intro/install/dpdk.rst     | 8 ++++----
> >>  Documentation/topics/dpdk/vhost-user.rst | 6 +++---
> >>  NEWS                                     | 4 +++-
> >>  5 files changed, 12 insertions(+), 10 deletions(-)
> >>
> >> diff --git a/.travis/linux-build.sh b/.travis/linux-build.sh
> >> index 9d84411c5..17428fa6b 100755
> >> --- a/.travis/linux-build.sh
> >> +++ b/.travis/linux-build.sh
> >> @@ -105,7 +105,7 @@ fi
> >>
> >>  if [ "$DPDK" ] || [ "$DPDK_SHARED" ]; then
> >>      if [ -z "$DPDK_VER" ]; then
> >> -        DPDK_VER="18.11.1"
> >> +        DPDK_VER="18.11.2"
> >>      fi
> >>      install_dpdk $DPDK_VER
> >>      if [ "$CC" = "clang" ]; then
> >> diff --git a/Documentation/faq/releases.rst
> >> b/Documentation/faq/releases.rst
> >> index d9504d682..723d95f2f 100644
> >> --- a/Documentation/faq/releases.rst
> >> +++ b/Documentation/faq/releases.rst
> >> @@ -177,7 +177,7 @@ Q: What DPDK version does each Open vSwitch release
> >> work with?
> >>      2.8.x        17.05.2
> >>      2.9.x        17.11.4
> >>      2.10.x       17.11.4
> >> -    2.11.x       18.11.1
> >> +    2.11.x       18.11.2
> >>      ============ =======
> >>
> >>  Q: Are all the DPDK releases that OVS versions work with maintained?
> >> diff --git a/Documentation/intro/install/dpdk.rst
> >> b/Documentation/intro/install/dpdk.rst
> >> index 149548bc1..6e5f1ea60 100644
> >> --- a/Documentation/intro/install/dpdk.rst
> >> +++ b/Documentation/intro/install/dpdk.rst
> >> @@ -42,7 +42,7 @@ Build requirements
> >>  In addition to the requirements described in :doc:`general`, building
> >> Open
> >>  vSwitch with DPDK will require the following:
> >>
> >> -- DPDK 18.11.1
> >> +- DPDK 18.11.2
> >>
> >>  - A `DPDK supported NIC`_
> >>
> >> @@ -71,9 +71,9 @@ Install DPDK
> >>  #. Download the `DPDK sources`_, extract the file and set
> ``DPDK_DIR``::
> >>
> >>         $ cd /usr/src/
> >> -       $ wget http://fast.dpdk.org/rel/dpdk-18.11.1.tar.xz
> >> -       $ tar xf dpdk-18.11.1.tar.xz
> >> -       $ export DPDK_DIR=/usr/src/dpdk-stable-18.11.1
> >> +       $ wget http://fast.dpdk.org/rel/dpdk-18.11.2.tar.xz
> >> +       $ tar xf dpdk-18.11.2.tar.xz
> >> +       $ export DPDK_DIR=/usr/src/dpdk-stable-18.11.2
> >>         $ cd $DPDK_DIR
> >>
> >>  #. (Optional) Configure DPDK as a shared library
> >> diff --git a/Documentation/topics/dpdk/vhost-user.rst
> >> b/Documentation/topics/dpdk/vhost-user.rst
> >> index f7b4b338e..ac5f46c43 100644
> >> --- a/Documentation/topics/dpdk/vhost-user.rst
> >> +++ b/Documentation/topics/dpdk/vhost-user.rst
> >> @@ -367,9 +367,9 @@ To begin, instantiate a guest as described in
> >> :ref:`dpdk-vhost-user` or
> >>  DPDK sources to VM and build DPDK::
> >>
> >>      $ cd /root/dpdk/
> >> -    $ wget http://fast.dpdk.org/rel/dpdk-18.11.1.tar.xz
> >> -    $ tar xf dpdk-18.11.1.tar.xz
> >> -    $ export DPDK_DIR=/root/dpdk/dpdk-stable-18.11.1
> >> +    $ wget http://fast.dpdk.org/rel/dpdk-18.11.2.tar.xz
> >> +    $ tar xf dpdk-18.11.2.tar.xz
> >> +    $ export DPDK_DIR=/root/dpdk/dpdk-stable-18.11.2
> >>      $ export DPDK_TARGET=x86_64-native-linuxapp-gcc
> >>      $ export DPDK_BUILD=$DPDK_DIR/$DPDK_TARGET
> >>      $ cd $DPDK_DIR
> >> diff --git a/NEWS b/NEWS
> >> index a38ab258f..4c6dc3124 100644
> >> --- a/NEWS
> >> +++ b/NEWS
> >> @@ -4,7 +4,9 @@ Post-v2.11.0
> >>       * New option 'other_config:dpdk-socket-limit' to limit amount of
> >>         hugepage memory that can be used by DPDK.
> >>       * Add support for vHost Post-copy Live Migration (experimental).
> >> -     * OVS validated with DPDK 18.11.1 which is recommended to be used.
> >> +     * DPDK:
> >
> > Just spotted that the additional * DPDK above is unneeded, will spin a
> v2 if there any other comments.
> >
> > Ian
> >> +       - DPDK 18.11.2 is the new minimal supported version.
> >> +       - DPDK 18.11.1 and lower is no longer supported.
>
> Not a strong opinion, but maybe this should be part of David's patch?
> i.e. for this patch we'll update "validated" version with 18.11.2,
> and David will bump the "minimal supported" version in his patch along
> with the actual changes to callback usage. This looks more consistent.
> This will also allow us to not have strong 18.11.2 requirement (only
> recommendation) for 2.11 branch where we'll not backport "enabled vhost
> queues" patch-set.
>
> What do you think?
>

Sounds good this way yes.
Stokes, Ian June 20, 2019, 3:26 p.m. UTC | #4
From: David Marchand [mailto:david.marchand@redhat.com]
Sent: Thursday, June 20, 2019 3:35 PM
To: Ilya Maximets <i.maximets@samsung.com>
Cc: Stokes, Ian <ian.stokes@intel.com>; dev@openvswitch.org; ktraynor@redhat.com
Subject: Re: [PATCH v1 1/1] dpdk: Use DPDK 18.11.2 release.



On Thu, Jun 20, 2019 at 3:38 PM Ilya Maximets <i.maximets@samsung.com<mailto:i.maximets@samsung.com>> wrote:
On 20.06.2019 16:16, Stokes, Ian wrote:
>> Modify travis linux build script to use the latest DPDK stable release
>> 18.11.2. Update docs for latest DPDK stable releases.
>>
>> Note: due to commit [1] in DPDK 18.11.2, the behaviour of the vhost
>> destroy callback has changed. DPDK 18.11.2 is now the default DPDK
>> release currently supported. DPDK 18.11.1 and below are no longer
>> supported.
>>
>> [1] 2b4e951cc341 ("vhost: fix passing destroyed device to destroy
>> callback")
>>
>> Signed-off-by: Ian Stokes <ian.stokes@intel.com<mailto:ian.stokes@intel.com>>
>> ---
>>  .travis/linux-build.sh                   | 2 +-
>>  Documentation/faq/releases.rst           | 2 +-
>>  Documentation/intro/install/dpdk.rst     | 8 ++++----
>>  Documentation/topics/dpdk/vhost-user.rst | 6 +++---
>>  NEWS                                     | 4 +++-
>>  5 files changed, 12 insertions(+), 10 deletions(-)
>>
>> diff --git a/.travis/linux-build.sh b/.travis/linux-build.sh
>> index 9d84411c5..17428fa6b 100755
>> --- a/.travis/linux-build.sh
>> +++ b/.travis/linux-build.sh
>> @@ -105,7 +105,7 @@ fi
>>
>>  if [ "$DPDK" ] || [ "$DPDK_SHARED" ]; then
>>      if [ -z "$DPDK_VER" ]; then
>> -        DPDK_VER="18.11.1"
>> +        DPDK_VER="18.11.2"
>>      fi
>>      install_dpdk $DPDK_VER
>>      if [ "$CC" = "clang" ]; then
>> diff --git a/Documentation/faq/releases.rst
>> b/Documentation/faq/releases.rst
>> index d9504d682..723d95f2f 100644
>> --- a/Documentation/faq/releases.rst
>> +++ b/Documentation/faq/releases.rst
>> @@ -177,7 +177,7 @@ Q: What DPDK version does each Open vSwitch release
>> work with?
>>      2.8.x        17.05.2
>>      2.9.x        17.11.4
>>      2.10.x       17.11.4
>> -    2.11.x       18.11.1
>> +    2.11.x       18.11.2
>>      ============ =======
>>
>>  Q: Are all the DPDK releases that OVS versions work with maintained?
>> diff --git a/Documentation/intro/install/dpdk.rst
>> b/Documentation/intro/install/dpdk.rst
>> index 149548bc1..6e5f1ea60 100644
>> --- a/Documentation/intro/install/dpdk.rst
>> +++ b/Documentation/intro/install/dpdk.rst
>> @@ -42,7 +42,7 @@ Build requirements
>>  In addition to the requirements described in :doc:`general`, building
>> Open
>>  vSwitch with DPDK will require the following:
>>
>> -- DPDK 18.11.1
>> +- DPDK 18.11.2
>>
>>  - A `DPDK supported NIC`_
>>
>> @@ -71,9 +71,9 @@ Install DPDK
>>  #. Download the `DPDK sources`_, extract the file and set ``DPDK_DIR``::
>>
>>         $ cd /usr/src/
>> -       $ wget http://fast.dpdk.org/rel/dpdk-18.11.1.tar.xz
>> -       $ tar xf dpdk-18.11.1.tar.xz
>> -       $ export DPDK_DIR=/usr/src/dpdk-stable-18.11.1
>> +       $ wget http://fast.dpdk.org/rel/dpdk-18.11.2.tar.xz
>> +       $ tar xf dpdk-18.11.2.tar.xz
>> +       $ export DPDK_DIR=/usr/src/dpdk-stable-18.11.2
>>         $ cd $DPDK_DIR
>>
>>  #. (Optional) Configure DPDK as a shared library
>> diff --git a/Documentation/topics/dpdk/vhost-user.rst
>> b/Documentation/topics/dpdk/vhost-user.rst
>> index f7b4b338e..ac5f46c43 100644
>> --- a/Documentation/topics/dpdk/vhost-user.rst
>> +++ b/Documentation/topics/dpdk/vhost-user.rst
>> @@ -367,9 +367,9 @@ To begin, instantiate a guest as described in
>> :ref:`dpdk-vhost-user` or
>>  DPDK sources to VM and build DPDK::
>>
>>      $ cd /root/dpdk/
>> -    $ wget http://fast.dpdk.org/rel/dpdk-18.11.1.tar.xz
>> -    $ tar xf dpdk-18.11.1.tar.xz
>> -    $ export DPDK_DIR=/root/dpdk/dpdk-stable-18.11.1
>> +    $ wget http://fast.dpdk.org/rel/dpdk-18.11.2.tar.xz
>> +    $ tar xf dpdk-18.11.2.tar.xz
>> +    $ export DPDK_DIR=/root/dpdk/dpdk-stable-18.11.2
>>      $ export DPDK_TARGET=x86_64-native-linuxapp-gcc
>>      $ export DPDK_BUILD=$DPDK_DIR/$DPDK_TARGET
>>      $ cd $DPDK_DIR
>> diff --git a/NEWS b/NEWS
>> index a38ab258f..4c6dc3124 100644
>> --- a/NEWS
>> +++ b/NEWS
>> @@ -4,7 +4,9 @@ Post-v2.11.0
>>       * New option 'other_config:dpdk-socket-limit' to limit amount of
>>         hugepage memory that can be used by DPDK.
>>       * Add support for vHost Post-copy Live Migration (experimental).
>> -     * OVS validated with DPDK 18.11.1 which is recommended to be used.
>> +     * DPDK:
>
> Just spotted that the additional * DPDK above is unneeded, will spin a v2 if there any other comments.
>
> Ian
>> +       - DPDK 18.11.2 is the new minimal supported version.
>> +       - DPDK 18.11.1 and lower is no longer supported.

Not a strong opinion, but maybe this should be part of David's patch?
i.e. for this patch we'll update "validated" version with 18.11.2,
and David will bump the "minimal supported" version in his patch along
with the actual changes to callback usage. This looks more consistent.
This will also allow us to not have strong 18.11.2 requirement (only
recommendation) for 2.11 branch where we'll not backport "enabled vhost
queues" patch-set.

What do you think?

Sounds good this way yes.

+1, sounds good to me.

Ian


--
David Marchand
diff mbox series

Patch

diff --git a/.travis/linux-build.sh b/.travis/linux-build.sh
index 9d84411c5..17428fa6b 100755
--- a/.travis/linux-build.sh
+++ b/.travis/linux-build.sh
@@ -105,7 +105,7 @@  fi
 
 if [ "$DPDK" ] || [ "$DPDK_SHARED" ]; then
     if [ -z "$DPDK_VER" ]; then
-        DPDK_VER="18.11.1"
+        DPDK_VER="18.11.2"
     fi
     install_dpdk $DPDK_VER
     if [ "$CC" = "clang" ]; then
diff --git a/Documentation/faq/releases.rst b/Documentation/faq/releases.rst
index d9504d682..723d95f2f 100644
--- a/Documentation/faq/releases.rst
+++ b/Documentation/faq/releases.rst
@@ -177,7 +177,7 @@  Q: What DPDK version does each Open vSwitch release work with?
     2.8.x        17.05.2
     2.9.x        17.11.4
     2.10.x       17.11.4
-    2.11.x       18.11.1
+    2.11.x       18.11.2
     ============ =======
 
 Q: Are all the DPDK releases that OVS versions work with maintained?
diff --git a/Documentation/intro/install/dpdk.rst b/Documentation/intro/install/dpdk.rst
index 149548bc1..6e5f1ea60 100644
--- a/Documentation/intro/install/dpdk.rst
+++ b/Documentation/intro/install/dpdk.rst
@@ -42,7 +42,7 @@  Build requirements
 In addition to the requirements described in :doc:`general`, building Open
 vSwitch with DPDK will require the following:
 
-- DPDK 18.11.1
+- DPDK 18.11.2
 
 - A `DPDK supported NIC`_
 
@@ -71,9 +71,9 @@  Install DPDK
 #. Download the `DPDK sources`_, extract the file and set ``DPDK_DIR``::
 
        $ cd /usr/src/
-       $ wget http://fast.dpdk.org/rel/dpdk-18.11.1.tar.xz
-       $ tar xf dpdk-18.11.1.tar.xz
-       $ export DPDK_DIR=/usr/src/dpdk-stable-18.11.1
+       $ wget http://fast.dpdk.org/rel/dpdk-18.11.2.tar.xz
+       $ tar xf dpdk-18.11.2.tar.xz
+       $ export DPDK_DIR=/usr/src/dpdk-stable-18.11.2
        $ cd $DPDK_DIR
 
 #. (Optional) Configure DPDK as a shared library
diff --git a/Documentation/topics/dpdk/vhost-user.rst b/Documentation/topics/dpdk/vhost-user.rst
index f7b4b338e..ac5f46c43 100644
--- a/Documentation/topics/dpdk/vhost-user.rst
+++ b/Documentation/topics/dpdk/vhost-user.rst
@@ -367,9 +367,9 @@  To begin, instantiate a guest as described in :ref:`dpdk-vhost-user` or
 DPDK sources to VM and build DPDK::
 
     $ cd /root/dpdk/
-    $ wget http://fast.dpdk.org/rel/dpdk-18.11.1.tar.xz
-    $ tar xf dpdk-18.11.1.tar.xz
-    $ export DPDK_DIR=/root/dpdk/dpdk-stable-18.11.1
+    $ wget http://fast.dpdk.org/rel/dpdk-18.11.2.tar.xz
+    $ tar xf dpdk-18.11.2.tar.xz
+    $ export DPDK_DIR=/root/dpdk/dpdk-stable-18.11.2
     $ export DPDK_TARGET=x86_64-native-linuxapp-gcc
     $ export DPDK_BUILD=$DPDK_DIR/$DPDK_TARGET
     $ cd $DPDK_DIR
diff --git a/NEWS b/NEWS
index a38ab258f..4c6dc3124 100644
--- a/NEWS
+++ b/NEWS
@@ -4,7 +4,9 @@  Post-v2.11.0
      * New option 'other_config:dpdk-socket-limit' to limit amount of
        hugepage memory that can be used by DPDK.
      * Add support for vHost Post-copy Live Migration (experimental).
-     * OVS validated with DPDK 18.11.1 which is recommended to be used.
+     * DPDK:
+       - DPDK 18.11.2 is the new minimal supported version.
+       - DPDK 18.11.1 and lower is no longer supported.
    - OpenFlow:
      * Removed support for OpenFlow 1.6 (draft), which ONF abandoned.
      * New action "check_pkt_larger".