| Message ID | 1556125410-11694-1-git-send-email-ian.stokes@intel.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | [ovs-dev,1/1] dpdk: Use DPDK 18.11.1 release. | expand |
"On 24.04.2019 20:03, Ian Stokes wrote: > Modify travis linux build script to use the latest > DPDK stable release 18.11.1. Update docs for latest > DPDK stable releases. > > Signed-off-by: Ian Stokes <ian.stokes@intel.com> > --- > .travis/linux-build.sh | 2 +- > Documentation/faq/releases.rst | 4 ++-- > Documentation/intro/install/dpdk.rst | 8 ++++---- > Documentation/topics/dpdk/vhost-user.rst | 6 +++--- > 4 files changed, 10 insertions(+), 10 deletions(-) Do we need a NEWS update for this change? 18.11.1 should not have any user-visible changes from the OVS point of view, however upcoming 18.11.2 will have in case we'll merge vhost destroy_connection related patch. The questions are: Are we going to add stable release updates to NEWS? Do we need to mention stable releases that has no direct impact on OVS itself? Best regards, Ilya Maximets.
On 4/25/2019 11:09 AM, Ilya Maximets wrote: > "On 24.04.2019 20:03, Ian Stokes wrote: >> Modify travis linux build script to use the latest >> DPDK stable release 18.11.1. Update docs for latest >> DPDK stable releases. >> >> Signed-off-by: Ian Stokes <ian.stokes@intel.com> >> --- >> .travis/linux-build.sh | 2 +- >> Documentation/faq/releases.rst | 4 ++-- >> Documentation/intro/install/dpdk.rst | 8 ++++---- >> Documentation/topics/dpdk/vhost-user.rst | 6 +++--- >> 4 files changed, 10 insertions(+), 10 deletions(-) > > Do we need a NEWS update for this change? > 18.11.1 should not have any user-visible changes from the OVS > point of view, however upcoming 18.11.2 will have in case we'll > merge vhost destroy_connection related patch. The questions are: > Are we going to add stable release updates to NEWS? We can, if people think it's of use. It's now mentioned in the release notes of 18.11.1 that OVS DPDK was validated, so adding an entry into NEWS for the next OVS dot release could help push users to use the correct DPDK to OVS release mapping. To date we still see users on xx.yy.0 LTS releases which I'd like to encourage to move on. > Do we need to mention stable releases that has no direct impact > on OVS itself? If it has no impact then we can just add an item into NEWS saying it's been validated and is supported. If there is a known impact then we should detail the nature of that impact, typically NEWS has an entry of 'various bug fixes' or something to that effect, are you thinking we should provide specifics of the bug fix that affects users as part of NEWS from now on? I don't see the harm once we are aware of it. Ian
On 25.04.2019 13:42, Ian Stokes wrote: > On 4/25/2019 11:09 AM, Ilya Maximets wrote: >> "On 24.04.2019 20:03, Ian Stokes wrote: >>> Modify travis linux build script to use the latest >>> DPDK stable release 18.11.1. Update docs for latest >>> DPDK stable releases. >>> >>> Signed-off-by: Ian Stokes <ian.stokes@intel.com> >>> --- >>> .travis/linux-build.sh | 2 +- >>> Documentation/faq/releases.rst | 4 ++-- >>> Documentation/intro/install/dpdk.rst | 8 ++++---- >>> Documentation/topics/dpdk/vhost-user.rst | 6 +++--- >>> 4 files changed, 10 insertions(+), 10 deletions(-) >> >> Do we need a NEWS update for this change? >> 18.11.1 should not have any user-visible changes from the OVS >> point of view, however upcoming 18.11.2 will have in case we'll >> merge vhost destroy_connection related patch. The questions are: >> Are we going to add stable release updates to NEWS? > We can, if people think it's of use. It's now mentioned in the release notes of 18.11.1 that OVS DPDK was validated, so adding an entry into NEWS for the next OVS dot release could help push users to use the correct DPDK to OVS release mapping. To date we still see users on xx.yy.0 LTS releases which I'd like to encourage to move on. OK. Sounds good. > >> Do we need to mention stable releases that has no direct impact >> on OVS itself? > If it has no impact then we can just add an item into NEWS saying it's been validated and is supported. OK. > If there is a known impact then we should detail the nature of that impact, typically NEWS has an entry of 'various bug fixes' or something to that effect, are you thinking we should provide specifics of the bug fix that affects users as part of NEWS from now on? I don't see the harm once we are aware of it. Yes, we can do that. Another option: * If there is no visible impact on OVS --> mention that new stable release validated. * If there is some impact (feature depends on a bug fix in a new stable DPDK) --> bump the minimal supported DPDK version. Like this: NEWS: * DPDK: - OVS validated with DPDK 18.11.1 which is recommended to use. * DPDK: - DPDK 18.11.2 is a new minimal supported version. - DPDK 18.11.1 and lower is no longer supported. The key point here is that we relay on bug fixes in a new stable DPDK and able to merge new functionality/fixes that depends on them in OVS. Thoughts? Best regards, Ilya Maximets.
On 26/04/2019 12:07, Ilya Maximets wrote: > On 25.04.2019 13:42, Ian Stokes wrote: >> On 4/25/2019 11:09 AM, Ilya Maximets wrote: >>> "On 24.04.2019 20:03, Ian Stokes wrote: >>>> Modify travis linux build script to use the latest >>>> DPDK stable release 18.11.1. Update docs for latest >>>> DPDK stable releases. >>>> >>>> Signed-off-by: Ian Stokes <ian.stokes@intel.com> >>>> --- >>>> .travis/linux-build.sh | 2 +- >>>> Documentation/faq/releases.rst | 4 ++-- >>>> Documentation/intro/install/dpdk.rst | 8 ++++---- >>>> Documentation/topics/dpdk/vhost-user.rst | 6 +++--- >>>> 4 files changed, 10 insertions(+), 10 deletions(-) >>> >>> Do we need a NEWS update for this change? >>> 18.11.1 should not have any user-visible changes from the OVS >>> point of view, however upcoming 18.11.2 will have in case we'll >>> merge vhost destroy_connection related patch. The questions are: >>> Are we going to add stable release updates to NEWS? >> We can, if people think it's of use. It's now mentioned in the release notes of 18.11.1 that OVS DPDK was validated, so adding an entry into NEWS for the next OVS dot release could help push users to use the correct DPDK to OVS release mapping. To date we still see users on xx.yy.0 LTS releases which I'd like to encourage to move on. > > OK. Sounds good. > Good idea, +1 >> >>> Do we need to mention stable releases that has no direct impact >>> on OVS itself? >> If it has no impact then we can just add an item into NEWS saying it's been validated and is supported. > > OK. > >> If there is a known impact then we should detail the nature of that impact, typically NEWS has an entry of 'various bug fixes' or something to that effect, are you thinking we should provide specifics of the bug fix that affects users as part of NEWS from now on? I don't see the harm once we are aware of it. > > Yes, we can do that. Another option: > * If there is no visible impact on OVS --> mention that new stable release validated. > * If there is some impact (feature depends on a bug fix in a new stable DPDK) > --> bump the minimal supported DPDK version. > > Like this: > NEWS: > * DPDK: > - OVS validated with DPDK 18.11.1 which is recommended to use. > > * DPDK: > - DPDK 18.11.2 is a new minimal supported version. > - DPDK 18.11.1 and lower is no longer supported. > > The key point here is that we relay on bug fixes in a new stable DPDK and able > to merge new functionality/fixes that depends on them in OVS. > > Thoughts? > LGTM, hopefully the latter will be a rare event. > Best regards, Ilya Maximets. >
On 24/04/2019 18:03, Ian Stokes wrote: > Modify travis linux build script to use the latest > DPDK stable release 18.11.1. Update docs for latest > DPDK stable releases. > > Signed-off-by: Ian Stokes <ian.stokes@intel.com> > --- > .travis/linux-build.sh | 2 +- > Documentation/faq/releases.rst | 4 ++-- > Documentation/intro/install/dpdk.rst | 8 ++++---- > Documentation/topics/dpdk/vhost-user.rst | 6 +++--- > 4 files changed, 10 insertions(+), 10 deletions(-) > > diff --git a/.travis/linux-build.sh b/.travis/linux-build.sh > index 0cf5da6af..d869713f7 100755 > --- a/.travis/linux-build.sh > +++ b/.travis/linux-build.sh > @@ -89,7 +89,7 @@ fi > > if [ "$DPDK" ] || [ "$DPDK_SHARED" ]; then > if [ -z "$DPDK_VER" ]; then > - DPDK_VER="18.11" > + DPDK_VER="18.11.1" Looks like there's logic to handle the the dpdk-stable- dir prefix in the travis prep code, and if it's been run through travis then it must be ok. > fi > install_dpdk $DPDK_VER > if [ "$CC" = "clang" ]; then > diff --git a/Documentation/faq/releases.rst b/Documentation/faq/releases.rst > index cd5aad162..6c5949b33 100644 > --- a/Documentation/faq/releases.rst > +++ b/Documentation/faq/releases.rst > @@ -173,11 +173,11 @@ Q: What DPDK version does each Open vSwitch release work with? > 2.4.x 2.0 > 2.5.x 2.2 > 2.6.x 16.07.2 > - 2.7.x 16.11.8 > + 2.7.x 16.11.9 Not strictly part of this change, but maybe you could update the 17.11's too (if they are ready) and add a generic comment in the commit message to say updating docs for other new stable releases. > 2.8.x 17.05.2 > 2.9.x 17.11.4 > 2.10.x 17.11.4 > - 2.11.x 18.11 > + 2.11.x 18.11.1 > ============ ======= > > Q: Are all the DPDK releases that OVS versions work with maintained? > diff --git a/Documentation/intro/install/dpdk.rst b/Documentation/intro/install/dpdk.rst > index 344d2b3a6..32b40c391 100644 > --- a/Documentation/intro/install/dpdk.rst > +++ b/Documentation/intro/install/dpdk.rst > @@ -42,7 +42,7 @@ Build requirements > In addition to the requirements described in :doc:`general`, building Open > vSwitch with DPDK will require the following: > > -- DPDK 18.11 > +- DPDK 18.11.1 > > - A `DPDK supported NIC`_ > > @@ -71,9 +71,9 @@ Install DPDK > #. Download the `DPDK sources`_, extract the file and set ``DPDK_DIR``:: > > $ cd /usr/src/ > - $ wget http://fast.dpdk.org/rel/dpdk-18.11.tar.xz > - $ tar xf dpdk-18.11.tar.xz > - $ export DPDK_DIR=/usr/src/dpdk-18.11 > + $ wget http://fast.dpdk.org/rel/dpdk-18.11.1.tar.xz > + $ tar xf dpdk-18.11.1.tar.xz > + $ export DPDK_DIR=/usr/src/dpdk-18.11.1 export DPDK_DIR=/usr/src/dpdk-stable-18.11.1 > $ cd $DPDK_DIR > > #. (Optional) Configure DPDK as a shared library > diff --git a/Documentation/topics/dpdk/vhost-user.rst b/Documentation/topics/dpdk/vhost-user.rst > index 993797de5..483e228e4 100644 > --- a/Documentation/topics/dpdk/vhost-user.rst > +++ b/Documentation/topics/dpdk/vhost-user.rst > @@ -320,9 +320,9 @@ To begin, instantiate a guest as described in :ref:`dpdk-vhost-user` or > DPDK sources to VM and build DPDK:: > > $ cd /root/dpdk/ > - $ wget http://fast.dpdk.org/rel/dpdk-18.11.tar.xz > - $ tar xf dpdk-18.11.tar.xz > - $ export DPDK_DIR=/root/dpdk/dpdk-18.11 > + $ wget http://fast.dpdk.org/rel/dpdk-18.11.1.tar.xz > + $ tar xf dpdk-18.11.1.tar.xz > + $ export DPDK_DIR=/root/dpdk/dpdk-18.11.1 export DPDK_DIR=/usr/src/dpdk-stable-18.11.1 > $ export DPDK_TARGET=x86_64-native-linuxapp-gcc > $ export DPDK_BUILD=$DPDK_DIR/$DPDK_TARGET > $ cd $DPDK_DIR >
On 5/2/2019 11:53 AM, Kevin Traynor wrote: > On 26/04/2019 12:07, Ilya Maximets wrote: >> On 25.04.2019 13:42, Ian Stokes wrote: >>> On 4/25/2019 11:09 AM, Ilya Maximets wrote: >>>> "On 24.04.2019 20:03, Ian Stokes wrote: >>>>> Modify travis linux build script to use the latest >>>>> DPDK stable release 18.11.1. Update docs for latest >>>>> DPDK stable releases. >>>>> >>>>> Signed-off-by: Ian Stokes <ian.stokes@intel.com> >>>>> --- >>>>> .travis/linux-build.sh | 2 +- >>>>> Documentation/faq/releases.rst | 4 ++-- >>>>> Documentation/intro/install/dpdk.rst | 8 ++++---- >>>>> Documentation/topics/dpdk/vhost-user.rst | 6 +++--- >>>>> 4 files changed, 10 insertions(+), 10 deletions(-) >>>> >>>> Do we need a NEWS update for this change? >>>> 18.11.1 should not have any user-visible changes from the OVS >>>> point of view, however upcoming 18.11.2 will have in case we'll >>>> merge vhost destroy_connection related patch. The questions are: >>>> Are we going to add stable release updates to NEWS? >>> We can, if people think it's of use. It's now mentioned in the release notes of 18.11.1 that OVS DPDK was validated, so adding an entry into NEWS for the next OVS dot release could help push users to use the correct DPDK to OVS release mapping. To date we still see users on xx.yy.0 LTS releases which I'd like to encourage to move on. >> >> OK. Sounds good. >> > > Good idea, +1 > >>> >>>> Do we need to mention stable releases that has no direct impact >>>> on OVS itself? >>> If it has no impact then we can just add an item into NEWS saying it's been validated and is supported. >> >> OK. >> >>> If there is a known impact then we should detail the nature of that impact, typically NEWS has an entry of 'various bug fixes' or something to that effect, are you thinking we should provide specifics of the bug fix that affects users as part of NEWS from now on? I don't see the harm once we are aware of it. >> >> Yes, we can do that. Another option: >> * If there is no visible impact on OVS --> mention that new stable release validated. >> * If there is some impact (feature depends on a bug fix in a new stable DPDK) >> --> bump the minimal supported DPDK version. >> >> Like this: >> NEWS: >> * DPDK: >> - OVS validated with DPDK 18.11.1 which is recommended to use. >> >> * DPDK: >> - DPDK 18.11.2 is a new minimal supported version. >> - DPDK 18.11.1 and lower is no longer supported. >> >> The key point here is that we relay on bug fixes in a new stable DPDK and able >> to merge new functionality/fixes that depends on them in OVS. >> >> Thoughts? >> > > LGTM, hopefully the latter will be a rare event. > +1, above lloks good. Will work this into the v2. Ian >> Best regards, Ilya Maximets. >> >
On 5/2/2019 12:15 PM, Kevin Traynor wrote: > On 24/04/2019 18:03, Ian Stokes wrote: >> Modify travis linux build script to use the latest >> DPDK stable release 18.11.1. Update docs for latest >> DPDK stable releases. >> >> Signed-off-by: Ian Stokes <ian.stokes@intel.com> >> --- >> .travis/linux-build.sh | 2 +- >> Documentation/faq/releases.rst | 4 ++-- >> Documentation/intro/install/dpdk.rst | 8 ++++---- >> Documentation/topics/dpdk/vhost-user.rst | 6 +++--- >> 4 files changed, 10 insertions(+), 10 deletions(-) >> >> diff --git a/.travis/linux-build.sh b/.travis/linux-build.sh >> index 0cf5da6af..d869713f7 100755 >> --- a/.travis/linux-build.sh >> +++ b/.travis/linux-build.sh >> @@ -89,7 +89,7 @@ fi >> >> if [ "$DPDK" ] || [ "$DPDK_SHARED" ]; then >> if [ -z "$DPDK_VER" ]; then >> - DPDK_VER="18.11" >> + DPDK_VER="18.11.1" > > Looks like there's logic to handle the the dpdk-stable- dir prefix in > the travis prep code, and if it's been run through travis then it must > be ok. Yes. The function install_dpdk below will take the version we request and execute wget https://fast.dpdk.org/rel/dpdk-$DPDK_VER.tar.xz. The logic happens after that with the folloiwng tar xvf dpdk-$1.tar.xz > /dev/null DIR_NAME=$(tar -tf dpdk-$1.tar.xz | head -1 | cut -f1 -d"/") if [ $DIR_NAME != "dpdk-$1" ]; then mv $DIR_NAME dpdk-$1; fi So we should be ok. > >> fi >> install_dpdk $DPDK_VER >> if [ "$CC" = "clang" ]; then >> diff --git a/Documentation/faq/releases.rst b/Documentation/faq/releases.rst >> index cd5aad162..6c5949b33 100644 >> --- a/Documentation/faq/releases.rst >> +++ b/Documentation/faq/releases.rst >> @@ -173,11 +173,11 @@ Q: What DPDK version does each Open vSwitch release work with? >> 2.4.x 2.0 >> 2.5.x 2.2 >> 2.6.x 16.07.2 >> - 2.7.x 16.11.8 >> + 2.7.x 16.11.9 > > Not strictly part of this change, but maybe you could update the 17.11's > too (if they are ready) and add a generic comment in the commit message > to say updating docs for other new stable releases. Good point, Yes I was going to wait until the 17.11.6 release was ready, it was at rc1 at the time of testing, there was validation issues with 17.11.5 so I think the decision was to hold off until 17.11.6. I was thinking we could update at a later stage when 17.11.6 is ready. > >> 2.8.x 17.05.2 >> 2.9.x 17.11.4 >> 2.10.x 17.11.4 >> - 2.11.x 18.11 >> + 2.11.x 18.11.1 >> ============ ======= >> >> Q: Are all the DPDK releases that OVS versions work with maintained? >> diff --git a/Documentation/intro/install/dpdk.rst b/Documentation/intro/install/dpdk.rst >> index 344d2b3a6..32b40c391 100644 >> --- a/Documentation/intro/install/dpdk.rst >> +++ b/Documentation/intro/install/dpdk.rst >> @@ -42,7 +42,7 @@ Build requirements >> In addition to the requirements described in :doc:`general`, building Open >> vSwitch with DPDK will require the following: >> >> -- DPDK 18.11 >> +- DPDK 18.11.1 >> >> - A `DPDK supported NIC`_ >> >> @@ -71,9 +71,9 @@ Install DPDK >> #. Download the `DPDK sources`_, extract the file and set ``DPDK_DIR``:: >> >> $ cd /usr/src/ >> - $ wget http://fast.dpdk.org/rel/dpdk-18.11.tar.xz >> - $ tar xf dpdk-18.11.tar.xz >> - $ export DPDK_DIR=/usr/src/dpdk-18.11 >> + $ wget http://fast.dpdk.org/rel/dpdk-18.11.1.tar.xz >> + $ tar xf dpdk-18.11.1.tar.xz >> + $ export DPDK_DIR=/usr/src/dpdk-18.11.1 > > export DPDK_DIR=/usr/src/dpdk-stable-18.11.1 Yes, good catch. > >> $ cd $DPDK_DIR >> >> #. (Optional) Configure DPDK as a shared library >> diff --git a/Documentation/topics/dpdk/vhost-user.rst b/Documentation/topics/dpdk/vhost-user.rst >> index 993797de5..483e228e4 100644 >> --- a/Documentation/topics/dpdk/vhost-user.rst >> +++ b/Documentation/topics/dpdk/vhost-user.rst >> @@ -320,9 +320,9 @@ To begin, instantiate a guest as described in :ref:`dpdk-vhost-user` or >> DPDK sources to VM and build DPDK:: >> >> $ cd /root/dpdk/ >> - $ wget http://fast.dpdk.org/rel/dpdk-18.11.tar.xz >> - $ tar xf dpdk-18.11.tar.xz >> - $ export DPDK_DIR=/root/dpdk/dpdk-18.11 >> + $ wget http://fast.dpdk.org/rel/dpdk-18.11.1.tar.xz >> + $ tar xf dpdk-18.11.1.tar.xz >> + $ export DPDK_DIR=/root/dpdk/dpdk-18.11.1 > > export DPDK_DIR=/usr/src/dpdk-stable-18.11.1 Good catch, will change for the v2. Thanks Ian > >> $ export DPDK_TARGET=x86_64-native-linuxapp-gcc >> $ export DPDK_BUILD=$DPDK_DIR/$DPDK_TARGET >> $ cd $DPDK_DIR >> >
diff --git a/.travis/linux-build.sh b/.travis/linux-build.sh index 0cf5da6af..d869713f7 100755 --- a/.travis/linux-build.sh +++ b/.travis/linux-build.sh @@ -89,7 +89,7 @@ fi if [ "$DPDK" ] || [ "$DPDK_SHARED" ]; then if [ -z "$DPDK_VER" ]; then - DPDK_VER="18.11" + DPDK_VER="18.11.1" fi install_dpdk $DPDK_VER if [ "$CC" = "clang" ]; then diff --git a/Documentation/faq/releases.rst b/Documentation/faq/releases.rst index cd5aad162..6c5949b33 100644 --- a/Documentation/faq/releases.rst +++ b/Documentation/faq/releases.rst @@ -173,11 +173,11 @@ Q: What DPDK version does each Open vSwitch release work with? 2.4.x 2.0 2.5.x 2.2 2.6.x 16.07.2 - 2.7.x 16.11.8 + 2.7.x 16.11.9 2.8.x 17.05.2 2.9.x 17.11.4 2.10.x 17.11.4 - 2.11.x 18.11 + 2.11.x 18.11.1 ============ ======= Q: Are all the DPDK releases that OVS versions work with maintained? diff --git a/Documentation/intro/install/dpdk.rst b/Documentation/intro/install/dpdk.rst index 344d2b3a6..32b40c391 100644 --- a/Documentation/intro/install/dpdk.rst +++ b/Documentation/intro/install/dpdk.rst @@ -42,7 +42,7 @@ Build requirements In addition to the requirements described in :doc:`general`, building Open vSwitch with DPDK will require the following: -- DPDK 18.11 +- DPDK 18.11.1 - A `DPDK supported NIC`_ @@ -71,9 +71,9 @@ Install DPDK #. Download the `DPDK sources`_, extract the file and set ``DPDK_DIR``:: $ cd /usr/src/ - $ wget http://fast.dpdk.org/rel/dpdk-18.11.tar.xz - $ tar xf dpdk-18.11.tar.xz - $ export DPDK_DIR=/usr/src/dpdk-18.11 + $ wget http://fast.dpdk.org/rel/dpdk-18.11.1.tar.xz + $ tar xf dpdk-18.11.1.tar.xz + $ export DPDK_DIR=/usr/src/dpdk-18.11.1 $ cd $DPDK_DIR #. (Optional) Configure DPDK as a shared library diff --git a/Documentation/topics/dpdk/vhost-user.rst b/Documentation/topics/dpdk/vhost-user.rst index 993797de5..483e228e4 100644 --- a/Documentation/topics/dpdk/vhost-user.rst +++ b/Documentation/topics/dpdk/vhost-user.rst @@ -320,9 +320,9 @@ To begin, instantiate a guest as described in :ref:`dpdk-vhost-user` or DPDK sources to VM and build DPDK:: $ cd /root/dpdk/ - $ wget http://fast.dpdk.org/rel/dpdk-18.11.tar.xz - $ tar xf dpdk-18.11.tar.xz - $ export DPDK_DIR=/root/dpdk/dpdk-18.11 + $ wget http://fast.dpdk.org/rel/dpdk-18.11.1.tar.xz + $ tar xf dpdk-18.11.1.tar.xz + $ export DPDK_DIR=/root/dpdk/dpdk-18.11.1 $ export DPDK_TARGET=x86_64-native-linuxapp-gcc $ export DPDK_BUILD=$DPDK_DIR/$DPDK_TARGET $ cd $DPDK_DIR
Modify travis linux build script to use the latest DPDK stable release 18.11.1. Update docs for latest DPDK stable releases. Signed-off-by: Ian Stokes <ian.stokes@intel.com> --- .travis/linux-build.sh | 2 +- Documentation/faq/releases.rst | 4 ++-- Documentation/intro/install/dpdk.rst | 8 ++++---- Documentation/topics/dpdk/vhost-user.rst | 6 +++--- 4 files changed, 10 insertions(+), 10 deletions(-)