From patchwork Mon Feb 11 02:56:26 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Darrell Ball X-Patchwork-Id: 1039574 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=openvswitch.org (client-ip=140.211.169.12; helo=mail.linuxfoundation.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="KkuSPW49"; dkim-atps=neutral Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 43yVqD1NwYz9s5c for ; Mon, 11 Feb 2019 13:58:48 +1100 (AEDT) Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id D418022F3; Mon, 11 Feb 2019 02:57:01 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@mail.linuxfoundation.org Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id 6F4A222C5 for ; Mon, 11 Feb 2019 02:56:46 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.7.6 Received: from mail-pl1-f194.google.com (mail-pl1-f194.google.com [209.85.214.194]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id 3A9385E4 for ; Mon, 11 Feb 2019 02:56:46 +0000 (UTC) Received: by mail-pl1-f194.google.com with SMTP id 101so4616609pld.6 for ; Sun, 10 Feb 2019 18:56:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:in-reply-to:references; bh=EByjOjpFsENuwmJWhluEl0yFSbKE1iAqpi6Sv9WLjsQ=; b=KkuSPW49GgweDr7HkfWvPO9BDSIYkHciBGFbKV1qdoSyOrO55KLkCugsTF9X7h2Y3B 8G8JWpew4P9eezU9RYeWHzh7qHNRpf6jwfSMdNL+CGfyOnDwBwAGqrU82EmPat+aCQ4Y dVnmpANdsblwz6SDdA4M+ZtM9ud/ZJ1mhmsDZj/uBc4yxRoCssPu/3tdNv/w4rad+caQ SQe4/Kt2NzqR8byytabxQacAaFHbpn8YVPY6tEd4LnTljgXvljhZcMCdxULVVJffngiK 7OnxDD8+WWws6M7G24pnV8BahTS/4YL2knIUFAn7z/U362pT4gAVBxkInbtZCjOUC0xa bbXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references; bh=EByjOjpFsENuwmJWhluEl0yFSbKE1iAqpi6Sv9WLjsQ=; b=hz6QWNN4drctt4ze3WSwnrEi3L7cGp2the1D+VOh2F1yvmX6T3F+GclVo2mPXPcqxU WuUCG/xETkiuoa6uuRopxlc7pLUc9a8XSsay0iXgB1AQ5907nZMuCQs+Gz/6H9/z393i shbIsOtbCXnV7dqGLd//LaIxyrOZ+aNWyLjwVX86hQUFS7YSAyu5tRPUtR6CR9jeGz9q XcT4+iX20IFPxGSHiry7FNPc6BhFlozagebDAD05oFOD0DvlXLFM09grant8N1t7f377 YuJSYot/MavuuwOQMkCWuNK1/X5MusxxwZWZK2R20rokJnVkiAEr/ivM9ETdgbJgisAw gC5g== X-Gm-Message-State: AHQUAuYVBC4NDvGLHcVS4IIAn8X4/LpoCWWobJQ+Biwv0vIFlCs1O2Hc u5zJMYV3XETDWHBGr5fmfHw= X-Google-Smtp-Source: AHgI3IbJ7CVv76lsjpwUjvO6QmWARCAS7vYfU1Nws8huOPoumC+8/vF2RhT7a6R7XFrzLheOUiwhsw== X-Received: by 2002:a17:902:684:: with SMTP id 4mr35077787plh.3.1549853805864; Sun, 10 Feb 2019 18:56:45 -0800 (PST) Received: from ubuntu.localdomain (c-76-102-76-212.hsd1.ca.comcast.net. [76.102.76.212]) by smtp.gmail.com with ESMTPSA id b24sm12830895pfe.136.2019.02.10.18.56.45 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sun, 10 Feb 2019 18:56:45 -0800 (PST) From: Darrell Ball To: dlu998@gmail.com, dev@openvswitch.org Date: Sun, 10 Feb 2019 18:56:26 -0800 Message-Id: <1549853790-43330-5-git-send-email-dlu998@gmail.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1549853790-43330-1-git-send-email-dlu998@gmail.com> References: <1549853790-43330-1-git-send-email-dlu998@gmail.com> X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE autolearn=no version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on smtp1.linux-foundation.org Subject: [ovs-dev] [patch v12 4/8] conntrack: Reword conntrack_execute() description. X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: ovs-dev-bounces@openvswitch.org Errors-To: ovs-dev-bounces@openvswitch.org Use 'must' instead of 'should'. Suggested-by: Justin Pettit Signed-off-by: Darrell Ball --- lib/conntrack.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/conntrack.c b/lib/conntrack.c index 3bbe93f..b821c2d 100644 --- a/lib/conntrack.c +++ b/lib/conntrack.c @@ -1298,7 +1298,7 @@ process_one(struct conntrack *ct, struct dp_packet *pkt, } /* Sends the packets in '*pkt_batch' through the connection tracker 'ct'. All - * the packets should have the same 'dl_type' (IPv4 or IPv6) and should have + * the packets must have the same 'dl_type' (IPv4 or IPv6) and should have * the l3 and and l4 offset properly set. * * If 'commit' is true, the packets are allowed to create new entries in the