diff mbox series

[ovs-dev] ovn-controller: function ofctrl_inject_pkt() with wrong parameter

Message ID 1541118856-21310-1-git-send-email-xu.rong@zte.com.cn
State Superseded
Headers show
Series [ovs-dev] ovn-controller: function ofctrl_inject_pkt() with wrong parameter | expand

Commit Message

xurong00037997 Nov. 2, 2018, 12:34 a.m. UTC 
Signed-off-by: Xu Rong <xu.rong@zte.com.cn>

---
 ovn/controller/ovn-controller.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

0-day Robot Nov. 2, 2018, 12:56 a.m. UTC | #1 
Bleep bloop.  Greetings xurong00037997, I am a robot and I have tried out your patch.
Thanks for your contribution.

I encountered some error that I wasn't expecting.  See the details below.


checkpatch:
ERROR: Author xurong00037997 <xu.rong@zte.com.cn> needs to sign off.
WARNING: Unexpected sign-offs from developers who are not authors or co-authors or committers: Xu Rong <xu.rong@zte.com.cn>
Lines checked: 27, Warnings: 1, Errors: 1


Please check this out.  If you feel there has been an error, please email aconole@bytheb.org

Thanks,
0-day Robot
Ben Pfaff Nov. 2, 2018, 8:52 p.m. UTC | #2 
On Fri, Nov 02, 2018 at 08:34:16AM +0800, xurong00037997 wrote:
> Signed-off-by: Xu Rong <xu.rong@zte.com.cn>

Thanks for finding the bug and fixing it!  I applied this to master and
branch-2.10.
diff mbox series

Patch

diff --git a/ovn/controller/ovn-controller.c b/ovn/controller/ovn-controller.c
index 2b2779a..dd481b6 100644
--- a/ovn/controller/ovn-controller.c
+++ b/ovn/controller/ovn-controller.c
@@ -792,7 +792,7 @@  main(int argc, char *argv[])
 
                 if (pending_pkt.conn) {
                     char *error = ofctrl_inject_pkt(br_int, pending_pkt.flow_s,
-                                                    &port_groups, &addr_sets);
+                                                    &addr_sets, &port_groups);
                     if (error) {
                         unixctl_command_reply_error(pending_pkt.conn, error);
                         free(error);